GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: use Object.hasOwn() instead of hasOwnProperty() by Trott · Pull Request #41769 · nodejs/node

Conversation

@Trott

@Trott Trott commented Jan 30, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
benchmark: use Object.hasOwn() instead of hasOwnProperty()
29849c4
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. http Issues and PRs related to the http subsystem. labels Jan 30, 2022
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed http Issues and PRs related to the http subsystem. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. labels Jan 30, 2022
Mesteery
Mesteery approved these changes Jan 30, 2022
View reviewed changes
benjamingr
benjamingr approved these changes Jan 30, 2022
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 30, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott Trott added author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Jan 30, 2022
@github-actions

github-actions Bot commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
Mesteery, addaleax, and benjamingr reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added dont-land-on-v12.x labels Jan 30, 2022
addaleax
addaleax approved these changes Jan 30, 2022
View reviewed changes
@benjamingr benjamingr added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jan 30, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42244/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjamingr

benjamingr commented Jan 30, 2022

Copy link
Copy Markdown
Member

(Ci doesn't test benchmarks so I assume this is to please commit-queue?)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jan 30, 2022

Copy link
Copy Markdown
Member Author

(Ci doesn't test benchmarks so I assume this is to please commit-queue?)

CI does test benchmarks.

https://ci.nodejs.org/job/node-test-commit-linux/44499/nodes=ubuntu1804-64/console

06:46:50 ok 3382 benchmark/test-benchmark-assert
06:46:51   ---
06:46:51   duration_ms: 1.112
06:46:51   ...
06:46:51 ok 3383 benchmark/test-benchmark-async-hooks
06:46:52   ---
06:46:52   duration_ms: 0.910
06:46:52   ...
06:46:52 ok 3384 benchmark/test-benchmark-buffer
06:46:55   ---
06:46:55   duration_ms: 3.114
benjamingr and Mesteery reacted with thumbs up emoji benjamingr reacted with eyes emoji
All reactions
  • 👍 2 reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42255/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jan 31, 2022
CI Reliability 2022-01-31 nodejs/reliability#188
Open
28 tasks
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 31, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 31, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 96e81df into nodejs:master Jan 31, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator

Landed in 96e81df
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the hasOwn2 branch January 31, 2022 02:34
This was referenced Feb 1, 2022
CI Reliability 2022-02-01 nodejs/reliability#189
Open
CI Reliability 2022-02-02 nodejs/reliability#190
Open
This was referenced Feb 3, 2022
CI Reliability 2022-02-03 nodejs/reliability#191
Open
CI Reliability 2022-02-04 nodejs/reliability#192
Open
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@Trott @ruyadorno
benchmark: use Object.hasOwn() instead of hasOwnProperty()
28b95a5 
PR-URL: #41769
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
v17.5.0 release proposal #41897
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
benchmark: use Object.hasOwn() instead of hasOwnProperty()
96b7289 
PR-URL: #41769
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
v16.14.1 release proposal #42200
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
benchmark: use Object.hasOwn() instead of hasOwnProperty()
a1127fc 
PR-URL: #41769
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
benchmark: use Object.hasOwn() instead of hasOwnProperty()
2c566a9 
PR-URL: #41769
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@benjamingr benjamingr benjamingr approved these changes
+1 more reviewer
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Trott @nodejs-github-bot @benjamingr @addaleax @Mesteery @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.