GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: use Object.hasOwn() in util doc by Trott · Pull Request #41780 · nodejs/node

Conversation

@Trott

@Trott Trott commented Jan 31, 2022

Copy link
Copy Markdown
Member

Swtich from hasOwnProperty() to Object.hasOwn().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. util Issues and PRs related to the built-in util module. labels Jan 31, 2022
@Trott Trott added dont-land-on-v12.x fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Jan 31, 2022
@github-actions

github-actions Bot commented Jan 31, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
Mesteery, aduh95, and brandonapt reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
doc: use Object.hasOwn() in util doc
3c2d0df 
Swtich from `hasOwnProperty()` to `Object.hasOwn()`.
@Trott Trott changed the title doc: use Objec t.hasOwn in util doc doc: use Object.hasOwn() in util doc Jan 31, 2022
@Trott
Trott force-pushed the hasowndoc branch from c103957 to 3c2d0df Compare January 31, 2022 03:41
Mesteery
Mesteery approved these changes Jan 31, 2022
View reviewed changes
benjamingr
benjamingr approved these changes Jan 31, 2022
View reviewed changes

@benjamingr benjamingr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume this is for the eslint rule to run on the docs?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
aduh95
aduh95 approved these changes Jan 31, 2022
View reviewed changes
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Jan 31, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 31, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 4fbe9e5 into nodejs:master Jan 31, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator

Landed in 4fbe9e5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the hasowndoc branch January 31, 2022 22:33
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@Trott @ruyadorno
doc: use Object.hasOwn() in util doc
032df4e 
Swtich from `hasOwnProperty()` to `Object.hasOwn()`.

PR-URL: #41780
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
v17.5.0 release proposal #41897
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
doc: use Object.hasOwn() in util doc
3813e2b 
Swtich from `hasOwnProperty()` to `Object.hasOwn()`.

PR-URL: #41780
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
v16.14.1 release proposal #42200
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
doc: use Object.hasOwn() in util doc
1763239 
Swtich from `hasOwnProperty()` to `Object.hasOwn()`.

PR-URL: #41780
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
doc: use Object.hasOwn() in util doc
14ea8fc 
Swtich from `hasOwnProperty()` to `Object.hasOwn()`.

PR-URL: #41780
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @nodejs-github-bot @benjamingr @aduh95 @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.