GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add steam pipelining note on Http usage by RafaelGSS · Pull Request #41796 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Jan 31, 2022

Copy link
Copy Markdown
Member

Address: #26311

Reference: #41137

cc/@ronag @mcollina

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. stream Issues and PRs related to Node.js streams. labels Jan 31, 2022
@RafaelGSS RafaelGSS mentioned this pull request Jan 31, 2022
stream: manual destroy ServerResponse on pipeline #41137
Closed
Mesteery
Mesteery reviewed Jan 31, 2022
View reviewed changes
Comment thread doc/api/stream.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
ronag
ronag reviewed Jan 31, 2022
View reviewed changes
Comment thread doc/api/stream.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS
RafaelGSS force-pushed the doc/add-stream-pipeline-advice branch 2 times, most recently from fb8c5a9 to 7f235dc Compare January 31, 2022 20:30
ronag
ronag approved these changes Jan 31, 2022
View reviewed changes
@ronag
ronag requested a review from mcollina January 31, 2022 20:35
mcollina
mcollina approved these changes Jan 31, 2022
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mmarchini
mmarchini approved these changes Feb 1, 2022
View reviewed changes

@mmarchini mmarchini left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: replace steam with stream in commit message

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@RafaelGSS
doc: add stream pipelining note on Http usage
fd7932d
@RafaelGSS
RafaelGSS force-pushed the doc/add-stream-pipeline-advice branch from 7f235dc to fd7932d Compare February 1, 2022 12:35
mcollina
mcollina approved these changes Feb 2, 2022
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Feb 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42316/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Feb 3, 2022
CI Reliability 2022-02-03 nodejs/reliability#191
Open
41 tasks
@nodejs-github-bot

nodejs-github-bot commented Feb 3, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42333/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca reviewed Feb 3, 2022
View reviewed changes
Comment thread doc/api/stream.md
failure, this can cause event listener leaks and swallowed errors.

`stream.pipeline()` closes all the streams when an error is raised.
The `IncomingRequest` usage with `pipeline` could lead to an unexpected behavior

@lpinca lpinca Feb 3, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is IncomingRequest? Did you mean IncomingMessage? In the example below res is a ServerResponse or OutgoingMessage.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@RafaelGSS RafaelGSS Feb 4, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I meant an Incoming Request in general. The idea is to show that a socket/request usage with pipeline could lead to a error

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
This was referenced Feb 4, 2022
CI Reliability 2022-02-04 nodejs/reliability#192
Open
CI Reliability 2022-02-05 nodejs/reliability#193
Open
jasnell
jasnell approved these changes Feb 5, 2022
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Feb 6, 2022
CI Reliability 2022-02-06 nodejs/reliability#194
Open
27 tasks
@mcollina mcollina added the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 6, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 6, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 1c7a74e into nodejs:master Feb 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Feb 6, 2022

Copy link
Copy Markdown
Collaborator

Landed in 1c7a74e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Feb 7, 2022
CI Reliability 2022-02-07 nodejs/reliability#195
Open
29 tasks
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@RafaelGSS @ruyadorno
doc: add stream pipelining note on Http usage
5085813 
PR-URL: #41796
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
v17.5.0 release proposal #41897
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@RafaelGSS @danielleadams
doc: add stream pipelining note on Http usage
e4d8874 
PR-URL: #41796
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
v16.14.1 release proposal #42200
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@RafaelGSS @danielleadams
doc: add stream pipelining note on Http usage
2f9def8 
PR-URL: #41796
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@RafaelGSS @danielleadams
doc: add stream pipelining note on Http usage
3ac9e80 
PR-URL: nodejs#41796
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@RafaelGSS @danielleadams
doc: add stream pipelining note on Http usage
6fe708b 
PR-URL: #41796
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@RafaelGSS @danielleadams
doc: add stream pipelining note on Http usage
77685d5 
PR-URL: #41796
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jun 3, 2022
stream.pipeline destroys writable stream when error is occurred #26311
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca left review comments
@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@ronag ronag ronag approved these changes
+2 more reviewers
@Mesteery Mesteery Mesteery left review comments
@mmarchini mmarchini mmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. stream Issues and PRs related to Node.js streams.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@RafaelGSS @nodejs-github-bot @mcollina @jasnell @lpinca @ronag @mmarchini @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.