GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add missing commas in cluster docs by tniessen · Pull Request #41865 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Feb 5, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tniessen
doc: add missing commas in cluster docs
c291dfc
DerekNonGeneric
DerekNonGeneric approved these changes Feb 5, 2022
View reviewed changes
@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to Node.js documentation. labels Feb 5, 2022
lpinca
lpinca approved these changes Feb 5, 2022
View reviewed changes
@lpinca lpinca added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Feb 5, 2022
@github-actions

github-actions Bot commented Feb 5, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.
DerekNonGeneric, Trott, and Mesteery reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Feb 5, 2022
View reviewed changes
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 5, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Feb 5, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@DerekNonGeneric

DerekNonGeneric commented Feb 5, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@Trott, for doc-only changes, it seems a bit of a waste to be running the whole barrage of tests.

Not only does it waste time, but it also unnecessarily wastes electricity and may contribute to climate change.

Can we set up something to detect which type of tests we toggle based on the change reflected by the labels added?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Feb 5, 2022

Copy link
Copy Markdown
Member

@Trott, for doc-only changes, it seems a bit of a waste to be running the whole barrage of tests.

Not only does it waste time, but it also unnecessarily wastes electricity and may contribute to climate change.

Can we set up something to detect which type of tests we toggle based on the change reflected by the labels added?

We (usually) don't run Jenkins for doc changes, so we're already running only a fraction of what we do for code changes. We have logic in some of our GitHub Actions workflows to skip in some cases. Efforts to make that more robust would be welcome.
DerekNonGeneric reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mesteery
Mesteery approved these changes Feb 5, 2022
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 5, 2022
@nodejs-github-bot
nodejs-github-bot merged commit b8d994a into nodejs:master Feb 5, 2022
@nodejs-github-bot

nodejs-github-bot commented Feb 5, 2022

Copy link
Copy Markdown
Collaborator

Landed in b8d994a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@tniessen @ruyadorno
doc: add missing commas in cluster docs
1c62eb6 
PR-URL: #41865
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
v17.5.0 release proposal #41897
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@tniessen @danielleadams
doc: add missing commas in cluster docs
0a75c20 
PR-URL: #41865
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
v16.14.1 release proposal #42200
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@tniessen @danielleadams
doc: add missing commas in cluster docs
feae425 
PR-URL: #41865
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@tniessen @danielleadams
doc: add missing commas in cluster docs
7f52396 
PR-URL: nodejs#41865
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@tniessen @danielleadams
doc: add missing commas in cluster docs
9afe4c0 
PR-URL: #41865
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@tniessen @danielleadams
doc: add missing commas in cluster docs
5cd38a4 
PR-URL: #41865
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
+2 more reviewers
@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@tniessen @nodejs-github-bot @DerekNonGeneric @Trott @lpinca @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.