GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — build: add `nonpm` and `nocorepack` to `vcbuild.bat` by RaisinTen · Pull Request #43219 · nodejs/node

Conversation

RaisinTen commented May 27, 2022

Copy link

Copy Markdown

Member

The ./configure script allows you to produce a build without npm and
corepack with the --without-npm and --without-corepack options
respectively, so this change adds the same capability to the
vcbuild.bat script.

Signed-off-by: Darshan Sen [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          build: add nonpm and nocorepack to vcbuild.bat

4a75015

The `./configure` script allows you to produce a build without npm and
corepack with the `--without-npm` and `--without-corepack` options
respectively, so this change adds the same capability to the
`vcbuild.bat` script.

Signed-off-by: Darshan Sen <[email protected]>

nodejs-github-bot added build

Issues and PRs related to Node.js builds or CI infrastructure.

needs-ci

PRs that need a full CI run.

windows Issues and PRs related to the Windows platform. labels

May 27, 2022

This comment was marked as outdated.

nodejs-github-bot commented May 27, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44195/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca approved these changes

May 27, 2022

View reviewed changes

github-actions Bot mentioned this pull request

May 28, 2022

CI Reliability 2022-05-28 nodejs/reliability#291

Open

19 tasks

RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

May 28, 2022

This was referenced May 29, 2022

CI Reliability 2022-05-29 nodejs/reliability#292

Open

CI Reliability 2022-05-30 nodejs/reliability#293

Open

CI Reliability 2022-05-31 nodejs/reliability#294

Open

CI Reliability 2022-06-01 nodejs/reliability#295

Open

aduh95 approved these changes

Jun 2, 2022

View reviewed changes

aduh95 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there really no way of building Node.js without npm and Corepack before on Windows oO

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label

Jun 2, 2022

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Jun 2, 2022

nodejs-github-bot merged commit 9a11ea1 into nodejs:master

Jun 2, 2022

nodejs-github-bot commented Jun 2, 2022

Copy link

Copy Markdown

Collaborator

Landed in 9a11ea1

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RaisinTen deleted the build/add-nonpm-and-nocorepack-to-vcbuild.bat branch

June 2, 2022 16:18

RaisinTen commented Jun 2, 2022

Copy link

Copy Markdown

Member Author

Was there really no way of building Node.js without npm and Corepack before on Windows oO

Yea, exactly! I too was surprised when I found out.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danielleadams pushed a commit that referenced this pull request

Jun 11, 2022


          build: add nonpm and nocorepack to vcbuild.bat

7d54a4e

The `./configure` script allows you to produce a build without npm and
corepack with the `--without-npm` and `--without-corepack` options
respectively, so this change adds the same capability to the
`vcbuild.bat` script.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #43219
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

danielleadams mentioned this pull request

Jun 11, 2022

v18.4.0 proposal #43385

Merged

danielleadams pushed a commit that referenced this pull request

Jun 13, 2022


          build: add nonpm and nocorepack to vcbuild.bat

8d892f5

The `./configure` script allows you to produce a build without npm and
corepack with the `--without-npm` and `--without-corepack` options
respectively, so this change adds the same capability to the
`vcbuild.bat` script.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #43219
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

targos pushed a commit that referenced this pull request

Jul 12, 2022


          build: add nonpm and nocorepack to vcbuild.bat

47cd502

The `./configure` script allows you to produce a build without npm and
corepack with the `--without-npm` and `--without-corepack` options
respectively, so this change adds the same capability to the
`vcbuild.bat` script.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #43219
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

targos pushed a commit that referenced this pull request

Jul 31, 2022


          build: add nonpm and nocorepack to vcbuild.bat

ab55ff4

The `./configure` script allows you to produce a build without npm and
corepack with the `--without-npm` and `--without-corepack` options
respectively, so this change adds the same capability to the
`vcbuild.bat` script.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #43219
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

targos mentioned this pull request

Aug 3, 2022

v16.17.0 release proposal #44098

Merged

guangwong pushed a commit to noslate-project/node that referenced this pull request

Oct 10, 2022


          build: add nonpm and nocorepack to vcbuild.bat

f6c414c

The `./configure` script allows you to produce a build without npm and
corepack with the `--without-npm` and `--without-corepack` options
respectively, so this change adds the same capability to the
`vcbuild.bat` script.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: nodejs/node#43219
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

Reviewers

lpinca

lpinca approved these changes

aduh95

aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

build

Issues and PRs related to Node.js builds or CI infrastructure.

needs-ci

PRs that need a full CI run.

windows

Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.