GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — v18.4.0 proposal by danielleadams · Pull Request #43385 · nodejs/node

Conversation

danielleadams commented Jun 11, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

2022-06-16, Version 18.4.0 (Current), @danielleadams

Notable Changes

crypto:
- remove Node.js-specific webcrypto extensions (Filip Skokan) #43310
- add CFRG curves to Web Crypto API (Filip Skokan) #42507
dns:
- accept 'IPv4' and 'IPv6' for family (Antoine du Hamel) #43054
report:
- add more heap infos in process report (theanarkh) #43116

Commits

[702bfa0b7c] - async_hooks: use kEmptyObject (LiviaMedeiros) #43159
[f7c4015fd8] - bootstrap: consolidate global properties definition (Chengzhong Wu) #43357
[8d892f5259] - build: add nonpm and nocorepack to vcbuild.bat (Darshan Sen) #43219
[4109ddc005] - child_process: use kEmptyObject (LiviaMedeiros) #43159
[7b5cb14f0c] - cluster: use kEmptyObject (LiviaMedeiros) #43159
[9f1de2c005] - crypto: fix webcrypto import of cfrg raw public keys (Filip Skokan) #43404
[7f02e22998] - crypto: test webcrypto ec raw public key import (Filip Skokan) #43405
[0a075cb548] - crypto: fix webcrypto JWK EC and OKP import crv check (Filip Skokan) #43346
[df0903c8e8] - crypto: use kEmptyObject (LiviaMedeiros) #43159
[6d0053345e] - (SEMVER-MINOR) crypto: remove Node.js-specific webcrypto extensions (Filip Skokan) #43310
[28c034d6b5] - (SEMVER-MINOR) crypto: add CFRG curves to Web Crypto API (Filip Skokan) #42507
[fe7fd85109] - deps: update Corepack to 0.11.2 (Maël Nison) #43402
[517f17b214] - deps: update undici to 5.5.1 (Node.js GitHub Bot) #43412
[f4c830fbe4] - deps: upgrade npm to 8.12.1 (npm CLI robot) #43301
[0bb84b09a5] - (SEMVER-MINOR) dns: accept 'IPv4' and 'IPv6' for family (Antoine du Hamel) #43054
[f91babe494] - doc: packages documentation updates for 12 EOL (Guy Bedford) #43375
[066f963ec1] - doc: add initial doc on how to update cjs-module-lexer (Michael Dawson) #43255
[36e5684ae0] - doc: clarify use of deps/icu-small (Michael Dawson) #43287
[b9634e7ef3] - doc: remove llnode from diag tierlist (Tony Gorez) #43289
[4caeb10e7b] - doc: remove ETW from diag tierlist (Tony Gorez) #43295
[41955e5ce5] - doc: use serial comma in report docs (Tobias Nießen) #43394
[e30d4c1cb0] - doc: add fspromises mkdir example (Tierney Cyren) #40843
[adec5fa929] - doc: add F3n67u to triagers (Feng Yu) #43350
[cc3505b192] - doc: fix typo in globals.md (Daeyeon Jeong) #43365
[052c8eaf6a] - doc: use serial comma in webstreams docs (Tobias Nießen) #43353
[b824a0b7d0] - doc: fix specifier example in esm.md (hiroki osame) #43351
[d558b3c028] - doc: add undici to glossary (F3n67u) #43327
[f9ad98f5cb] - doc: change glossary link in pull request guide to node's glossary doc (Feng Yu) #43318
[02944a6783] - doc: fix typo in util.parseArgs usage example (Michael Ficarra) #43332
[f2bc6a3f71] - doc: improve description of TZ (Tobias Nießen) #43334
[9335ea6c35] - doc: use serial comma in net docs (Tobias Nießen) #43335
[05f38c6c3e] - doc: make clear the result of comparison between Symbol.for (Kohei Ueno) #43309
[c9aed9de9f] - doc: add missing require to stream api doc (Feng Yu) #43237
[f3188c1c9c] - doc: add CIGTM to glossary.md (Feng Yu) #43316
[c572d2d115] - doc: use serial comma in pull request doc (Feng Yu) #43319
[8a4e1fa002] - doc: use serial comma in ESM docs (Tobias Nießen) #43322
[fff0560a66] - doc: promote cdt to tier 3 (Tony Gorez) #43290
[7d0f6da97f] - doc: fix chromium document link in pull-requests.md (rikapo) #43265
[4674b0d2a5] - doc: fix 404 link of BUILDING.md (Feng Yu) #43234
[ee392c5c0b] - doc: update CHANGELOG_V18.md (Filip Skokan) #43298
[5a3a2a197f] - doc: add src/crypto to CC list for nodejs/crypto (Tobias Nießen) #43286
[69ce50396c] - doc: use serial comma in console docs (Tobias Nießen) #43257
[0c5092c51c] - events: fix adding abort listener in events.once (Daeyeon Jeong) #43373
[fda2105481] - events: use kEmptyObject (LiviaMedeiros) #43159
[63bf49b143] - fs: use kEmptyObject (LiviaMedeiros) #43159
[9b764531b9] - fs: export constants from fs/promises (Feng Yu) #43177
[a4409f85f8] - http: use kEmptyObject (LiviaMedeiros) #43159
[2ffd54105a] - http2: use kEmptyObject (LiviaMedeiros) #43159
[b468b8fe51] - https: use kEmptyObject (LiviaMedeiros) #43159
[d2a98dc6cf] - inspector: add missing initialization (Michael Dawson) #43254
[3b2f7eed39] - lib: use kEmptyObject in various places (LiviaMedeiros) #43159
[4a9511d971] - lib: give names to promisified methods (LiviaMedeiros) #43218
[b8644606eb] - lib: use null-prototype objects for property descriptors (Antoine du Hamel) #43270
[64edd6cbc3] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #43399
[b05cea57ba] - meta: update AUTHORS (Node.js GitHub Bot) #43387
[a8ecec57e3] - meta: move one or more collaborators to emeritus (meta: move one or more collaborators to emeritus #43183) (Node.js GitHub Bot) #43183
[60dc36244a] - meta: update AUTHORS (Node.js GitHub Bot) #43312
[9803b82ac7] - net,dns: move hasObserver out of perf function (theanarkh) #43217
[112518fb1d] - perf_hooks: fix function wrapped by timerify to work correctly (Kohei Ueno) #43330
[a3310d13bf] - perf_hooks: use kEmptyObject (LiviaMedeiros) #43159
[7e8a00a26d] - readline: fix question stack overflow (Eugene Chapko) #43320
[5e98cacf77] - readline: use kEmptyObject (LiviaMedeiros) #43159
[66d956ca49] - repl: make autocomplete case-insensitive (Sergey Petushkov) #41632
[201f3d7f56] - (SEMVER-MINOR) report: add more heap infos in process report (theanarkh) #43116
[a0568409b6] - src: fix json utils escapes for U+000B (Chengzhong Wu) #43206
[931ecfa033] - src: fix memory leaks and refactor ByteSource (Tobias Nießen) #43202
[5e65c1f3da] - src: convey potential exceptions during StreamPipe construction (Darshan Sen) #43240
[b200a5ff67] - stream: use kEmptyObject (LiviaMedeiros) #43159
[1cc1a57cdb] - test: remove unused argument in test-util-inspect.js (Colin Ihrig) #43395
[42c2115a82] - test: mark test_buffer/test_finalizer flaky (Michael Dawson) #43414
[71802c32d0] - test: fix address in use error (Caleb Everett) #43199
[e1b8c85a7a] - test: add test for short-option followed by its value (Kohei Ueno) #43358
[f8d26c6011] - test: fix common.mustNotCall error message (Antoine du Hamel) #42917
[18fffe6108] - test: convert then to async/await (Meek Simbule) #43292
[acd96d80eb] - test: add BigInts to common.getArrayBufferViews() (LiviaMedeiros) #43235
[e576a7fa50] - test_runner: use kEmptyObject (LiviaMedeiros) #43159
[fecad7a3a5] - timers: use kEmptyObject (LiviaMedeiros) #43159
[e31baca76a] - tls: use kEmptyObject (LiviaMedeiros) #43159
[7f8f61a749] - tls: fix performance regression in convertALPNProtocols() (LiviaMedeiros) #43250
[ac9599a718] - tools: report unsafe string and regex primordials as lint errors (Antoine du Hamel) #43393
[b69d874592] - tools: fix create-or-update-pull-request-action hash on GHA (Antoine du Hamel) #43378
[cf8a115983] - tools: add avoid-prototype-pollution lint rule (Antoine du Hamel) #43308
[8c0fe1e184] - tools: fix find-inactive actions (LiviaMedeiros) #43377
[7f45d69f83] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #43313
[d5d0f01c5a] - tools: update eslint to 8.17.0 (Node.js GitHub Bot) #43314
[f598fe1585] - tools: use hashes instead of tags for external actions (tools: use hashes instead of tags for external actions #43284) (Antoine du Hamel) #43284
[10f79947d9] - tools: update codecov/codecov-action version (Antoine du Hamel) #43297
[f93848fa50] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #43261
[b3d7dc1de8] - tools: update clang-format 1.7.0 to 1.8.0 (Darshan Sen) #43241
[812140c65a] - tools,doc: add guards against prototype pollution when creating proxies (Antoine du Hamel) #43391
[56b8cc5cef] - util: freeze kEnumerableProperty (LiviaMedeiros) #43390
[b187d55b6d] - util: add kEmptyObject to internal/util (LiviaMedeiros) #43159
[024b396275] - vm: use kEmptyObject (LiviaMedeiros) #43159
[7fc432fa35] - wasi: use kEmptyObject (LiviaMedeiros) #43159
[44b65d0ca7] - worker: use kEmptyObject (LiviaMedeiros) #43159

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

bricss reacted with hooray emoji

bricss reacted with heart emoji

bricss reacted with rocket emoji

All reactions

👍 1 reaction
🎉 1 reaction
❤️ 1 reaction
🚀 1 reaction

This comment was marked as off-topic.

nodejs-github-bot added build

Issues and PRs related to Node.js builds or CI infrastructure.

dependencies

PRs that add, update, or configure Node.js dependencies.

doc

Issues and PRs related to Node.js documentation.

This comment was marked as outdated.

GeoffreyBooth commented Jun 11, 2022

Copy link

Copy Markdown

Member

Hey, #42623 is blocked because we want to release a few PRs together. I see it listed in the notes here; is it included in this release? See a few others in the same situation: https://github.com/nodejs/node/issues?q=label%3Abackport-blocked-v18.x+sort%3Aupdated-desc+

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss commented Jun 12, 2022

Copy link

Copy Markdown

Contributor

Is it plausible to pull this #43301 in? 🤔

lpinca, danielleadams, and danez reacted with thumbs up emoji

All reactions

👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

VoltrexKeyva added release Issues and PRs related to Node.js releases. and removed doc

Issues and PRs related to Node.js documentation.

build

Issues and PRs related to Node.js builds or CI infrastructure.

danielleadams commented Jun 12, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

Hey, #42623 is blocked because we want to release a few PRs together. I see it listed in the notes here; is it included in this release? See a few others in the same situation: https://github.com/nodejs/node/issues?q=label%3Abackport-blocked-v18.x+sort%3Aupdated-desc+

@GeoffreyBooth yeah, you're correct. The tag filtering was giving me some trouble, and I didn't see to catch all of them. I'll run the diff again. Thanks!

GeoffreyBooth reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tniessen and others added 7 commits

June 12, 2022 19:25


          doc: use serial comma in console docs

69ce503

Refs: #11321
Refs: #17384

PR-URL: #43257
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          tools: update clang-format 1.7.0 to 1.8.0

b3d7dc1

v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel
Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel
and M1 Macs.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #43241
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          tools: update lint-md-dependencies to [email protected]

f93848f

PR-URL: #43261
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          doc: add src/crypto to CC list for nodejs/crypto

5a3a2a1

PR-URL: #43286
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>


          test: add BigInts to common.getArrayBufferViews()

acd96d8

PR-URL: #43235
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>


          doc: update CHANGELOG_V18.md

ee392c5

PR-URL: #43298
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>


          tools: update codecov/codecov-action version

10f7994

Refs: https://github.com/codecov/codecov-action/releases

PR-URL: #43297
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>

mhdawson and others added 14 commits

June 15, 2022 21:28


          doc: add initial doc on how to update cjs-module-lexer

066f963

Add some initial doc based on discussion with Guy
Bedford.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #43255
Reviewed-By: Guy Bedford <[email protected]>


          inspector: add missing initialization

d2a98dc

Add missing initialization reported by coverity. With
proper usage it looks like it will be initialized but
still good to have it initialized to a known state in
case that changes or invalide usage.

The method used to create object ids newObjectId() starts
at 1 so initializing to 0 should be safe and what we get
now when compiled in a way that auto initializes (for example
debug)

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #43254
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          deps: update undici to 5.5.1

517f17b

PR-URL: #43412
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          events: fix adding abort listener in events.once

0c5092c

Event listeners passed to un/subscribe the abort event are mismatched.
This removes the wrapper function in `eventTargetAgnosticAddListener()`
and directly passes the given listener to the `EventTarget`.

IMO, removing the wrapper seems harmless, and the `AbortSignal` is
seemingly the only `EventTarget` passed to this function for now.

Fixes: #43337
Refs: #33659
Refs: #34997

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43373
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>


          deps: update Corepack to 0.11.2

fe7fd85

PR-URL: #43402
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>


          util: freeze kEnumerableProperty

56b8cc5

PR-URL: #43390
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          crypto: fix webcrypto JWK EC and OKP import crv check

0a075cb

PR-URL: #43346
Reviewed-By: Tobias Nießen <[email protected]>


          crypto: test webcrypto ec raw public key import

7f02e22

PR-URL: #43405
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>


          crypto: fix webcrypto import of cfrg raw public keys

9f1de2c

PR-URL: #43404
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>


          test: remove unused argument in test-util-inspect.js

1cc1a57

PR-URL: #43395
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>


          doc: packages documentation updates for 12 EOL

f91babe

PR-URL: #43375
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>


          dns: accept 'IPv4' and 'IPv6' for family

0bb84b0

Refs: #43014

PR-URL: #43054
Fixes: #43014
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>


          tools: report unsafe string and regex primordials as lint errors

ac9599a

| The string method             | looks up the property |
| ----------------------------- | --------------------- |
| `String.prototype.match`      | `Symbol.match`        |
| `String.prototype.matchAll`   | `Symbol.matchAll`     |
| `String.prototype.replace`    | `Symbol.replace`      |
| `String.prototype.replaceAll` | `Symbol.replace`      |
| `String.prototype.search`     | `Symbol.search`       |
| `String.prototype.split`      | `Symbol.split`        |

Functions that lookup the `exec` property on the prototype chain:

* `RegExp.prototype[Symbol.match]`
* `RegExp.prototype[Symbol.matchAll]`
* `RegExp.prototype[Symbol.replace]`
* `RegExp.prototype[Symbol.search]`
* `RegExp.prototype[Symbol.split]`
* `RegExp.prototype.test`

`RegExp.prototype[Symbol.replace]` and `RegExp.prototype[Symbol.split]`
are still allowed for a lack of a better solution.

PR-URL: #43393
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          tools,doc: add guards against prototype pollution when creating proxies

812140c

PR-URL: #43391
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>

danielleadams force-pushed the v18.4.0-proposal branch from 1ebd250 to 40d7acc Compare

June 16, 2022 01:45


          2022-06-16, Version 18.4.0 (Current)

e339e9c

Notable changes:

* crypto:
  * remove Node.js-specific webcrypto extensions (Filip Skokan) #43310
  * add CFRG curves to Web Crypto API (Filip Skokan) #42507
* dns:
  * accept `'IPv4'` and `'IPv6'` for `family` (Antoine du Hamel) #43054
* report:
  * add more heap infos in process report (theanarkh) #43116

PR-URL: #43385

danielleadams force-pushed the v18.4.0-proposal branch from 40d7acc to e339e9c Compare

June 16, 2022 01:45

nodejs-github-bot commented Jun 16, 2022 •

edited by danielleadams

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44603/ ✅
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4733/ ✅

CITGM
18.3.0: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2956/
18.4.0: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2958/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mcollina commented Jun 16, 2022

Copy link

Copy Markdown

Member

This breaks fastify tests. It's ok as it's related to the interface change.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danielleadams commented Jun 16, 2022

Copy link

Copy Markdown

Contributor Author

This breaks fastify tests. It's ok as it's related to the interface change.

@mcollina good to know - thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danielleadams merged commit e339e9c into v18.x

Jun 16, 2022

danielleadams added a commit that referenced this pull request

Jun 16, 2022


          Working on v18.4.1

8af0b83

PR-URL: #43385

danielleadams added a commit that referenced this pull request

Jun 16, 2022


          2022-06-16, Version 18.4.0 (Current)

f50a80c

Notable changes:

* crypto:
  * remove Node.js-specific webcrypto extensions (Filip Skokan) #43310
  * add CFRG curves to Web Crypto API (Filip Skokan) #42507
* dns:
  * accept `'IPv4'` and `'IPv6'` for `family` (Antoine du Hamel) #43054
* report:
  * add more heap infos in process report (theanarkh) #43116

PR-URL: #43385

danielleadams added a commit to nodejs/nodejs.org that referenced this pull request

Jun 16, 2022


          Blog: v18.4.0 release post

60bef80

Refs: nodejs/node#43385

danielleadams mentioned this pull request

Jun 16, 2022

Blog: v18.4.0 release post nodejs/nodejs.org#4661

Merged

danielleadams deleted the v18.4.0-proposal branch

June 16, 2022 13:54

danielleadams added a commit to nodejs/nodejs.org that referenced this pull request

Jun 16, 2022


          Blog: v18.4.0 release post (#4661)

4b23ef1

Refs: nodejs/node#43385

This was referenced Jun 17, 2022

CI Reliability 2022-06-17 nodejs/reliability#303

Open

CI Reliability 2022-06-18 nodejs/reliability#304

Open

Reviewers

mcollina

mcollina approved these changes

tniessen

tniessen approved these changes

RafaelGSS

RafaelGSS approved these changes

RaisinTen

RaisinTen approved these changes

+1 more reviewer

mhdawson

mhdawson approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci

PRs that need a full CI run.

release

Issues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

danielleadams commented Jun 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2022-06-16, Version 18.4.0 (Current), @danielleadams

Notable Changes

Commits

Uh oh!

This comment was marked as off-topic.

This comment was marked as outdated.

GeoffreyBooth commented Jun 11, 2022

Uh oh!

bricss commented Jun 12, 2022

Uh oh!

danielleadams commented Jun 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 16, 2022 • edited by danielleadams Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcollina commented Jun 16, 2022

Uh oh!

danielleadams commented Jun 16, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

danielleadams commented Jun 11, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

danielleadams commented Jun 12, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Jun 16, 2022 •

edited by danielleadams

Loading

Uh oh!

There was an error while loading. Please reload this page.