GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update clang-format 1.7.0 to 1.8.0 by RaisinTen · Pull Request #43241 · nodejs/node

Conversation

@RaisinTen

@RaisinTen RaisinTen commented May 29, 2022

Copy link
Copy Markdown
Member

v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel
Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel
and M1 Macs.

Signed-off-by: Darshan Sen [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RaisinTen
tools: update clang-format 1.7.0 to 1.8.0
c853e34 
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel
Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel
and M1 Macs.

Signed-off-by: Darshan Sen <[email protected]>
@RaisinTen
RaisinTen requested a review from Trott May 29, 2022 12:29
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 29, 2022
tniessen
tniessen approved these changes May 29, 2022
View reviewed changes
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 29, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
Trott
Trott approved these changes May 29, 2022
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
VoltrexKeyva
VoltrexKeyva approved these changes May 29, 2022
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot mentioned this pull request May 30, 2022
CI Reliability 2022-05-30 nodejs/reliability#293
Open
18 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
lpinca
lpinca approved these changes May 30, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 30, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44240/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced May 31, 2022
CI Reliability 2022-05-31 nodejs/reliability#294
Open
CI Reliability 2022-06-01 nodejs/reliability#295
Open
@tniessen tniessen added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 1, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 7a71ae8 into nodejs:master Jun 1, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator

Landed in 7a71ae8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen
RaisinTen deleted the tools/update-clang-format-1.7.0-to-1.8.0 branch June 1, 2022 11:49
This was referenced Jun 2, 2022
CI Reliability 2022-06-02 nodejs/reliability#296
Open
CI Reliability 2022-06-03 nodejs/reliability#297
Open
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@RaisinTen @danielleadams
tools: update clang-format 1.7.0 to 1.8.0
7871af0 
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel
Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel
and M1 Macs.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #43241
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
v18.4.0 proposal #43385
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@RaisinTen @danielleadams
tools: update clang-format 1.7.0 to 1.8.0
b3d7dc1 
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel
Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel
and M1 Macs.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #43241
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@RaisinTen @targos
tools: update clang-format 1.7.0 to 1.8.0
65adeb5 
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel
Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel
and M1 Macs.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #43241
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@RaisinTen @targos
tools: update clang-format 1.7.0 to 1.8.0
9c03ddb 
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel
Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel
and M1 Macs.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #43241
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
v16.17.0 release proposal #44098
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@RaisinTen @guangwong
tools: update clang-format 1.7.0 to 1.8.0
0992547 
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel
Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel
and M1 Macs.

Signed-off-by: Darshan Sen <[email protected]>

PR-URL: nodejs/node#43241
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@RaisinTen @nodejs-github-bot @Trott @lpinca @tniessen @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.