GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update lint-md-dependencies to [email protected] by nodejs-github-bot · Pull Request #43261 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented May 31, 2022

Copy link
Copy Markdown
Collaborator

This is an automated update of lint-md-dependencies to [email protected].

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 31, 2022
Trott
Trott approved these changes May 31, 2022
View reviewed changes
@Trott Trott added fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels May 31, 2022
@github-actions

github-actions Bot commented May 31, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
VoltrexKeyva, RaisinTen, and lpinca reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 31, 2022
@nodejs-github-bot

nodejs-github-bot commented May 31, 2022

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/44255/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva approved these changes May 31, 2022
View reviewed changes
RaisinTen
RaisinTen approved these changes May 31, 2022
View reviewed changes
tniessen
tniessen approved these changes May 31, 2022
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a patch-only update with no real changes? This feels like a lot of noise for that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
lpinca
lpinca approved these changes May 31, 2022
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Jun 1, 2022
CI Reliability 2022-06-01 nodejs/reliability#295
Open
17 tasks
@Trott

Trott commented Jun 1, 2022

Copy link
Copy Markdown
Member

Not sure why neither the GitHub widget nor the nodejs-github-bot are picking up the fact that there's been more recent Jenkins runs but here are two ones that are going right now.

  • https://ci.nodejs.org/job/node-test-pull-request/44289/
  • https://ci.nodejs.org/job/node-test-pull-request/44290/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jun 1, 2022

Copy link
Copy Markdown
Member

This seems like a patch-only update with no real changes? This feels like a lot of noise for that.

You're not wrong, but still, for me, most of the noise is due to CI unreliability (and, uh, perhaps my own penchant for leaving lots of comments....). Otherwise, this would have been landed via fast-track far earlier.

I don't know if it was quite this small, but we had an issue where an update like this broke things on one of the containered builds in Jenkins, so I'm personally OK with small updates like this. Makes it easy to see when something broke instead of having to dig for the needle in the haystack of tons of dependencies being updated at once.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jun 1, 2022

Copy link
Copy Markdown
Member
  • https://ci.nodejs.org/job/node-test-pull-request/44290/

This one is green. Landing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Jun 1, 2022

Copy link
Copy Markdown
Member

Landed in 29c64ce
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott pushed a commit that referenced this pull request Jun 1, 2022
@nodejs-github-bot @Trott
tools: update lint-md-dependencies to [email protected]
29c64ce 
PR-URL: #43261
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Trott force-pushed the actions/tools-update-lint-md-dependencies branch from dd7b61a to 5418dd0 Compare June 1, 2022 14:10
@Trott Trott closed this Jun 1, 2022
@Trott
Trott force-pushed the actions/tools-update-lint-md-dependencies branch from 5418dd0 to 29c64ce Compare June 1, 2022 14:11
@Trott
Trott deleted the actions/tools-update-lint-md-dependencies branch June 1, 2022 14:11
@richardlau richardlau mentioned this pull request Jun 1, 2022
Rename primary branch to main nodejs/build#2761
Closed
This was referenced Jun 2, 2022
CI Reliability 2022-06-02 nodejs/reliability#296
Open
CI Reliability 2022-06-03 nodejs/reliability#297
Open
CI Reliability 2022-06-04 nodejs/reliability#298
Open
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@nodejs-github-bot @danielleadams
tools: update lint-md-dependencies to [email protected]
2c2966e 
PR-URL: #43261
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
v18.4.0 proposal #43385
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@nodejs-github-bot @danielleadams
tools: update lint-md-dependencies to [email protected]
f93848f 
PR-URL: #43261
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@nodejs-github-bot @targos
tools: update lint-md-dependencies to [email protected]
d37b5bf 
PR-URL: #43261
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@nodejs-github-bot @targos
tools: update lint-md-dependencies to [email protected]
276dff1 
PR-URL: #43261
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
v16.17.0 release proposal #44098
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@nodejs-github-bot @guangwong
tools: update lint-md-dependencies to [email protected]
8279e74 
PR-URL: nodejs/node#43261
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@nodejs-github-bot @Trott @lpinca @tniessen @RaisinTen @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.