GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add src/crypto to CC list for nodejs/crypto by tniessen · Pull Request #43286 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Jun 1, 2022

Copy link
Copy Markdown
Member

src/node_crypto.* has been refactored into many smaller files that are in src/crypto.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tniessen
doc: add src/crypto to CC list for nodejs/crypto
e38962d
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jun 1, 2022
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Jun 1, 2022
@github-actions

github-actions Bot commented Jun 1, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.
richardlau, marsonya, and aduh95 reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Jun 1, 2022
View reviewed changes
@tniessen

tniessen commented Jun 1, 2022

Copy link
Copy Markdown
Member Author

Also, @nodejs/crypto has very few active members who frequently review C++ changes, and we often have changes that require C++ knowledge but not so much crypto-specific knowledge. Maybe we should have a team to ping for C++ changes that do not require familiarity with a specific subsystem?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
marsonya
marsonya approved these changes Jun 1, 2022
View reviewed changes
lpinca
lpinca approved these changes Jun 1, 2022
View reviewed changes
aduh95
aduh95 approved these changes Jun 1, 2022
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 1, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 0ef81d1 into nodejs:master Jun 1, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator

Landed in 0ef81d1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jun 2, 2022
src: fix memory leaks and refactor ByteSource #43202
Merged
Create GitHub team for reviewing src (C++) changes nodejs/TSC#1237
Closed
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@tniessen @danielleadams
doc: add src/crypto to CC list for nodejs/crypto
5119a27 
PR-URL: #43286
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
v18.4.0 proposal #43385
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@tniessen @danielleadams
doc: add src/crypto to CC list for nodejs/crypto
5a3a2a1 
PR-URL: #43286
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@tniessen @targos
doc: add src/crypto to CC list for nodejs/crypto
72e80ad 
PR-URL: #43286
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tniessen @targos
doc: add src/crypto to CC list for nodejs/crypto
b34fce7 
PR-URL: #43286
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
v16.17.0 release proposal #44098
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tniessen @guangwong
doc: add src/crypto to CC list for nodejs/crypto
42a07f4 
PR-URL: nodejs/node#43286
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@aduh95 aduh95 aduh95 approved these changes
@marsonya marsonya marsonya approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@tniessen @nodejs-github-bot @lpinca @richardlau @aduh95 @marsonya
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.