GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update CHANGELOG_V18.md by panva · Pull Request #43298 · nodejs/node

Conversation

@panva

@panva panva commented Jun 2, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

v18.3.0 release did not update the CHANGELOG_V18.md table. This makes the GitHub Action
linters workflow lint-js-and-md job fail due to 18.3.0 being an unrecognized version.

https://github.com/nodejs/node/actions/workflows/linters.yml

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@panva
doc: update CHANGELOG_V18.md
471a24f
@panva panva added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jun 2, 2022
@nodejs-github-bot nodejs-github-bot added the release Issues and PRs related to Node.js releases. label Jun 2, 2022
@panva panva added doc Issues and PRs related to Node.js documentation. and removed release Issues and PRs related to Node.js releases. labels Jun 2, 2022
@github-actions

github-actions Bot commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.
aduh95, targos, and bricss reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Jun 2, 2022
View reviewed changes
targos
targos approved these changes Jun 2, 2022
View reviewed changes
tniessen
tniessen approved these changes Jun 2, 2022
View reviewed changes
@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 2, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 5ce141c into nodejs:master Jun 2, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 2, 2022

Copy link
Copy Markdown
Collaborator

Landed in 5ce141c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva
panva deleted the fix-18-changelog branch June 2, 2022 12:43
@tniessen tniessen mentioned this pull request Jun 5, 2022
doc: remove ETW tool from tier list #43295
Merged
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@panva @danielleadams
doc: update CHANGELOG_V18.md
4d682bf 
PR-URL: #43298
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
v18.4.0 proposal #43385
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@panva @danielleadams
doc: update CHANGELOG_V18.md
ee392c5 
PR-URL: #43298
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos added dont-land-on-v14.x labels Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@panva @nodejs-github-bot @targos @tniessen @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.