GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add F3n67u to triagers by F3n67u · Pull Request #43350 · nodejs/node

Conversation

@F3n67u

@F3n67u F3n67u commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

I volunteer to become a triager of Node.js project.

My motivation is to support our users more and make more contributions to the node community.

I have read, understand, and will adhere to the Node.js project's Code Of Conduct.

Link to PR I made: https://github.com/nodejs/node/pulls/F3n67u

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
leizongmin and gireeshpunathil reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Jun 8, 2022
@F3n67u
F3n67u force-pushed the apply-for-a-triager branch from b905aee to 1fecdfd Compare June 8, 2022 15:39
@F3n67u
doc: add F3n67u to triagers
58911e5
@F3n67u
F3n67u force-pushed the apply-for-a-triager branch from 1fecdfd to 58911e5 Compare June 8, 2022 15:39
Ayase-252
Ayase-252 approved these changes Jun 8, 2022
View reviewed changes

@Ayase-252 Ayase-252 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
F3n67u reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Trott
Trott approved these changes Jun 8, 2022
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Jun 8, 2022
View reviewed changes
marsonya
marsonya approved these changes Jun 8, 2022
View reviewed changes
LiviaMedeiros
LiviaMedeiros approved these changes Jun 8, 2022
View reviewed changes
@LiviaMedeiros LiviaMedeiros added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jun 8, 2022
RaisinTen
RaisinTen approved these changes Jun 9, 2022
View reviewed changes

@RaisinTen RaisinTen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
F3n67u reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@RaisinTen

RaisinTen commented Jun 9, 2022

Copy link
Copy Markdown
Member

cc @nodejs/issue-triage
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
meixg
meixg approved these changes Jun 9, 2022
View reviewed changes
VoltrexKeyva
VoltrexKeyva approved these changes Jun 9, 2022
View reviewed changes

@VoltrexKeyva VoltrexKeyva left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
F3n67u reacted with heart emoji
All reactions
  • ❤️ 1 reaction
aduh95
aduh95 approved these changes Jun 9, 2022
View reviewed changes
@F3n67u

F3n67u commented Jun 11, 2022

Copy link
Copy Markdown
Contributor Author

Hi all! Is this pr ready to land? Is there anything else I need to do?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 11, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 11, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 11, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/43350
✔  Done loading data for nodejs/node/pull/43350
----------------------------------- PR info ------------------------------------
Title      doc: add F3n67u to triagers (#43350)
Author     Feng Yu  (@F3n67u)
Branch     F3n67u:apply-for-a-triager -> nodejs:master
Labels     doc, author ready
Commits    1
 - doc: add F3n67u to triagers
Committers 1
 - Feng Yu 
PR-URL: https://github.com/nodejs/node/pull/43350
Reviewed-By: Qingyu Deng 
Reviewed-By: Rich Trott 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Akhil Marsonya 
Reviewed-By: LiviaMedeiros 
Reviewed-By: Darshan Sen 
Reviewed-By: Xuguang Mei 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43350
Reviewed-By: Qingyu Deng 
Reviewed-By: Rich Trott 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Akhil Marsonya 
Reviewed-By: LiviaMedeiros 
Reviewed-By: Darshan Sen 
Reviewed-By: Xuguang Mei 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 08 Jun 2022 15:38:13 GMT
   ✔  Approvals: 9
   ✔  - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000001553
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000153860
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000170079
   ✔  - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000247159
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000315148
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000694678
   ✔  - Xuguang Mei (@meixg): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000696837
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000702516
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43350#pullrequestreview-1001044269
   ✖  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2480312874
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 440d95a into nodejs:master Jun 11, 2022
@aduh95

aduh95 commented Jun 11, 2022

Copy link
Copy Markdown
Contributor

Landed in 440d95a. Thanks for volunteering, I've also added you to @nodejs/issue-triage.
VoltrexKeyva reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@F3n67u
F3n67u deleted the apply-for-a-triager branch June 11, 2022 14:58
@F3n67u

F3n67u commented Jun 11, 2022

Copy link
Copy Markdown
Contributor Author

@aduh95 Invitation accepted! Thank you all! Really excited to be part of the Node.js triage team.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams danielleadams mentioned this pull request Jun 13, 2022
v18.4.0 proposal #43385
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@F3n67u @danielleadams
doc: add F3n67u to triagers
adec5fa 
PR-URL: #43350
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@F3n67u @targos
doc: add F3n67u to triagers
7034178 
PR-URL: #43350
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@F3n67u @targos
doc: add F3n67u to triagers
e444279 
PR-URL: #43350
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
v16.17.0 release proposal #44098
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@F3n67u @guangwong
doc: add F3n67u to triagers
6157d35 
PR-URL: nodejs/node#43350
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@Ayase-252 Ayase-252 Ayase-252 approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@meixg meixg meixg approved these changes
@aduh95 aduh95 aduh95 approved these changes
@marsonya marsonya marsonya approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@F3n67u @RaisinTen @nodejs-github-bot @aduh95 @Trott @Ayase-252 @gireeshpunathil @meixg @marsonya @VoltrexKeyva @LiviaMedeiros
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.