GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix typo in globals.md by daeyeon · Pull Request #43365 · nodejs/node

Conversation

@daeyeon

@daeyeon daeyeon commented Jun 10, 2022

Copy link
Copy Markdown
Member

Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@daeyeon
doc: fix typo in globals.md
39dc0dc
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Jun 10, 2022
cjihrig
cjihrig approved these changes Jun 10, 2022
View reviewed changes
RaisinTen
RaisinTen approved these changes Jun 10, 2022
View reviewed changes
marsonya
marsonya approved these changes Jun 10, 2022
View reviewed changes
@marsonya marsonya added fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Jun 10, 2022
@github-actions

github-actions Bot commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @marsonya. Please 👍 to approve.

marsonya, RaisinTen, VoltrexKeyva, and lpinca reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

VoltrexKeyva
VoltrexKeyva approved these changes Jun 10, 2022
View reviewed changes
lpinca
lpinca approved these changes Jun 10, 2022
View reviewed changes
@marsonya marsonya added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 10, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 10, 2022
@nodejs-github-bot
nodejs-github-bot merged commit cb7e854 into nodejs:master Jun 10, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator

Landed in cb7e854

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@daeyeon
daeyeon deleted the master.doc-220610.Fri.04ec branch June 10, 2022 10:48
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@daeyeon @danielleadams
doc: fix typo in globals.md
aa163f1
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43365
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
v18.4.0 proposal #43385
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@daeyeon @danielleadams
doc: fix typo in globals.md
cc3505b
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43365
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@daeyeon @targos
doc: fix typo in globals.md
1bf2521
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43365
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@daeyeon @targos
doc: fix typo in globals.md
fb15661
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: #43365
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
v16.17.0 release proposal #44098
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@daeyeon @guangwong
doc: fix typo in globals.md
6bc8bce
Use apostrophe for possessive.

Signed-off-by: Daeyeon Jeong [email protected]

PR-URL: nodejs/node#43365
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@marsonya marsonya marsonya approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@daeyeon @nodejs-github-bot @lpinca @cjihrig @marsonya @RaisinTen @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.