GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: fix find-inactive actions by LiviaMedeiros · Pull Request #43377 · nodejs/node

Conversation

@LiviaMedeiros

@LiviaMedeiros LiviaMedeiros commented Jun 11, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@LiviaMedeiros
tools: fix find-inactive actions
b1abdfe
@nodejs-github-bot

nodejs-github-bot commented Jun 11, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 11, 2022
@LiviaMedeiros LiviaMedeiros added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jun 11, 2022
@github-actions

github-actions Bot commented Jun 11, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve.
Trott and aduh95 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Jun 11, 2022
View reviewed changes
@aduh95

aduh95 commented Jun 11, 2022

Copy link
Copy Markdown
Contributor

We also probably want to revert using a hash instead of v1 as it looks like that doesn't work for some reason: https://github.com/nodejs/node/runs/6842110279?check_suite_focus=true
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@LiviaMedeiros

LiviaMedeiros commented Jun 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Thanks for checking that! I think we should use gr2m/create-or-update-pull-request-action@6720400 instead.
https://github.com/gr2m/create-or-update-pull-request-action/blob/6720400cad8e74d7adc64640e4e6ea6748b83d8f/dist/index.js
There's no /dist/ in their master branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
LiviaMedeiros added 2 commits June 11, 2022 16:59
@LiviaMedeiros
squash: update commit in find-inactive-tsc.yml
8cb84f4
@LiviaMedeiros
squash: update commit in find-inactive-collaborators.yml
4da1a7d
@aduh95

aduh95 commented Jun 11, 2022

Copy link
Copy Markdown
Contributor

I just tried this PR over at https://github.com/nodejs/node-auto-test/runs/6842347772?check_suite_focus=true, and it opened nodejs/node-auto-test#48 just fine 👍
LiviaMedeiros reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Jun 11, 2022
View reviewed changes
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Jun 11, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 11, 2022
@nodejs-github-bot
nodejs-github-bot merged commit e227e52 into nodejs:master Jun 11, 2022
@nodejs-github-bot

nodejs-github-bot commented Jun 11, 2022

Copy link
Copy Markdown
Collaborator

Landed in e227e52
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jun 11, 2022
chore: fix Version Sync action nodejs/corepack#119
Merged
tools: fix create-or-update-pull-request-action hash on GHA #43378
Merged
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@LiviaMedeiros @danielleadams
tools: fix find-inactive actions
495aaa9 
PR-URL: #43377
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
v18.4.0 proposal #43385
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@LiviaMedeiros @danielleadams
tools: fix find-inactive actions
8c0fe1e 
PR-URL: #43377
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@LiviaMedeiros @targos
tools: fix find-inactive actions
ec419e5 
PR-URL: #43377
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@LiviaMedeiros @targos
tools: fix find-inactive actions
ddea965 
PR-URL: #43377
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
v16.17.0 release proposal #44098
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@LiviaMedeiros @guangwong
tools: fix find-inactive actions
4bc23ea 
PR-URL: nodejs/node#43377
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@LiviaMedeiros @nodejs-github-bot @aduh95 @Trott
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.