GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add filesystem check to `test-fs-stat-date.mjs` by LiviaMedeiros · Pull Request #44174 · nodejs/node

Conversation

@LiviaMedeiros

@LiviaMedeiros LiviaMedeiros commented Aug 8, 2022

Copy link
Copy Markdown
Member

main-based alternative to: #44129

Skip the test if filesystem doesn't provide correct atime or mtime value from fs.stat().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow and bricss reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@LiviaMedeiros
test: add filesystem check to test-fs-stat-date.mjs
28694dc
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 8, 2022
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 8, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 8, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos targos mentioned this pull request Aug 8, 2022
[v16.x backport] fs: use signed types for stat data #44129
Closed
@aduh95
aduh95 requested a review from richardlau August 8, 2022 15:01
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 8, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 8, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
richardlau
richardlau approved these changes Aug 8, 2022
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot mentioned this pull request Aug 9, 2022
CI Reliability 2022-08-09 nodejs/reliability#341
Open
8 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 9, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45949/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@LiviaMedeiros LiviaMedeiros added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Aug 9, 2022
@github-actions

github-actions Bot commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@LiviaMedeiros

LiviaMedeiros commented Aug 9, 2022

Copy link
Copy Markdown
Member Author

Marking as fast-track PRs proposed for a shorter-than-standard waiting period before landing. in case if we need this in v16.17.0 before deadlines.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Aug 10, 2022
CI Reliability 2022-08-10 nodejs/reliability#342
Open
CI Reliability 2022-08-11 nodejs/reliability#343
Open
CI Reliability 2022-08-12 nodejs/reliability#344
Open
CI Reliability 2022-08-13 nodejs/reliability#345
Open
CI Reliability 2022-08-14 nodejs/reliability#346
Open
aduh95
aduh95 approved these changes Aug 14, 2022
View reviewed changes
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. and removed fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Aug 14, 2022
@targos targos mentioned this pull request Aug 14, 2022
fs: use signed types for stat data #43714
Merged
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 14, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 86276d3 into nodejs:main Aug 14, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 14, 2022

Copy link
Copy Markdown
Collaborator

Landed in 86276d3

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Aug 15, 2022
CI Reliability 2022-08-15 nodejs/reliability#347
Open
CI Reliability 2022-08-16 nodejs/reliability#348
Open
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@LiviaMedeiros @danielleadams
test: add filesystem check to test-fs-stat-date.mjs
64300a6
PR-URL: #44174
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 16, 2022
v18.8.0 release proposal #44246
Closed
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@LiviaMedeiros @ruyadorno
test: add filesystem check to test-fs-stat-date.mjs
e373144
PR-URL: #44174
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
v18.8.0 release proposal #44353
Merged
targos pushed a commit that referenced this pull request Sep 5, 2022
@LiviaMedeiros @targos
test: add filesystem check to test-fs-stat-date.mjs
ab6a1a7
PR-URL: #44174
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos

targos commented Sep 16, 2022

Copy link
Copy Markdown
Member

@LiviaMedeiros I cherry-picked #43714 and this commit to v16.x-staging but it doesn't seem to work as expected.
See #44542 (comment)
https://ci.nodejs.org/job/node-test-binary-arm-12+/15525/RUN_SUBSET=1,label=pi2-docker/testReport/junit/(root)/test/parallel_test_fs_stat_date/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@LiviaMedeiros

LiviaMedeiros commented Sep 18, 2022

Copy link
Copy Markdown
Member Author

According to #44129 (comment), this test platform uses NFS mounts.
According to RFC 1813, Page 21, NFSv3 uses unsigned types for timestamps:

      struct nfstime3 {
         uint32   seconds;
         uint32   nseconds;
      };

While NFSv4 (RFC 7530, Page 21) uses signed:

   struct nfstime4 {
           int64_t         seconds;
           uint32_t        nseconds;
   };

This is my best guess on why could this happen.

Opened #44707 against main, let me know if backport PR would be more convenient.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau richardlau mentioned this pull request Oct 7, 2022
V16.18.0 proposal #44886
Merged
@juanarbol

juanarbol commented Oct 11, 2022

Copy link
Copy Markdown
Member

@LiviaMedeiros I cherry-picked #43714 and this commit to v16.x-staging but it doesn't seem to work as expected. See #44542 (comment) https://ci.nodejs.org/job/node-test-binary-arm-12+/15525/RUN_SUBSET=1,label=pi2-docker/testReport/junit/(root)/test/parallel_test_fs_stat_date/

This is causing the CI to fail in the v16.x release branch. I will label this as dont-land-on-v16.x; feel free to remove it if needed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@juanarbol juanarbol added the dont-land-on-v16.x label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@LiviaMedeiros @nodejs-github-bot @targos @juanarbol @richardlau @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.