GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: loosen test for negative timestamps in `test-fs-stat-date` by LiviaMedeiros · Pull Request #44707 · nodejs/node

Conversation

@LiviaMedeiros

@LiviaMedeiros LiviaMedeiros commented Sep 18, 2022

Copy link
Copy Markdown
Member

One more attempt to make test from #43714 pass on v16.x-staging and avoid similar test failures on main in the future.

If filesystem doesn't support negative timestamps and stat returns 0, print a warning and proceed.

cc @targos

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@LiviaMedeiros
test: loosen test for negative timestamps in test-fs-stat-date
8fee56c
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 18, 2022
@LiviaMedeiros LiviaMedeiros mentioned this pull request Sep 18, 2022
test: add filesystem check to test-fs-stat-date.mjs #44174
Merged
@LiviaMedeiros LiviaMedeiros added fs Issues and PRs related to file-system APIs and the fs module. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 18, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 18, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Sep 19, 2022
CI Reliability 2022-09-19 nodejs/reliability#383
Open
CI Reliability 2022-09-20 nodejs/reliability#384
Open
@nodejs-github-bot

nodejs-github-bot commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46665/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Sep 27, 2022

Copy link
Copy Markdown
Member

@nodejs/testing @nodejs/fs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Oct 2, 2022
View reviewed changes
@richardlau richardlau mentioned this pull request Oct 7, 2022
V16.18.0 proposal #44886
Merged
richardlau
richardlau approved these changes Oct 7, 2022
View reviewed changes
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 7, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 7, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 8f8ce25 into nodejs:main Oct 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 7, 2022

Copy link
Copy Markdown
Collaborator

Landed in 8f8ce25
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
juanarbol pushed a commit that referenced this pull request Oct 8, 2022
@LiviaMedeiros @juanarbol
test: loosen test for negative timestamps in test-fs-stat-date
02cd9a9 
PR-URL: #44707
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@LiviaMedeiros @danielleadams
test: loosen test for negative timestamps in test-fs-stat-date
fe91beb 
PR-URL: #44707
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
v18.11.0 proposal #44968
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@LiviaMedeiros @nodejs-github-bot @Trott @jasnell @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.