GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: fix typo in `tools/update-authors.mjs` by RaisinTen · Pull Request #44780 · nodejs/node

Conversation

@RaisinTen

@RaisinTen RaisinTen commented Sep 25, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The filename ends with an s.

Signed-off-by: Darshan Sen [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 25, 2022
lpinca
lpinca approved these changes Sep 25, 2022
View reviewed changes
MoLow
MoLow approved these changes Sep 25, 2022
View reviewed changes
daeyeon
daeyeon approved these changes Sep 25, 2022
View reviewed changes
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 25, 2022
@targos

targos commented Sep 25, 2022

Copy link
Copy Markdown
Member

There's a typo in the commit message. "ends" should end with an s 😄
RaisinTen reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen
RaisinTen force-pushed the tools/fix-typo-in-tools/update-authors.mjs branch from 7a02a9d to f0689ac Compare September 25, 2022 10:27
@RaisinTen

RaisinTen commented Sep 25, 2022

Copy link
Copy Markdown
Member Author

@targos haha, thanks for catching, fixed!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
watilde
watilde approved these changes Sep 25, 2022
View reviewed changes
Trott
Trott approved these changes Sep 25, 2022
View reviewed changes
cjihrig
cjihrig approved these changes Sep 25, 2022
View reviewed changes
marsonya
marsonya approved these changes Sep 26, 2022
View reviewed changes
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 27, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/44780
✔  Done loading data for nodejs/node/pull/44780
----------------------------------- PR info ------------------------------------
Title      tools: fix typo in `tools/update-authors.mjs` (#44780)
Author     Darshan Sen  (@RaisinTen)
Branch     RaisinTen:tools/fix-typo-in-tools/update-authors.mjs -> nodejs:main
Labels     tools, author ready
Commits    1
 - tools: fix typo in tools/update-authors.mjs
Committers 1
 - Darshan Sen 
PR-URL: https://github.com/nodejs/node/pull/44780
Reviewed-By: Luigi Pinca 
Reviewed-By: Moshe Atlow 
Reviewed-By: Daeyeon Jeong 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Akhil Marsonya 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44780
Reviewed-By: Luigi Pinca 
Reviewed-By: Moshe Atlow 
Reviewed-By: Daeyeon Jeong 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Akhil Marsonya 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 25 Sep 2022 05:10:57 GMT
   ✔  Approvals: 7
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44780#pullrequestreview-1119372607
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/44780#pullrequestreview-1119372708
   ✔  - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/44780#pullrequestreview-1119373811
   ✔  - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/44780#pullrequestreview-1119396414
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44780#pullrequestreview-1119432546
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/44780#pullrequestreview-1119432783
   ✔  - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/44780#pullrequestreview-1119842989
   ✖  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3137317680
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen
tools: fix typo in tools/update-authors.mjs
4bb34aa 
The filename ends with an s.

Signed-off-by: Darshan Sen <[email protected]>
@RaisinTen
RaisinTen force-pushed the tools/fix-typo-in-tools/update-authors.mjs branch from f0689ac to 4bb34aa Compare September 29, 2022 08:54
@RaisinTen

RaisinTen commented Sep 29, 2022

Copy link
Copy Markdown
Member Author

Yusss, CI is finally green! Can some please re-approve so that I can land this with the commit-queue label? Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes Sep 29, 2022
View reviewed changes
@RaisinTen RaisinTen added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 30, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 2a4452a into nodejs:main Sep 30, 2022
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2022

Copy link
Copy Markdown
Collaborator

Landed in 2a4452a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen
RaisinTen deleted the tools/fix-typo-in-tools/update-authors.mjs branch September 30, 2022 05:50
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@RaisinTen @danielleadams
tools: fix typo in tools/update-authors.mjs
131adec 
The filename ends with an s.

Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #44780
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
v18.11.0 proposal #44968
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@watilde watilde watilde approved these changes
@cjihrig cjihrig cjihrig approved these changes
@daeyeon daeyeon daeyeon approved these changes
@MoLow MoLow MoLow approved these changes
@marsonya marsonya marsonya approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@RaisinTen @targos @nodejs-github-bot @Trott @lpinca @watilde @cjihrig @daeyeon @MoLow @marsonya
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.