GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — v18.11.0 proposal by danielleadams · Pull Request #44968 · nodejs/node

Conversation

danielleadams commented Oct 11, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

2022-10-13, Version 18.11.0 (Current), @danielleadams

watch mode (experimental)

Running in 'watch' mode using node --watch restarts the process when an imported file is changed.

Contributed by Moshe Atlow in #44366

Other notable changes

fs:
- (SEMVER-MINOR) add FileHandle.prototype.readLines (Antoine du Hamel) #42590
http:
- (SEMVER-MINOR) add writeEarlyHints function to ServerResponse (Wing) #44180
http2:
- (SEMVER-MINOR) make early hints generic (Yagiz Nizipli) #44820
lib:
- (SEMVER-MINOR) refactor transferable AbortSignal (flakey5) #44048
src:
- (SEMVER-MINOR) add detailed embedder process initialization API (Anna Henningsen) #44121
util:
- (SEMVER-MINOR) add default value option to parsearg (Manuel Spigolon) #44631

Commits

[27b4b782ce] - benchmark: add vm context global proxy benchmark (Joyee Cheung) #44796
[4e82521af1] - bootstrap: update comments in bootstrap/node.js (Joyee Cheung) #44726
[725be0ea50] - buffer: initialize TextDecoder once on blob.text() (Yagiz Nizipli) #44787
[653c3b1f62] - buffer,lib: update atob to align wpt's base64.json (Khaidi Chu) #43901
[37808b3355] - build: convert V8 test JSON to JUnit XML (Keyhan Vakil) #44049
[f92871a52b] - build: update timezone-update.yml (Alex) #44717
[f85d3471ee] - child_process: remove lookup of undefined property (Colin Ihrig) #44766
[2f5f41c315] - (SEMVER-MINOR) cli: add --watch (Moshe Atlow) #44366
[7fb9cc70f3] - cluster: use inspector utils (Moshe Atlow) #44592
[99a2c16040] - crypto: add causes to applicable webcrypto's OperationError (Filip Skokan) #44890
[e0fbba0939] - crypto: use EVP_PKEY_CTX_set_dsa_paramgen_q_bits when available (David Benjamin) #44561
[a90386b0a1] - deps: update undici to 5.11.0 (Node.js GitHub Bot) #44929
[aa68d40fbf] - deps: update corepack to 0.14.2 (Node.js GitHub Bot) #44775
[c892f35815] - deps: V8: fix debug build (Ben Noordhuis) #44392
[91514393dc] - dns: support dns module in the snapshot (Joyee Cheung) #44633
[ce3cb29319] - doc: add fsPromises.readFile() example (Tierney Cyren) #40237
[97df9b84a2] - doc: improve building doc for Android (BuShe Pie) #44888
[8c69da893b] - doc: mention corepack prepare supports tag or range (Michael Rienstra) #44646
[842bc64833] - doc: remove Legacy status from querystring (Rich Trott) #44912
[ddb5402f5f] - doc: fix label name in collaborator guide (Rich Trott) #44920
[d08b024a3d] - doc: fix typo in Node.js 12 changelog (Lorand Horvath) #42880
[b6b9c427c5] - doc: move release keys we don't use anymore in README (Rich Trott) #44899
[e92b074b32] - doc: fix grammar in dns docs (doc: grammar fix in dns docs #44850) (Colin Ihrig) #44850
[780144c339] - doc: remove unnecessary leading commas (Colin Ihrig) #44854
[6ae9bc8fbc] - doc: add extra step for reporter pre-approval (Rafael Gonzaga) #44806
[ccf31d8bca] - doc: add anchor link for --preserve-symlinks (Kohei Ueno) #44858
[7c5c19ee54] - doc: update node prefix require.cache example (Simone Busoli) #44724
[2a5bce6318] - doc: include last security release date (Vladimir de Turckheim) #44794
[4efaf4265c] - doc: remove "currently" and comma splice from child_process.md (Rich Trott) #44789
[3627616b40] - doc,crypto: mark experimental algorithms more visually (Filip Skokan) #44892
[3c653cf23a] - doc,crypto: add missing CFRG curve algorithms to supported lists (Filip Skokan) #44876
[70f55020d3] - doc,crypto: add null length to crypto.subtle.deriveBits (Filip Skokan) #44876
[910fbd0ece] - esm: fix duplicated test (Geoffrey Booth) #44779
[bc00f3bde1] - fs: fix opts.filter issue in cp async (Tho) #44922
[11d1c23fa0] - (SEMVER-MINOR) fs: add FileHandle.prototype.readLines (Antoine du Hamel) #42590
[67fb76519a] - fs: improve promise based readFile performance for big files (Ruben Bridgewater) #44295
[dc6379bdc2] - fs: don't hard code name in validatePosition() (Colin Ihrig) #44767
[eb19b1e97c] - http: be more aggressive to reply 400, 408 and 431 (ywave620) #44818
[4c869c8d9e] - (SEMVER-MINOR) http: add writeEarlyHints function to ServerResponse (Wing) #44180
[9c7e66478c] - (SEMVER-MINOR) http2: make early hints generic (Yagiz Nizipli) #44820
[3f20e5b15c] - (SEMVER-MINOR) lib: refactor transferable AbortSignal (flakey5) #44048
[ada7d82b16] - lib: require JSDoc in internal validators code (Rich Trott) #44896
[67eaa303af] - lib: add cause to DOMException (flakey5) #44703
[0db86ee98e] - meta: update AUTHORS (Node.js GitHub Bot) #44930
[2efe4d985b] - meta: label test.js and test.md with test_runner label (Moshe Atlow) #44863
[fd9feb3a6c] - meta: update AUTHORS (Node.js GitHub Bot) #44857
[a854bb39c9] - node-api: create reference only when needed (Gerhard Stöbich) #44827
[fd5c26b8db] - path: change basename() argument from ext to suffix (Rich Trott) #44774
[803fbfb168] - process: fix uid/gid validation to avoid crash (Tobias Nießen) #44910
[9f2dd48fc3] - src: remove uid_t/gid_t casts (Tobias Nießen) #44914
[3abb607f3a] - src: remove UncheckedMalloc(0) workaround (Tobias Nießen) #44543
[0606f9298f] - src: deduplicate setting RSA OAEP label (Tobias Nießen) #44849
[daf3152f7e] - src: implement GetDetachedness() in MemoryRetainerNode (Joyee Cheung) #44803
[7ca77dd4ef] - src: avoid X509_free in loops in crypto_x509.cc (Tobias Nießen) #44855
[781ad96227] - src: use OnScopeLeave instead of multiple free() (Tobias Nießen) #44852
[b27b336a7a] - src: remove ParseIP() in cares_wrap.cc (Tobias Nießen) #44771
[f99f5d3c01] - (SEMVER-MINOR) src: add detailed embedder process initialization API (Anna Henningsen) #44121
[281fd7a09a] - src,stream: improve DoWrite() and Write() (ywave620) #44434
[a33cc22bf7] - src,worker: fix race of WorkerHeapSnapshotTaker (ywave620) #44745
[f300f197da] - stream: handle enqueuing chunks when a pending BYOB pull request exists (Daeyeon Jeong) #44770
[9ac029ea11] - test: bump memory limit for abort fatal error (Danielle Adams) #44984
[b9b671f25f] - test: debug watch mode inspect (Moshe Atlow) #44861
[2308b71d09] - test: don't clobber RegExp.$_ on startup (Ben Noordhuis) #44864
[fe91bebb67] - test: loosen test for negative timestamps in test-fs-stat-date (Livia Medeiros) #44707
[a080608552] - test: check --test is disallowed in NODE_OPTIONS (Kohei Ueno) #44846
[dc2af265d7] - test: improve lib/internal/source_map/source_map.js coverage (MURAKAMI Masahiko) #42771
[60a05d6dea] - test: skip some binding tests on IBMi PASE (Richard Lau) #44810
[8dacedaa3d] - test: remove unused variable in addon test (Joyee Cheung) #44809
[c54cee1c3f] - test: check server status in test-tls-psk-client (Richard Lau) #44824
[ee3c6a4dc5] - test: use async/await in test-debugger-exceptions (pete3249) #44690
[9f14625fe5] - test: use async/await in test-debugger-help (Chandana) #44686
[8033ad846b] - test: update test-debugger-scripts to use await/async (mmeenapriya) #44692
[f4f08be384] - test: use await in test-debugger-invalid-json (Anjana Krishnakumar Vellore) #44689
[d2f36169f3] - test: use async/await in test-debugger-random-port-with-inspect-port (Monu-Chaudhary) #44695
[ddf029725b] - test: use async/await in test-debugger-heap-profiler (Brinda Ashar) #44693
[117f068250] - test: use async/await in test-debugger-auto-resume (samyuktaprabhu) #44675
[143c428cae] - test: migrated from Promise chains to Async/Await (Rathi N Das) #44674
[e609a3309c] - test: change promises to async/await in test-debugger-backtrace.js (Juliet Zhang) #44677
[eeabd23ca6] - test: use async/await in test-debugger-sb-before-load (Hope Olaidé) #44697
[5c63d1464e] - test: add extra tests for basename with ext option (Connor Burton) #44772
[f8b2d7a059] - test: refactor to async/await (Divya Mohan) #44694
[9864bde9ab] - test: modify test-debugger-custom-port.js to use async-await (Priya Shastri) #44680
[af30823881] - test: upgrade all 1024 bit RSA keys to 2048 bits (Momtchil Momtchev) #44498
[0fb669e31f] - test: update test-debugger-breakpoint-exists.js to use async/await (Archana Kamath) #44682
[cca253503e] - test: use async/await in test-debugger-preserve-breaks (poorvitusam) #44696
[0b2e8b1681] - test: use async/await in test-debugger-profile (surbhirjain) #44684
[4db72a65cf] - test: change the promises to async/await in test-debugger-exec-scope.js (Ankita Khiratkar) #44685
[56c9c98963] - test: fix test-runner-inspect (Moshe Atlow) #44620
[36227ed862] - test: fix watch mode test flake (Moshe Atlow) #44739
[3abd71a0ea] - test: deflake watch mode tests (Moshe Atlow) #44621
[0c9f38f2be] - test: split watch mode inspector tests to sequential (Moshe Atlow) #44551
[d762a34128] - test_runner: add --test-name-pattern CLI flag (Colin Ihrig)
[c7ece464a1] - test_runner: remove runtime experimental warning (Colin Ihrig) #44844
[3c1e9d41c8] - test_runner: support using --inspect with --test (Moshe Atlow) #44520
[4bdef48732] - tools: remove faulty early termination logic from update-timezone.mjs (Darshan Sen) #44870
[19d8574996] - tools: fix timezone update tool (Darshan Sen) #44870
[ad8b8ae7d3] - tools: update eslint to 8.25.0 (Node.js GitHub Bot) #44931
[fd99b17a4d] - tools: make utils.SearchFiles deterministic (Bruno Pitrus) #44496
[131adece37] - tools: fix typo in tools/update-authors.mjs (Darshan Sen) #44780
[ab22777e65] - tools: refactor deprecated format in no-unescaped-regexp-dot (Madhuri) #44763
[3ad0fae89d] - tools: update eslint-check.js to object style (andiemontoyeah) #44706
[e9d572a9bd] - tools: update eslint to 8.24.0 (Node.js GitHub Bot) #44778
[984b0b4a6c] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #44776
[db5aeed702] - (SEMVER-MINOR) util: add default value option to parsearg (Manuel Spigolon) #44631
[576ccdf125] - util: increase robustness with primordials (Jordan Harband) #41212

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

bricss reacted with hooray emoji

bricss, daliborgogic, and j0hn-42 reacted with heart emoji

bricss, ywave620, and j0hn-42 reacted with rocket emoji

All reactions

👍 1 reaction
🎉 1 reaction
❤️ 3 reactions
🚀 3 reactions

MoLow and others added 30 commits

October 2, 2022 11:09


          cli: add --watch

2f5f41c

PR-URL: #44366
Backport-PR-URL: #44815
Fixes: #40429
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>


          test: split watch mode inspector tests to sequential

0c9f38f

PR-URL: #44551
Backport-PR-URL: #44815
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>


          test: deflake watch mode tests

3abd71a

PR-URL: #44621
Backport-PR-URL: #44815
Fixes: #44655
Reviewed-By: Benjamin Gruenbaum <[email protected]>


          test: fix watch mode test flake

36227ed

PR-URL: #44739
Backport-PR-URL: #44815
Fixes: #44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>


          test_runner: support using --inspect with --test

3c1e9d4

PR-URL: #44520
Backport-PR-URL: #44813
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>


          cluster: use inspector utils

7fb9cc7

PR-URL: #44592
Backport-PR-URL: #44813
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>


          test: fix test-runner-inspect

56c9c98

PR-URL: #44620
Backport-PR-URL: #44813
Fixes: #44600
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>


          src: add detailed embedder process initialization API

f99f5d3

So far, process initialization has been a bit all over the place
in Node.js. `InitializeNodeWithArgs()` is our main public API
for this, but inclusion of items in it vs. `InitializeOncePerProcess()`
and `PlatformInit()` has been random at best. Likewise,
some pieces of initialization have been guarded by
`NODE_SHARED_MODE`, but also fairly randomly and without
any meaningful connection to shared library usage.

This leaves embedders in a position to cherry-pick some of
the initialization code into their own code to make their
application behave like typical Node.js applications to the
degree to which they desire it.

Electron takes an alternative route and makes direct use of
`InitializeOncePerProcess()` already while it is a private
API, with a `TODO` to add it to the public API in Node.js.

This commit addresses that `TODO`, and `TODO`s around the
`NODE_SHARED_MODE` usage. Specifically:

- `InitializeOncePerProcess()` and `TearDownOncePerProcess()`
  are added to the public API.
- The `flags` option of these functions are merged with the
  `flags` option for `InitializeNodeWithArgs()`, since they
  essentially share the same semantics.
- The return value of the function is made an abstract class,
  rather than a struct, for easier API/ABI stability.
- Initialization code from `main()` is brought into these
  functions (since that makes sense in general).
- Add a `TODO` for turning `InitializeNodeWithArgs()` into
  a small wrapper around `InitializeOncePerProcess()` and
  eventually removing it (at least one major release cycle
  each, presumably).
- Remove `NODE_SHARED_MODE` guards and replace them with
  runtime options.

PR-URL: #44121
Backport-PR-URL: #44358
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>


          util: increase robustness with primordials

576ccdf

(backported from #41212)

Backport-PR-URL: #44797
PR-URL: #41212
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>


          deps: V8: fix debug build

c892f35

This is a (very) partial cherry-pick of upstream change v8/v8@f8fddd6b13
that fixes the following debug mode build error with clang:

    ../deps/v8/src/codegen/register.h:29:48: error: member reference
    base type 'RegListBase' is not a structure or union
      int num_different_regs = RegListBase{regs...}.Count();

Fixes: #44371
PR-URL: #44392
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>


          tools: update lint-md-dependencies to [email protected]

984b0b4

PR-URL: #44776
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>


          tools: update eslint to 8.24.0

e9d572a

PR-URL: #44778
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>


          path: change basename() argument from ext to suffix

fd5c26b

Closes: #44773
PR-URL: #44774
Fixes: #44773
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>


          tools: update eslint-check.js to object style

3ad0fae

Updated rule from deprecated function-style
format to object-style format.

Refs: https://eslint.org/docs/latest/developer-guide/working-with-rules
PR-URL: #44706
Reviewed-By: Rich Trott <[email protected]>


          test: change the promises to async/await in test-debugger-exec-scope.js

4db72a6

PR-URL: #44685
Reviewed-By: Rich Trott <[email protected]>


          test: use async/await in test-debugger-profile

0b2e8b1

PR-URL: #44684
Reviewed-By: Rich Trott <[email protected]>


          test: use async/await in test-debugger-preserve-breaks

cca2535

PR-URL: #44696
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Rich Trott <[email protected]>


          test: update test-debugger-breakpoint-exists.js to use async/await

0fb669e

PR-URL: #44682
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>


          test: upgrade all 1024 bit RSA keys to 2048 bits

af30823

Ubuntu 22.04 Jammy rejects 1024 bit RSA Keys

PR-URL: #44498
Refs: #44497
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>


          build: update timezone-update.yml

f92871a

Signed-off-by: sashashura <[email protected]>

PR-URL: #44717
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Rich Trott <[email protected]>


          test: modify test-debugger-custom-port.js to use async-await

9864bde

PR-URL: #44680
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>


          doc: remove "currently" and comma splice from child_process.md

4efaf42

Remove redundant use of "currently" and fix a comma splice.

PR-URL: #44789
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>


          tools: refactor deprecated format in no-unescaped-regexp-dot

ab22777

PR-URL: #44763
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          esm: fix duplicated test

910fbd0

PR-URL: #44779
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>


          test: refactor to async/await

f8b2d7a

PR-URL: #44694
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Rich Trott <[email protected]>


          dns: support dns module in the snapshot

For the initial iteration, only the default resolver can be
serialized/deserialized. If `dns.setServers()` has been
called, we'll preserve the configured DNS servers in the snapshot.
We can consider exposing the serialization method if it becomes
necessary for user-land snapshots.

PR-URL: #44633
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>


          bootstrap: update comments in bootstrap/node.js

4e82521

The comments in bootstrap/node.js are now out of date due to
recent changes to the bootstrap process. Update them to reflect
the current status.

PR-URL: #44726
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>


          child_process: remove lookup of undefined property

f85d347

execSync() passes opts.args to checkExecSyncError(). There are
two problems:

1. opts.args appears to always be undefined.
2. Even if it was defined, checkExecSyncError() would not use
   it since the command input is guaranteed to be defined.

This commit updates the code to pass undefined instead.

PR-URL: #44766
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>


          fs: don't hard code name in validatePosition()

dc6379b

The name of the position being validated by validatePosition()
was not being used. Instead, the string 'position' was being
used everywhere. It worked out because the only call sites were
using the name 'position' as well.

PR-URL: #44767
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>


          test: add extra tests for basename with ext option

5c63d14

PR-URL: #44772
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

This comment was marked as outdated.

danielleadams force-pushed the v18.11.0-proposal branch from c8aacb3 to 6d3a9e3 Compare

October 13, 2022 05:39

This comment was marked as outdated.

danielleadams force-pushed the v18.11.0-proposal branch from 6d3a9e3 to 18f0262 Compare

October 13, 2022 05:41

danielleadams added a commit that referenced this pull request

Oct 13, 2022


          2022-10-13, Version 18.11.0 (Current)

18f0262

watch mode (experimental):

Running in 'watch' mode using `node --watch` restarts the process when an
imported file is changed.

Contributed by Moshe Atlow in #44366

Other notable changes:

* fs:
  * (SEMVER-MINOR) add `FileHandle.prototype.readLines` (Antoine du Hamel)
  #42590
* http:
  * (SEMVER-MINOR) add writeEarlyHints function to ServerResponse (Wing)
  #44180
* http2:
  * (SEMVER-MINOR) make early hints generic (Yagiz Nizipli) #44820
* lib:
  * (SEMVER-MINOR) refactor transferable AbortSignal (flakey5) #44048
* src:
  * (SEMVER-MINOR) add detailed embedder process initialization API (Anna
  Henningsen) #44121
* util:
  * (SEMVER-MINOR) add default value option to parsearg (Manuel Spigolon)
  #44631

PR-URL: #44968

This comment was marked as outdated.

richardlau commented Oct 13, 2022

Copy link

Copy Markdown

Member

Some REPLACEME tags have been missed:

node/doc/api/util.md

Line 1603 in 18f0262

added: REPLACEME

node/doc/api/util.md

Line 1614 in 18f0262

added: REPLACEME

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          2022-10-13, Version 18.11.0 (Current)

8c1dd95

watch mode (experimental):

Running in 'watch' mode using `node --watch` restarts the process when an
imported file is changed.

Contributed by Moshe Atlow in #44366

Other notable changes:

* fs:
  * (SEMVER-MINOR) add `FileHandle.prototype.readLines` (Antoine du Hamel)
  #42590
* http:
  * (SEMVER-MINOR) add writeEarlyHints function to ServerResponse (Wing)
  #44180
* http2:
  * (SEMVER-MINOR) make early hints generic (Yagiz Nizipli) #44820
* lib:
  * (SEMVER-MINOR) refactor transferable AbortSignal (flakey5) #44048
* src:
  * (SEMVER-MINOR) add detailed embedder process initialization API (Anna
  Henningsen) #44121
* util:
  * (SEMVER-MINOR) add default value option to parsearg (Manuel Spigolon)
  #44631

PR-URL: #44968

danielleadams force-pushed the v18.11.0-proposal branch from 18f0262 to 8c1dd95 Compare

October 13, 2022 12:11

danielleadams commented Oct 13, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

Some REPLACEME tags have been missed:

node/doc/api/util.md

Line 1603 in 18f0262

added: REPLACEME

node/doc/api/util.md

Line 1614 in 18f0262

added: REPLACEME

@richardlau Thanks for catching that!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Oct 13, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47256/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Oct 13, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47263/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Oct 13, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47264/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS approved these changes

Oct 13, 2022

View reviewed changes

RafaelGSS left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

danielleadams merged commit 8c1dd95 into v18.x

Oct 13, 2022

danielleadams added a commit that referenced this pull request

Oct 13, 2022


          Working on v18.11.1

cc6a96f

PR-URL: #44968

danielleadams deleted the v18.11.0-proposal branch

October 13, 2022 21:10

danielleadams added a commit that referenced this pull request

Oct 13, 2022


          2022-10-13, Version 18.11.0 (Current)

a7a672c

watch mode (experimental):

Running in 'watch' mode using `node --watch` restarts the process when an
imported file is changed.

Contributed by Moshe Atlow in #44366

Other notable changes:

* fs:
  * (SEMVER-MINOR) add `FileHandle.prototype.readLines` (Antoine du Hamel)
  #42590
* http:
  * (SEMVER-MINOR) add writeEarlyHints function to ServerResponse (Wing)
  #44180
* http2:
  * (SEMVER-MINOR) make early hints generic (Yagiz Nizipli) #44820
* lib:
  * (SEMVER-MINOR) refactor transferable AbortSignal (flakey5) #44048
* src:
  * (SEMVER-MINOR) add detailed embedder process initialization API (Anna
  Henningsen) #44121
* util:
  * (SEMVER-MINOR) add default value option to parsearg (Manuel Spigolon)
  #44631

PR-URL: #44968

danielleadams added a commit to nodejs/nodejs.org that referenced this pull request

Oct 14, 2022


          Blog: v18.11.0 release post

ea5ae49

Refs: nodejs/node#44968

danielleadams mentioned this pull request

Oct 14, 2022

Blog: v18.11.0 release post nodejs/nodejs.org#4878

Merged

danielleadams added a commit to nodejs/nodejs.org that referenced this pull request

Oct 14, 2022


          Blog: v18.11.0 release post

d154e1f

Refs: nodejs/node#44968

danielleadams added a commit to nodejs/nodejs.org that referenced this pull request

Oct 14, 2022


          Blog: v18.11.0 release post (#4878)

0c85494

Refs: nodejs/node#44968

This was referenced Oct 18, 2022

CI Reliability 2022-10-18 nodejs/reliability#403

Open

CI Reliability 2022-10-19 nodejs/reliability#404

Open

CI Reliability 2022-10-20 nodejs/reliability#405

Open

KhafraDev mentioned this pull request

Mar 2, 2023

NotSupportedError: multipart/form-data not supported nodejs/undici#1979

Closed

Reviewers

richardlau

richardlau approved these changes

RafaelGSS

RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci

PRs that need a full CI run.

release

Issues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

danielleadams commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2022-10-13, Version 18.11.0 (Current), @danielleadams

watch mode (experimental)

Other notable changes

Commits

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

richardlau commented Oct 13, 2022

Uh oh!

danielleadams commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 13, 2022

Uh oh!

nodejs-github-bot commented Oct 13, 2022

Uh oh!

nodejs-github-bot commented Oct 13, 2022

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

danielleadams commented Oct 11, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

danielleadams commented Oct 13, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.