GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: check `--test` is disallowed in NODE_OPTIONS by cola119 · Pull Request #44846 · nodejs/node

Conversation

@cola119

@cola119 cola119 commented Oct 1, 2022

Copy link
Copy Markdown
Member

Ref: #42658 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@cola119
test: check --test is disallowed in NODE_OPTIONS
3239300
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 1, 2022
RaisinTen
RaisinTen approved these changes Oct 1, 2022
View reviewed changes
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 1, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 1, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46971/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Oct 1, 2022
View reviewed changes
lpinca
lpinca approved these changes Oct 1, 2022
View reviewed changes
daeyeon
daeyeon approved these changes Oct 2, 2022
View reviewed changes
@daeyeon daeyeon added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 2, 2022
bnb
bnb approved these changes Oct 2, 2022
View reviewed changes
jasnell
jasnell approved these changes Oct 2, 2022
View reviewed changes
This was referenced Oct 3, 2022
CI Reliability 2022-10-03 nodejs/reliability#393
Open
CI Reliability 2022-10-04 nodejs/reliability#394
Open
himself65
himself65 approved these changes Oct 6, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47104/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cola119 cola119 added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 7, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 7, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 2c57b94 into nodejs:main Oct 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 7, 2022

Copy link
Copy Markdown
Collaborator

Landed in 2c57b94
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@cola119 @danielleadams
test: check --test is disallowed in NODE_OPTIONS
a080608 
PR-URL: #44846
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
v18.11.0 proposal #44968
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@bnb bnb bnb approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@daeyeon daeyeon daeyeon approved these changes
@himself65 himself65 himself65 approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@cola119 @nodejs-github-bot @jasnell @bnb @lpinca @cjihrig @daeyeon @himself65 @RaisinTen @panva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.