GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: deduplicate setting RSA OAEP label by tniessen · Pull Request #44849 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Oct 1, 2022

Copy link
Copy Markdown
Member

This bit unfortunately involves manual memory management, so it is best to only implement it once.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tniessen
src: deduplicate setting RSA OAEP label
feaab78 
This bit unfortunately involves manual memory management, so it is best
to only implement it once.
@tniessen tniessen added crypto Issues and PRs related to the crypto subsystem. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 1, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Oct 1, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 1, 2022
panva
panva approved these changes Oct 1, 2022
View reviewed changes
@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 1, 2022
jasnell
jasnell approved these changes Oct 2, 2022
View reviewed changes
RaisinTen
RaisinTen approved these changes Oct 2, 2022
View reviewed changes
@RaisinTen RaisinTen added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2022
@tniessen tniessen removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot mentioned this pull request Oct 3, 2022
CI Reliability 2022-10-03 nodejs/reliability#393
Open
9 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot mentioned this pull request Oct 4, 2022
CI Reliability 2022-10-04 nodejs/reliability#394
Open
16 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot mentioned this pull request Oct 5, 2022
CI Reliability 2022-10-05 nodejs/reliability#395
Open
19 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 5, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 5, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlau richardlau mentioned this pull request Oct 5, 2022
node-test-commit-arm is broken nodejs/build#3044
Closed
@nodejs-github-bot

nodejs-github-bot commented Oct 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47091/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 5, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 50124a8 into nodejs:main Oct 5, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 5, 2022

Copy link
Copy Markdown
Collaborator

Landed in 50124a8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 6, 2022
CI Reliability 2022-10-06 nodejs/reliability#396
Open
CI Reliability 2022-10-07 nodejs/reliability#397
Open
CI Reliability 2022-10-08 nodejs/reliability#398
Open
CI Reliability 2022-10-09 nodejs/reliability#399
Open
CI Reliability 2022-10-10 nodejs/reliability#400
Open
CI Reliability 2022-10-11 nodejs/reliability#401
Open
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@tniessen @danielleadams
src: deduplicate setting RSA OAEP label
0606f92 
This bit unfortunately involves manual memory management, so it is best
to only implement it once.

PR-URL: #44849
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
v18.11.0 proposal #44968
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@jasnell jasnell jasnell approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tniessen @nodejs-github-bot @panva @jasnell @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.