GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — lib: require JSDoc in internal validators code by Trott · Pull Request #44896 · nodejs/node

Conversation

Trott commented Oct 5, 2022

Copy link

Copy Markdown

Member

Closes: #44893

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction

nodejs-github-bot added the needs-ci PRs that need a full CI run. label

Oct 5, 2022

Trott mentioned this pull request

Oct 5, 2022

Require JsDoc on validators #44893

Closed

Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 5, 2022

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 5, 2022

nodejs-github-bot commented Oct 5, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47077/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anonrig reviewed

Oct 5, 2022

View reviewed changes

anonrig left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

himself65 approved these changes

Oct 5, 2022

View reviewed changes

Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Oct 5, 2022

lpinca approved these changes

Oct 6, 2022

View reviewed changes

Trott force-pushed the validator branch from 1f6893e to b124eda Compare

October 6, 2022 21:20

Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 6, 2022

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 6, 2022

nodejs-github-bot commented Oct 6, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47109/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 7, 2022

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Oct 7, 2022

nodejs-github-bot commented Oct 7, 2022

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/44896
✔  Done loading data for nodejs/node/pull/44896
----------------------------------- PR info ------------------------------------
Title      lib: require JSDoc in internal validators code (#44896)
Author     Rich Trott  (@Trott)
Branch     Trott:validator -> nodejs:main
Labels     author ready, needs-ci
Commits    1
 - lib: require JSDoc in internal validators code
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/44896
Fixes: https://github.com/nodejs/node/issues/44893
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44896
Fixes: https://github.com/nodejs/node/issues/44893
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - lib: require JSDoc in internal validators code
   ℹ  This PR was created on Wed, 05 Oct 2022 03:09:30 GMT
   ✔  Approvals: 2
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/44896#pullrequestreview-1132028270
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44896#pullrequestreview-1133531828
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-10-06T21:27:58Z: https://ci.nodejs.org/job/node-test-pull-request/47109/
- Querying data for job/node-test-pull-request/47109/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/3205068185

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          lib: require JSDoc in internal validators code

c50987e

Closes: nodejs#44893
PR-URL: nodejs#44896
Fixes: nodejs#44893
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

Trott force-pushed the validator branch from b124eda to c50987e Compare

October 7, 2022 13:28

Trott merged commit c50987e into nodejs:main

Oct 7, 2022

Trott commented Oct 7, 2022

Copy link

Copy Markdown

Member Author

Landed in c50987e

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Trott deleted the validator branch

October 7, 2022 13:29

danielleadams pushed a commit that referenced this pull request

Oct 11, 2022


          lib: require JSDoc in internal validators code

ada7d82

Closes: #44893
PR-URL: #44896
Fixes: #44893
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

danielleadams mentioned this pull request

Oct 11, 2022

v18.11.0 proposal #44968

Merged

Reviewers

anonrig

anonrig left review comments

lpinca

lpinca approved these changes

himself65

himself65 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

commit-queue-failed

PRs whose Commit Queue landing failed and need manual intervention before retrying.

needs-ci

PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Require JsDoc on validators

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.