GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: move release keys we don't use anymore in README by Trott · Pull Request #44899 · nodejs/node

Conversation

@Trott

@Trott Trott commented Oct 6, 2022

Copy link
Copy Markdown
Member

Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: nodejs/Release#784

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
doc: move release keys we don't use anymore in README
f37e443 
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: nodejs/Release#784
@Trott

Trott commented Oct 6, 2022

Copy link
Copy Markdown
Member Author

@nodejs/releasers
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Oct 6, 2022
@Trott Trott added fast-track PRs proposed for a shorter-than-standard waiting period before landing. and removed doc Issues and PRs related to Node.js documentation. labels Oct 6, 2022
@github-actions

github-actions Bot commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
bricss, lpinca, tniessen, and marsonya reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
fixup! doc: move release keys we don't use anymore in README
d892aa0
Trott added a commit to nodejs/docker-node that referenced this pull request Oct 6, 2022
@Trott
chore: remove keys for emeritus releasers
7264cd2 
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: nodejs/node#44899
@Trott Trott mentioned this pull request Oct 6, 2022
chore: remove keys for emeritus releasers nodejs/docker-node#1782
Merged
richardlau
richardlau approved these changes Oct 6, 2022
View reviewed changes
targos
targos approved these changes Oct 6, 2022
View reviewed changes
lpinca
lpinca approved these changes Oct 6, 2022
View reviewed changes
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 6, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/44899
✔  Done loading data for nodejs/node/pull/44899
----------------------------------- PR info ------------------------------------
Title      doc: move release keys we don't use anymore in README (#44899)
Author     Rich Trott  (@Trott)
Branch     Trott:releasers -> nodejs:main
Labels     fast-track
Commits    2
 - doc: move release keys we don't use anymore in README
 - fixup! doc: move release keys we don't use anymore in README
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/44899
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: https://github.com/nodejs/Release/pull/784
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44899
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: https://github.com/nodejs/Release/pull/784
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 06 Oct 2022 00:23:20 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1132195873
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133136782
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133500155
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3200609475
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Oct 6, 2022
@Trott Trott added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 6, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/44899
✔  Done loading data for nodejs/node/pull/44899
----------------------------------- PR info ------------------------------------
Title      doc: move release keys we don't use anymore in README (#44899)
Author     Rich Trott  (@Trott)
Branch     Trott:releasers -> nodejs:main
Labels     fast-track, commit-queue-squash
Commits    2
 - doc: move release keys we don't use anymore in README
 - fixup! doc: move release keys we don't use anymore in README
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/44899
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: https://github.com/nodejs/Release/pull/784
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44899
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: https://github.com/nodejs/Release/pull/784
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 06 Oct 2022 00:23:20 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1132195873
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133136782
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133500155
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3200661575
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Oct 6, 2022
tniessen
tniessen approved these changes Oct 7, 2022
View reviewed changes
marsonya
marsonya approved these changes Oct 7, 2022
View reviewed changes
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 7, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 7, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 24d255f into nodejs:main Oct 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 7, 2022

Copy link
Copy Markdown
Collaborator

Landed in 24d255f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the releasers branch October 7, 2022 13:26
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@Trott @danielleadams
doc: move release keys we don't use anymore in README
b6b9c42 
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: nodejs/Release#784
PR-URL: #44899
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
v18.11.0 proposal #44968
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes
@richardlau richardlau richardlau approved these changes
@marsonya marsonya marsonya approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Trott @nodejs-github-bot @lpinca @targos @tniessen @richardlau @marsonya
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.