GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey by panva · Pull Request #44917 · nodejs/node

Conversation

@panva

@panva panva commented Oct 7, 2022

Copy link
Copy Markdown
Member

#42542 unfortunately used the hash's output size instead of block size. This also fixes the same problem for HMAC generateKey when length is missing.

Screenshot 2022-10-08 at 1 07 33

Screenshot 2022-10-08 at 1 07 02

Refs: denoland/deno#16180 (comment)
Refs: cloudflare/workerd#68 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@panva panva added crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. webcrypto Issues and PRs related to the Web Crypto API. labels Oct 7, 2022
@panva
panva requested review from jasnell and tniessen October 7, 2022 23:15
@nodejs-github-bot

nodejs-github-bot commented Oct 7, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 7, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 7, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 7, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 7, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47119/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47120/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva mentioned this pull request Oct 8, 2022
WebCryptoAPI: add default generated HMAC key length tests web-platform-tests/wpt#36348
Merged
@panva
panva force-pushed the fix-webcrypto-get-key-length branch from f979ef3 to 7f2258f Compare October 10, 2022 07:46
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 10, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 10, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47149/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47151/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Oct 10, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47155/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 10, 2022
@github-actions github-actions Bot mentioned this pull request Oct 11, 2022
CI Reliability 2022-10-11 nodejs/reliability#401
Open
15 tasks
@panva
crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey
472ae3a
@panva
panva force-pushed the fix-webcrypto-get-key-length branch from 7f2258f to 472ae3a Compare October 12, 2022 10:55
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 12, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 12, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47214/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva mentioned this pull request Oct 12, 2022
2022-10-18, Version 19.0.0 (Current) #44626
Merged
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47219/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Oct 12, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47222/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 12, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 12, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 214354f into nodejs:main Oct 12, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

Landed in 214354f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva
panva deleted the fix-webcrypto-get-key-length branch October 13, 2022 09:12
@github-actions github-actions Bot mentioned this pull request Oct 18, 2022
CI Reliability 2022-10-18 nodejs/reliability#403
Open
13 tasks
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva @danielleadams
crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey
2435a8f 
PR-URL: #44917
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@panva @danielleadams
crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey
57f507f 
PR-URL: #44917
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@panva panva mentioned this pull request Mar 31, 2023
[v16.x backport] WebCryptoAPI fixes #47336
Closed
@panva panva added the backport-open-v16.x label Mar 31, 2023
panva added a commit to panva/node that referenced this pull request Mar 31, 2023
@panva
crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey
ae600b9 
PR-URL: nodejs#44917
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Backport-PR-URL: nodejs#47336
@panva panva removed the backport-open-v16.x label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@aduh95 aduh95 aduh95 approved these changes
@tniessen tniessen Awaiting requested review from tniessen

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. webcrypto Issues and PRs related to the Web Crypto API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@panva @nodejs-github-bot @jasnell @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.