GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v16.x backport] WebCryptoAPI fixes by panva · Pull Request #47336 · nodejs/node

Conversation

@panva

@panva panva commented Mar 31, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We can safely bring v16.x WebCryptoAPI spec conformance to the level of our other LTS/current releases with the backport of these PRs:

  • crypto: add CryptoKey Symbol.toStringTag #46042
  • crypto: add KeyObject Symbol.toStringTag #46043
  • crypto: handle more webcrypto errors with OperationError #45320
  • crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey #44917
  • crypto: update WebCryptoAPI WPT and related fixes #45569
  • crypto: use WebIDL converters in WebCryptoAPI #46067
  • crypto: re-add padding for AES-KW wrapped JWKs #46563
  • crypto: fix webcrypto private/secret import with empty usages #47877

NB: WebCryptoAPI is still experimental Issues and PRs related to experimental features. in v16.x

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. v16.x labels Mar 31, 2023
@panva
panva force-pushed the backport-crypto-symbols-to-v16.x branch from 6a2ac47 to c915898 Compare March 31, 2023 11:18
@panva
panva marked this pull request as ready for review March 31, 2023 11:18
@panva panva changed the title [v16.x] backport CryptoKey and KeyObject prototype SymbolToStringTag [v16.x backport] CryptoKey and KeyObject prototype SymbolToStringTag Mar 31, 2023
panva added 2 commits March 31, 2023 13:24
@panva
crypto: add CryptoKey Symbol.toStringTag
bc17568 
closes nodejs#45987

PR-URL: nodejs#46042
Fixes: nodejs#45987
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Backport-PR-URL: nodejs#47336
@panva
crypto: add KeyObject Symbol.toStringTag
cca5940 
PR-URL: nodejs#46043
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: nodejs#47336
@panva
panva force-pushed the backport-crypto-symbols-to-v16.x branch from c915898 to cca5940 Compare March 31, 2023 11:24
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Mar 31, 2023
@panva
panva marked this pull request as draft March 31, 2023 11:39
panva added 5 commits March 31, 2023 13:46
@panva
crypto: handle more webcrypto errors with OperationError
c7c5011 
PR-URL: nodejs#45320
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: nodejs#47336
@panva
test: mock structuredClone for WebCryptoAPI WPTs
5b9738a
@panva
crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey
ae600b9 
PR-URL: nodejs#44917
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Backport-PR-URL: nodejs#47336
@panva
crypto: ensure "x" is present when importing private CFRG webcrypto keys
252839a 
PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: nodejs#47336
@panva
crypto: fix X25519 and X448 webcrypto public CryptoKey usages
a321238 
PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: nodejs#47336
@panva panva added commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. experimental Issues and PRs related to experimental features. labels Mar 31, 2023
@panva
panva marked this pull request as ready for review March 31, 2023 12:18
@panva panva changed the title [v16.x backport] CryptoKey and KeyObject prototype SymbolToStringTag [v16.x] backport WebCryptoAPI fixes Mar 31, 2023
panva added 3 commits March 31, 2023 14:21
@panva
crypto: use DataError for webcrypto keyData import failures
b72552c 
PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: nodejs#47336
@panva
crypto: validate CFRG webcrypto JWK import "d" and "x" are a pair
adca91a 
PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: nodejs#47336
@panva
crypto: fix ECDH webcrypto public CryptoKey usages
8570ffa 
PR-URL: nodejs#45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: nodejs#47336
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50796/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Apr 2, 2023
CI Reliability 2023-04-02 nodejs/reliability#537
Open
30 tasks
@panva

panva commented Apr 2, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/backporters
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams

danielleadams commented Apr 2, 2023

Copy link
Copy Markdown
Contributor

@panva I'm preparing v16.x for 4/4 - looks like this still needs reviewers before it can be landed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
danielleadams
danielleadams approved these changes Apr 2, 2023
View reviewed changes
@panva
panva requested review from jasnell and tniessen April 2, 2023 21:06
@panva

panva commented Apr 2, 2023

Copy link
Copy Markdown
Member Author

@danielleadams there was 16.x minor release 4 days ago... There's another one planned for tuesday 4/4?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Apr 3, 2023
CI Reliability 2023-04-03 nodejs/reliability#538
Open
28 tasks
@panva

panva commented Apr 3, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/crypto
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. review wanted PRs that need review. labels Apr 9, 2023
tniessen
tniessen approved these changes Apr 22, 2023
View reviewed changes
@panva panva removed the review wanted PRs that need review. label Apr 26, 2023
panva added 3 commits May 15, 2023 21:02
@panva
crypto: use WebIDL converters in WebCryptoAPI
d50a7dc 
WebCryptoAPI functions' arguments are now coersed and validated as per
their WebIDL definitions like in other Web Crypto API implementations.
This further improves interoperability with other implementations of
Web Crypto API.

PR-URL: nodejs#46067
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Backport-PR-URL: nodejs#47336
@panva
crypto: re-add padding for AES-KW wrapped JWKs
588a166 
PR-URL: nodejs#46563
Reviewed-By: James M Snell <[email protected]>
Backport-PR-URL: nodejs#47336
@panva
crypto: fix webcrypto private/secret import with empty usages
ca5b942 
Refs: nodejs#47864
PR-URL: nodejs#47877
Refs: nodejs#47864
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Backport-PR-URL: nodejs#47336
@nodejs-github-bot

nodejs-github-bot commented May 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51820/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51823/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced May 16, 2023
CI Reliability 2023-05-16 nodejs/reliability#567
Open
CI Reliability 2023-05-17 nodejs/reliability#568
Open
CI Reliability 2023-05-18 nodejs/reliability#569
Open
CI Reliability 2023-05-19 nodejs/reliability#570
Open
CI Reliability 2023-05-20 nodejs/reliability#571
Open
CI Reliability 2023-05-21 nodejs/reliability#572
Open
CI Reliability 2023-05-22 nodejs/reliability#573
Open
@github-actions github-actions Bot mentioned this pull request May 23, 2023
CI Reliability 2023-05-23 nodejs/reliability#574
Open
22 tasks
@panva

panva commented Jul 26, 2023

Copy link
Copy Markdown
Member Author

This is no longer likely to make an impact on v16.x LTS with its EOL in ~6 week
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva closed this Jul 26, 2023
@panva
panva deleted the backport-crypto-symbols-to-v16.x branch August 22, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen approved these changes
@jasnell jasnell Awaiting requested review from jasnell
+1 more reviewer
@danielleadams danielleadams danielleadams approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. webcrypto Issues and PRs related to the Web Crypto API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@panva @nodejs-github-bot @danielleadams @tniessen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.