GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: call {before,after}Each() on suites by cjihrig · Pull Request #45161 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Prior to this commit, beforeEach() and afterEach() hooks were not called on test suites (describe()). This commit addresses that.

Fixes: #45028

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@cjihrig
test_runner: call {before,after}Each() on suites
94f4247 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs#45028
@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 25, 2022
MoLow
MoLow approved these changes Oct 25, 2022
View reviewed changes
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 25, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 25, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47468/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Oct 25, 2022
View reviewed changes
@cjihrig cjihrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed needs-ci PRs that need a full CI run. labels Oct 26, 2022
jasnell
jasnell approved these changes Oct 26, 2022
View reviewed changes
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 27, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 27, 2022
@nodejs-github-bot
nodejs-github-bot merged commit a69a300 into nodejs:main Oct 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2022

Copy link
Copy Markdown
Collaborator

Landed in a69a300
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig
cjihrig deleted the describe branch October 27, 2022 12:42
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@cjihrig @RafaelGSS
test_runner: call {before,after}Each() on suites
c837b26 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: #45028
PR-URL: #45161
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@cjihrig @RafaelGSS
test_runner: call {before,after}Each() on suites
afa8291 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: #45028
PR-URL: #45161
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MoLow MoLow mentioned this pull request Nov 24, 2022
[v16.x backport] backport multiple test runner features #45602
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Dec 9, 2022
@cjihrig @MoLow
test_runner: call {before,after}Each() on suites
51c7b47 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs#45028
PR-URL: nodejs#45161
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@cjihrig @danielleadams
test_runner: call {before,after}Each() on suites
deb773b 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: #45028
PR-URL: #45161
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@cjihrig @danielleadams
test_runner: call {before,after}Each() on suites
a59c907 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: #45028
PR-URL: #45161
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@cjihrig @MoLow
test_runner: call {before,after}Each() on suites
5810158 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs/node#45028
PR-URL: nodejs/node#45161
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
(cherry picked from commit a69a30016cf3395b0bd775c1340ab6ecbac58296)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@cjihrig @MoLow
fix: call {before,after}Each() on suites
b55c81d 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs/node#45028
PR-URL: nodejs/node#45161
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
(cherry picked from commit a69a30016cf3395b0bd775c1340ab6ecbac58296)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@cjihrig @MoLow
fix: call {before,after}Each() on suites
c0c3dde 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs/node#45028
PR-URL: nodejs/node#45161
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
(cherry picked from commit a69a30016cf3395b0bd775c1340ab6ecbac58296)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@cjihrig @MoLow
fix: call {before,after}Each() on suites
0bfdb77 
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs/node#45028
PR-URL: nodejs/node#45161
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
(cherry picked from commit a69a30016cf3395b0bd775c1340ab6ecbac58296)
@MoLow MoLow mentioned this pull request Mar 15, 2023
chore(test): migrate to node:test nodejs/node-core-utils#670
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

describe block without it does not trigger hooks

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@cjihrig @nodejs-github-bot @jasnell @anonrig @MoLow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.