GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v16.x backport] backport multiple test runner features by MoLow · Pull Request #45602 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented Nov 24, 2022

Copy link
Copy Markdown
Member

depends on #44873

this PR backports

  • test_runner: remove runtime experimental warning #44844
  • doc: remove unnecessary leading commas #44854
  • src: fix test runner coverage #45055
  • test_runner: add --test-name-pattern CLI flag #44508
  • test_runner: call {before,after}Each() on suites #45161
  • test_runner: add extra fields in AssertionError YAML #44952
  • test_runner: make sure tap subtest is reported in order #45220
  • test_runner: fix afterEach not running on test failures #45204
  • test_runner: avoid swallowing of asynchronously thrown errors #45264
  • doc: fix test runner's only tests section header #45343
  • test_runner: support function mocking #45326
  • watch: watch for unexsiting dependencies #45348
  • test_runner: support watch mode #45214
  • test_runner: add TAP parser #43525

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jaydenseric and ronjouch reacted with eyes emoji
All reactions
  • 👀 2 reactions
@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. v16.x labels Nov 24, 2022
@richardlau

richardlau commented Nov 24, 2022

Copy link
Copy Markdown
Member

This will have to wait before it can land, #43525 at least hasn't gone out in a current release yet.

MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cjihrig and others added 14 commits December 9, 2022 09:23
@cjihrig @MoLow
test_runner: remove runtime experimental warning
3f16e33
This commit removes the experimental warning that is emitted
when the test runner is used. The test runner feature is still
considered experimental, but this change makes its output
easier to read.

PR-URL: nodejs#44844
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig @MoLow
doc: remove unnecessary leading commas
588d71e
There are several locations in the test_runner API docs where
the optional first argument to a function was written with a
leading comma. Since these are first arguments, the commas
can be removed.

PR-URL: nodejs#44854
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MoLow
src: fix test runner coverage
16b7b2b
PR-URL: nodejs#45055
Fixes: nodejs#45013
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@cjihrig @MoLow
test_runner: add --test-name-pattern CLI flag
25cf755
This commit adds support for running tests that match a
regular expression.

Fixes: nodejs#42984
@cjihrig @MoLow
test_runner: call {before,after}Each() on suites
51c7b47
Prior to this commit, beforeEach() and afterEach() hooks were
not called on test suites (describe()). This commit addresses that.

Fixes: nodejs#45028
PR-URL: nodejs#45161
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@bengl @MoLow
test_runner: add extra fields in AssertionError YAML
7a39747
Many TAP reporters offer special-case handling of YAML objects
containing `expected`, `actual`, and `operator` fields, as produced by
`AssertionError` and similar userland Error classes.

PR-URL: nodejs#44952
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MoLow
test_runner: report tap subtest in order
e240525
PR-URL: nodejs#45220
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MrJithil @MoLow
test_runner: fix afterEach not running on test failures
94174b7
test_runner: fix afterEach not running on test failures

PR-URL: nodejs#45204
Fixes: nodejs#45192
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@fossamagna @MoLow
test_runner: avoid swallowing of asynchronously thrown errors
549b123
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@cjihrig @MoLow
doc: fix test runner's only tests section header
5e632e4
Only tests are not a subsection of describe/it syntax.
This commit updates the heading of the 'only tests'
section to reflect this.

PR-URL: nodejs#45343
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
@cjihrig @MoLow
test_runner: support function mocking
aadc76d
This commit allows tests in the test runner to mock functions
and methods.

PR-URL: nodejs#45326
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@MoLow
watch: watch for missing dependencies
a47c61e
PR-URL: nodejs#45348
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
@MoLow
test_runner: support watch mode
fd7d1dd
PR-URL: nodejs#45214
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@manekinekko @MoLow
test_runner: add initial TAP parser
57e6777
Work in progress

PR-URL: nodejs#43525
Refs: nodejs#43344
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@MoLow
MoLow force-pushed the backport-v16-test-runner-more branch from 22ed480 to 57e6777 Compare December 9, 2022 07:23
@richardlau richardlau mentioned this pull request Dec 14, 2022
test_runner: add getter and setter to MockTracker #45506
Closed
@danielleadams

danielleadams commented Apr 2, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@MoLow should this go into the next v16.x? Looks like a doc file merge conflict just needs resolving.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoLow

MoLow commented Apr 2, 2023

Copy link
Copy Markdown
Member Author

@MoLow should this go into the next v16.x? Looks like a doc file merge conflict just needs resolving

I am not sure. there are a lot more changes in the test runner besides thes so I am not sure if we should backport only some of them. can we backport all of the test runner changes? @nodejs/test_runner WDYT?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cjihrig

cjihrig commented Apr 2, 2023

Copy link
Copy Markdown
Contributor

The test runner is already in Node 16 so I'm ok with backporting all of it, but would defer to the releasers.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoLow MoLow closed this Apr 16, 2023
@MoLow
MoLow deleted the backport-v16-test-runner-more branch April 16, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@MoLow @nodejs-github-bot @richardlau @danielleadams @cjihrig @bengl @MrJithil @fossamagna @manekinekko
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.