GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update V8 to 10.8 by targos · Pull Request #45230 · nodejs/node

Conversation

@targos

@targos targos commented Oct 29, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Stable Release:
Tue, Nov 29, 2022

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and dnalborczyk reacted with thumbs up emoji bricss, Xstoudi, and dnalborczyk reacted with hooray emoji bricss, tniessen, and dnalborczyk reacted with heart emoji bricss and dnalborczyk reacted with rocket emoji
All reactions
  • 👍 2 reactions
  • 🎉 3 reactions
  • ❤️ 3 reactions
  • 🚀 2 reactions
@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 29, 2022
@targos targos added dont-land-on-v14.x request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 29, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 29, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
This was referenced Oct 30, 2022
CI Reliability 2022-10-30 nodejs/reliability#415
Open
CI Reliability 2022-10-31 nodejs/reliability#416
Open
@targos

targos commented Oct 31, 2022

Copy link
Copy Markdown
Member Author

There's also a failure with test-trace-gc-flag

12:10:45 not ok 1 v8-updates/test-trace-gc-flag
12:10:45   ---
12:10:45   duration_ms: 0.348
12:10:45   severity: fail
12:10:45   exitcode: 1
12:10:45   stack: |-
12:10:45     node:assert:1027
12:10:45         throw err;
12:10:45         ^
12:10:45     
12:10:45     AssertionError [ERR_ASSERTION]: The input did not match the regular expression /\bMark-sweep\b/. Input:
12:10:45     
12:10:45     '[41903:0x55803f320350]       93 ms: Mark-Compact 11.8 (18.1) -> 4.3 (14.1) MB, 4.3 / 0.0 ms  (average mu = 1.000, current mu = 1.000) testing; GC in old space requested'
12:10:45     
12:10:45         at /home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-trace-gc-flag.js:30:12
12:10:45         at Array.forEach (<anonymous>)
12:10:45         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-trace-gc-flag.js:29:9)
12:10:45         at Module._compile (node:internal/modules/cjs/loader:1175:14)
12:10:45         at Module._extensions..js (node:internal/modules/cjs/loader:1229:10)
12:10:45         at Module.load (node:internal/modules/cjs/loader:1038:32)
12:10:45         at Module._load (node:internal/modules/cjs/loader:879:12)
12:10:45         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:82:12)
12:10:45         at node:internal/main/run_main_module:23:47 {
12:10:45       generatedMessage: true,
12:10:45       code: 'ERR_ASSERTION',
12:10:45       actual: '[41903:0x55803f320350]       93 ms: Mark-Compact 11.8 (18.1) -> 4.3 (14.1) MB, 4.3 / 0.0 ms  (average mu = 1.000, current mu = 1.000) testing; GC in old space requested',
12:10:45       expected: /\bMark-sweep\b/,
12:10:45       operator: 'match'
12:10:45     }
12:10:45     
12:10:45     Node.js v20.0.0-pre
12:10:45   ...

/cc @tony-go

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Oct 31, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@nodejs/platform-windows

x86 build fails on Windows:

12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(344,35): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(345,28): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\large-spaces.h(59,33): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Nov 1, 2022
CI Reliability 2022-11-01 nodejs/reliability#417
Open
CI Reliability 2022-11-02 nodejs/reliability#418
Open
@StefanStojanovic

StefanStojanovic commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Hello, @targos. All failing asserts are manifestations of the same issue - MemoryChunkLayout::kMemoryChunkHeaderSize not being set to the correct value. I've found this commit in the v8 repo that fixes the problem. I've tried it locally and the build passes.

targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Nov 2, 2022

Copy link
Copy Markdown
Member Author

@StefanStojanovic thanks! I'll cherry-pick that commit

StefanStojanovic reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos
targos force-pushed the v8-108 branch from b0f077c to 9608083 Compare November 5, 2022 09:10
@nodejs-github-bot

nodejs-github-bot commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47713/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/4961/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/4961/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/4961/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Nov 6, 2022
CI Reliability 2022-11-06 nodejs/reliability#420
Open
CI Reliability 2022-11-07 nodejs/reliability#421
Open
CI Reliability 2022-11-08 nodejs/reliability#422
Open
@targos

targos commented Nov 19, 2022

Copy link
Copy Markdown
Member Author

It's the first time we land a V8 PR with the CQ. I hope it won't break anything with commit messages like this one:
image

bricss reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Nov 20, 2022
CI Reliability 2022-11-20 nodejs/reliability#434
Open
CI Reliability 2022-11-21 nodejs/reliability#435
Open
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 21, 2022
@gengjiawen @anonrig
deps: fix V8 build issue with inline methods
45c5eb5
PR-URL: nodejs#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs#38807
Refs: nodejs#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
PR-URL: nodejs#45230
Reviewed-By: Yagiz Nizipli <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 21, 2022
@gengjiawen @anonrig
deps: V8: fix v8-cppgc.h for MSVC
11f4a81
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: nodejs#42375

PR-URL: nodejs#42657
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs#45230
Reviewed-By: Yagiz Nizipli <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 21, 2022
@targos @anonrig
deps: silence irrelevant V8 warning
d3eba45
PR-URL: nodejs#44741
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#45230
Reviewed-By: Yagiz Nizipli <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 21, 2022
@targos @anonrig
deps: fix V8 build on Windows with MSVC
1e17605
PR-URL: nodejs#44741
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#45230
Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@targos @ruyadorno
deps: update V8 to 10.8.168.20
a3b9967
PR-URL: #45230
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@targos @ruyadorno
build: reset embedder string to "-node.0"
54fd8a1
PR-URL: #45230
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@gengjiawen @ruyadorno
deps: fix V8 build issue with inline methods
e929254
PR-URL: #35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: #40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: #40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: #38807
Refs: #38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
PR-URL: #45230
Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@gengjiawen @ruyadorno
deps: V8: fix v8-cppgc.h for MSVC
9348bdd
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
Refs: #42375

PR-URL: #42657
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #45230
Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@targos @ruyadorno
deps: silence irrelevant V8 warning
3cd6367
PR-URL: #44741
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #45230
Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@targos @ruyadorno
deps: fix V8 build on Windows with MSVC
1370b1a
PR-URL: #44741
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #45230
Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@targos @ruyadorno
deps: V8: cherry-pick 92a7385171bb
51eb323
Original commit message:

    [heap] Fix 32bit msvc builds

    Size of ActiveSystemPages is 8 bytes even on 32bit builds, thus
    forcing 8 bytes alignment for MemoryChunk.

    Change-Id: I5ca1e18329d6e68a8b6811c3c27cb224c765cb63
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3966953
    Commit-Queue: Omer Katz <[email protected]>
    Reviewed-by: Michael Lippautz <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#83845}

Refs: v8/v8@92a7385
PR-URL: #45230
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@targos @ruyadorno
deps: V8: cherry-pick f1c888e7093e
e70c309
Original commit message:

    [base] Fix SmartOS build

    That platform doesn't have `malloc_usable_size`.

    Refs: nodejs/node-v8#239
    Change-Id: I011dd8449d02b27219a32cba00132cd068069f50
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4026402
    Reviewed-by: Michael Lippautz <[email protected]>
    Commit-Queue: Michaël Zasso <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#84256}

Refs: v8/v8@f1c888e
PR-URL: #45230
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@anonrig @ruyadorno
deps: V8: cherry-pick 9df5ef70ff18
aaa4ac7
Original commit message:

    Add an `v8::ArrayBuffer::WasDetached` method to the C++ API

    V8's C++ API does not give a way to tell whether an ArrayBuffer has
    been detached from the `v8::ArrayBuffer` class. In fact, as far as can
    be told from the C++ API without running JS code, detached
    ArrayBuffers behave the same as zero-sized ArrayBuffers and there is
    no way to observe the difference. However, this difference can be
    observed in JS because constructing a TypedArray from a detached
    ArrayBuffer will throw.

    This change adds a `WasDetached` method to the `v8::ArrayBuffer` class
    to give embedders access to this information without having to run JS
    code.

    Bug: v8:13159
    Change-Id: I2bb1e380cee1cecd31f6d48ec3d9f28c03a8a673
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810345
    Commit-Queue: Toon Verwaest <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#83963}

Refs: v8/v8@9df5ef7
PR-URL: #45474
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #45230
Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@targos @ruyadorno
test: adapt test-v8-stats for V8 update
72f2df2
PR-URL: #45230
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@tony-go @ruyadorno
test: fix test-trace-gc-flag
076e9ee
PR-URL: #45230
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@github-actions github-actions Bot mentioned this pull request Nov 22, 2022
CI Reliability 2022-11-22 nodejs/reliability#436
Open
15 tasks
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@gengjiawen gengjiawen mentioned this pull request Feb 1, 2023
deps: update V8 to 11.1 #46445
Closed
@AdamMajer AdamMajer mentioned this pull request Mar 13, 2023
s390x: illegal instruction in unit tests #47064
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@targos targos

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@targos @nodejs-github-bot @StefanStojanovic @tony-go @anonrig @gengjiawen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.