GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — deps: update V8 to 10.8 by targos · Pull Request #45230 · nodejs/node Conversation
|
|
Review requested:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
There's also a failure with /cc @tony-go |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@nodejs/platform-windows x86 build fails on Windows: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hello, @targos. All failing asserts are manifestations of the same issue - |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@StefanStojanovic thanks! I'll cherry-pick that commit |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/4961/ |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/4961/ |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It's the first time we land a V8 PR with the CQ. I hope it won't break anything with commit messages like this one: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
PR-URL: nodejs#35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: nodejs#40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: nodejs#40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: nodejs#38807 Refs: nodejs#38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]> PR-URL: nodejs#45230 Reviewed-By: Yagiz Nizipli <[email protected]>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs#42375 PR-URL: nodejs#42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]> PR-URL: nodejs#45230 Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: nodejs#44741 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: nodejs#45230 Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: nodejs#44741 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: nodejs#45230 Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #45230 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #45230 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #35415 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> deps: patch for v8 on windows PR-URL: #40010 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> deps: patch v8 for vs2019 in std17 PR-URL: #40060 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> deps: workaround debug link error on Windows PR-URL: #38807 Refs: #38788 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ash Cripps <[email protected]> PR-URL: #45230 Reviewed-By: Yagiz Nizipli <[email protected]>
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: #42375 PR-URL: #42657 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]> PR-URL: #45230 Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #44741 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #45230 Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #44741 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #45230 Reviewed-By: Yagiz Nizipli <[email protected]>
Original commit message:
[heap] Fix 32bit msvc builds
Size of ActiveSystemPages is 8 bytes even on 32bit builds, thus
forcing 8 bytes alignment for MemoryChunk.
Change-Id: I5ca1e18329d6e68a8b6811c3c27cb224c765cb63
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3966953
Commit-Queue: Omer Katz <[email protected]>
Reviewed-by: Michael Lippautz <[email protected]>
Cr-Commit-Position: refs/heads/main@{#83845}
Refs: v8/v8@92a7385
PR-URL: #45230
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Original commit message:
[base] Fix SmartOS build
That platform doesn't have `malloc_usable_size`.
Refs: nodejs/node-v8#239
Change-Id: I011dd8449d02b27219a32cba00132cd068069f50
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4026402
Reviewed-by: Michael Lippautz <[email protected]>
Commit-Queue: Michaël Zasso <[email protected]>
Cr-Commit-Position: refs/heads/main@{#84256}
Refs: v8/v8@f1c888e
PR-URL: #45230
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Original commit message:
Add an `v8::ArrayBuffer::WasDetached` method to the C++ API
V8's C++ API does not give a way to tell whether an ArrayBuffer has
been detached from the `v8::ArrayBuffer` class. In fact, as far as can
be told from the C++ API without running JS code, detached
ArrayBuffers behave the same as zero-sized ArrayBuffers and there is
no way to observe the difference. However, this difference can be
observed in JS because constructing a TypedArray from a detached
ArrayBuffer will throw.
This change adds a `WasDetached` method to the `v8::ArrayBuffer` class
to give embedders access to this information without having to run JS
code.
Bug: v8:13159
Change-Id: I2bb1e380cee1cecd31f6d48ec3d9f28c03a8a673
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810345
Commit-Queue: Toon Verwaest <[email protected]>
Reviewed-by: Toon Verwaest <[email protected]>
Cr-Commit-Position: refs/heads/main@{#83963}
Refs: v8/v8@9df5ef7
PR-URL: #45474
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #45230
Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #45230 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #45230 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.