GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix test runner's only tests section header by cjihrig · Pull Request #45343 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Only tests are not a subsection of describe/it syntax. This commit updates the heading of the 'only tests' section to reflect this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@cjihrig
doc: fix test runner's only tests section header
b66a938
Only tests are not a subsection of describe/it syntax.
This commit updates the heading of the 'only tests'
section to reflect this.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. dont-land-on-v14.x test_runner Issues and PRs related to the test runner subsystem. labels Nov 6, 2022
MoLow
MoLow approved these changes Nov 6, 2022
View reviewed changes
lpinca
lpinca approved these changes Nov 6, 2022
View reviewed changes
VoltrexKeyva
VoltrexKeyva approved these changes Nov 6, 2022
View reviewed changes
@VoltrexKeyva VoltrexKeyva added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 6, 2022
@github-actions

github-actions Bot commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @VoltrexMaster. Please 👍 to approve.

MoLow and marsonya reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marsonya
marsonya approved these changes Nov 7, 2022
View reviewed changes
@cjihrig
cjihrig merged commit 2119fa4 into main Nov 7, 2022
@cjihrig
cjihrig deleted the cjihrig-patch-1 branch November 7, 2022 18:52
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@cjihrig @RafaelGSS
doc: fix test runner's only tests section header
d5e5c75
Only tests are not a subsection of describe/it syntax.
This commit updates the heading of the 'only tests'
section to reflect this.

PR-URL: #45343
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 10, 2022
v19.1.0 proposal #45269
Merged
@MoLow MoLow mentioned this pull request Nov 24, 2022
[v16.x backport] backport multiple test runner features #45602
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Dec 9, 2022
@cjihrig @MoLow
doc: fix test runner's only tests section header
5e632e4
Only tests are not a subsection of describe/it syntax.
This commit updates the heading of the 'only tests'
section to reflect this.

PR-URL: nodejs#45343
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@cjihrig @danielleadams
doc: fix test runner's only tests section header
fc5c55d
Only tests are not a subsection of describe/it syntax.
This commit updates the heading of the 'only tests'
section to reflect this.

PR-URL: #45343
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@cjihrig @danielleadams
doc: fix test runner's only tests section header
913b669
Only tests are not a subsection of describe/it syntax.
This commit updates the heading of the 'only tests'
section to reflect this.

PR-URL: #45343
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@MoLow MoLow MoLow approved these changes
@marsonya marsonya marsonya approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@cjihrig @lpinca @MoLow @marsonya @VoltrexKeyva @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.