GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — watch: watch for unexsiting dependencies by MoLow · Pull Request #45348 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented Nov 6, 2022

Copy link
Copy Markdown
Member

an alternative for #45259
if we choose to favor this solution, need to add some tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@MoLow MoLow added the watch-mode Issues and PRs related to watch mode. label Nov 6, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 6, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Nov 6, 2022
@MoLow

MoLow commented Nov 6, 2022

Copy link
Copy Markdown
Member Author

CC @ruyadorno
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
GeoffreyBooth
GeoffreyBooth reviewed Nov 6, 2022
View reviewed changes
Comment thread lib/internal/modules/esm/resolve.js Outdated

@GeoffreyBooth GeoffreyBooth Nov 6, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we prefix all our environment variables with NODE_: https://nodejs.org/api/cli.html#environment-variables

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@MoLow MoLow Nov 7, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in a follow up PR, as this environment variable existed before this pr

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ruyadorno
ruyadorno reviewed Nov 7, 2022
View reviewed changes

@ruyadorno ruyadorno left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍 thanks @MoLow!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/sequential/test-watch-mode.mjs Resolved

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno
ruyadorno approved these changes Nov 7, 2022
View reviewed changes
@ruyadorno ruyadorno mentioned this pull request Nov 7, 2022
watch: fix reloading for rebuild/compiled files #45259
Closed
@ruyadorno

ruyadorno commented Nov 9, 2022

Copy link
Copy Markdown
Member

@MoLow also, there's a typo on your original commit, it should pb say watch for missing dependencies instead
MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow force-pushed the watch-reload-not-found branch from d686854 to 1d02416 Compare November 10, 2022 11:54
@MoLow
MoLow requested review from Linkgoron and benjamingr November 10, 2022 12:00
@MoLow
MoLow force-pushed the watch-reload-not-found branch from 1d02416 to 56ec098 Compare November 10, 2022 15:48
ljharb
ljharb reviewed Nov 10, 2022
View reviewed changes
Comment thread test/sequential/test-watch-mode.mjs Resolved

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr reviewed Nov 11, 2022
View reviewed changes
Comment thread test/sequential/test-watch-mode.mjs Resolved

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr reviewed Nov 11, 2022
View reviewed changes
Comment thread test/sequential/test-watch-mode.mjs Resolved

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr reviewed Nov 11, 2022
View reviewed changes
Comment thread test/sequential/test-watch-mode.mjs Resolved

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr reviewed Nov 11, 2022
View reviewed changes

@benjamingr benjamingr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain how this fixes the issue? Why is telling watch mode that loading a module failed fix things? Is is because those files are removed so they can be re-added later when they are re-generated?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49
@MoLow

MoLow commented Nov 12, 2022

Copy link
Copy Markdown
Member Author

Is is because those files are removed so they can be re-added later when they are re-generated?

that is the precise reason. see the tests added in the original PR

node/test/sequential/test-watch-mode.mjs

Line 178 in df6b0cd

it('should watch changes to previously loaded dependencies', async () => {

benjamingr reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow added 4 commits November 12, 2022 20:39
@MoLow
watch: watch for missing dependencies
e8fe5bd
@MoLow
fix
27a6af3
@MoLow
debug
d4c49a6
@MoLow
CR & fix
d1c155c
@MoLow
MoLow force-pushed the watch-reload-not-found branch from e9b0848 to d1c155c Compare November 12, 2022 18:40
@MoLow
MoLow requested a review from benjamingr November 12, 2022 18:41
@MoLow MoLow added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Nov 12, 2022
@MoLow
lint
17f1fa2
benjamingr
benjamingr approved these changes Nov 13, 2022
View reviewed changes
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 13, 2022
Linkgoron
Linkgoron approved these changes Nov 13, 2022
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 13, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47907/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow mentioned this pull request Nov 13, 2022
test_runner: support watch mode #45214
Merged
4 tasks done
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 13, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 13, 2022
@nodejs-github-bot
nodejs-github-bot merged commit ce16bf5 into nodejs:main Nov 13, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2022

Copy link
Copy Markdown
Collaborator

Landed in ce16bf5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow deleted the watch-reload-not-found branch November 13, 2022 15:14
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@MoLow @ruyadorno
watch: watch for missing dependencies
3263ceb 
PR-URL: #45348
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
@MoLow MoLow mentioned this pull request Nov 24, 2022
[v16.x backport] backport multiple test runner features #45602
Closed
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
MoLow added a commit to MoLow/node that referenced this pull request Dec 9, 2022
@MoLow
watch: watch for missing dependencies
a47c61e 
PR-URL: nodejs#45348
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
@merceyz merceyz mentioned this pull request Dec 9, 2022
fix(pnp): report missing files in watch mode yarnpkg/berry#5132
Merged
3 tasks done
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@MoLow @danielleadams
watch: watch for missing dependencies
b16807a 
PR-URL: #45348
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@MoLow @danielleadams
watch: watch for missing dependencies
24bfe54 
PR-URL: #45348
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
@merceyz merceyz mentioned this pull request Jan 7, 2023
fix(pnp): watch mode on Node.js v18.13.0 yarnpkg/berry#5182
Merged
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb left review comments
@GeoffreyBooth GeoffreyBooth GeoffreyBooth left review comments
@ruyadorno ruyadorno ruyadorno approved these changes
@benjamingr benjamingr benjamingr approved these changes
+1 more reviewer
@Linkgoron Linkgoron Linkgoron approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. watch-mode Issues and PRs related to watch mode.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@MoLow @nodejs-github-bot @ruyadorno @ljharb @GeoffreyBooth @Linkgoron @benjamingr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.