GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — crypto: update WebCryptoAPI WPT and related fixes by panva · Pull Request #45569 · nodejs/node

Conversation

@panva

@panva panva commented Nov 22, 2022

Copy link
Copy Markdown
Member

As the Chromium project is working on Ed25519 and X25519 implemenetation there are new WPTs being added. Mostly these are failure test vectors. Some of these fixes have also been applied to other algorithms where WPTs are currently lacking coverage.

I suggest to review individual commits, will land with commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. .

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@panva panva added crypto Issues and PRs related to the crypto subsystem. webcrypto Issues and PRs related to the Web Crypto API. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Nov 22, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 22, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 22, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 22, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 22, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva
panva force-pushed the webcrypto-wpt-bump branch from afce4ea to c58018b Compare November 22, 2022 10:48
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 22, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 22, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
aduh95
aduh95 reviewed Nov 22, 2022
View reviewed changes
Comment thread lib/internal/crypto/cfrg.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/crypto/ec.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@aduh95

aduh95 commented Nov 22, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Is the order of commits correct? Shouldn't the commit that updates WTP come at the end after the fixes?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva

panva commented Nov 22, 2022

Copy link
Copy Markdown
Member Author

Is the order of commits correct? Shouldn't the commit that updates WTP come at the end after the fixes?

It intentionally comes this way so that the fixes can cross of failing tests from the expectations file.
aduh95 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Nov 22, 2022
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 22, 2022
@panva

This comment was marked as outdated.

Sign in to view
@panva
panva requested review from jasnell and tniessen November 22, 2022 22:52
@github-actions github-actions Bot mentioned this pull request Nov 24, 2022
CI Reliability 2022-11-24 nodejs/reliability#438
Open
16 tasks
panva added 6 commits November 24, 2022 08:00
@panva
test,crypto: update WebCryptoAPI WPT
98334bf
@panva
crypto: ensure "x" is present when importing private CFRG webcrypto keys
933051a
@panva
crypto: fix X25519 and X448 webcrypto public CryptoKey usages
e44c272
@panva
crypto: use DataError for webcrypto keyData import failures
bd35373
@panva
crypto: use DataError for CFRG webcrypto raw and jwk import key checks
ae629e4
@panva
crypto: validate CFRG webcrypto JWK import "d" and "x" are a pair
3785129
targos pushed a commit that referenced this pull request Dec 12, 2022
@panva @targos
crypto: fix ECDH webcrypto public CryptoKey usages
7cc9998 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Dec 12, 2022
@panva @targos
crypto: refactor verify acceptable key usage functions
845f805 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Dec 12, 2022
v19.3.0 release proposal #45831
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva @danielleadams
test,crypto: update WebCryptoAPI WPT
df6c575 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva @danielleadams
crypto: ensure "x" is present when importing private CFRG webcrypto keys
b0ed38a 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva @danielleadams
crypto: fix X25519 and X448 webcrypto public CryptoKey usages
31451b7 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva @danielleadams
crypto: use DataError for webcrypto keyData import failures
89d5fb8 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva @danielleadams
crypto: use DataError for CFRG webcrypto raw and jwk import key checks
fe925d4 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva @danielleadams
crypto: validate CFRG webcrypto JWK import "d" and "x" are a pair
aa9644c 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva @danielleadams
crypto: fix ECDH webcrypto public CryptoKey usages
066d919 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@panva @danielleadams
crypto: refactor verify acceptable key usage functions
98c1128 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@panva @danielleadams
test,crypto: update WebCryptoAPI WPT
a2e5126 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@panva @danielleadams
crypto: ensure "x" is present when importing private CFRG webcrypto keys
27adcc9 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@panva @danielleadams
crypto: fix X25519 and X448 webcrypto public CryptoKey usages
a976a63 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@panva @danielleadams
crypto: use DataError for webcrypto keyData import failures
8fcfbef 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@panva @danielleadams
crypto: use DataError for CFRG webcrypto raw and jwk import key checks
621e3c9 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@panva @danielleadams
crypto: validate CFRG webcrypto JWK import "d" and "x" are a pair
b92b804 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@panva @danielleadams
crypto: fix ECDH webcrypto public CryptoKey usages
ef64b86 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@panva @danielleadams
crypto: refactor verify acceptable key usage functions
fa0a2d8 
PR-URL: #45569
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@panva panva mentioned this pull request Mar 31, 2023
[v16.x backport] WebCryptoAPI fixes #47336
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen approved these changes
@aduh95 aduh95 aduh95 approved these changes
@jasnell jasnell Awaiting requested review from jasnell

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. review wanted PRs that need review. webcrypto Issues and PRs related to the Web Crypto API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@panva @nodejs-github-bot @aduh95 @tniessen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.