GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add getRandomValues return length by MrJithil · Pull Request #46357 · nodejs/node

Conversation

@MrJithil

@MrJithil MrJithil commented Jan 26, 2023

Copy link
Copy Markdown
Member

Added test to check the return results getRandomValues

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Jan 26, 2023
@MrJithil
MrJithil force-pushed the addGetRandomValuesReturnTest branch from e088f32 to e9d9c3f Compare January 26, 2023 03:54
panva
panva reviewed Jan 26, 2023
View reviewed changes
Comment thread test/parallel/test-webcrypto-random.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@panva panva added crypto Issues and PRs related to the crypto subsystem. webcrypto Issues and PRs related to the Web Crypto API. labels Jan 26, 2023
@MrJithil
test: add getRandomValues return length
64e8f23
@MrJithil
MrJithil force-pushed the addGetRandomValuesReturnTest branch from e9d9c3f to 64e8f23 Compare May 13, 2023 04:34
@MrJithil
MrJithil requested a review from panva May 13, 2023 04:34
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 13, 2023
panva
panva approved these changes May 13, 2023
View reviewed changes
@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 13, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 13, 2023
@nodejs-github-bot

nodejs-github-bot commented May 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51771/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51772/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label May 13, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 13, 2023
@nodejs-github-bot
nodejs-github-bot merged commit e74b84e into nodejs:main May 13, 2023
@nodejs-github-bot

nodejs-github-bot commented May 13, 2023

Copy link
Copy Markdown
Collaborator

Landed in e74b84e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 14, 2023
@MrJithil @targos
test: add getRandomValues return length
d039d51 
PR-URL: #46357
Reviewed-By: Filip Skokan <[email protected]>
targos pushed a commit that referenced this pull request May 15, 2023
@MrJithil @targos
test: add getRandomValues return length
bb33c74 
PR-URL: #46357
Reviewed-By: Filip Skokan <[email protected]>
@targos targos mentioned this pull request May 15, 2023
v20.2.0 release proposal #48020
Merged
@danielleadams danielleadams added the backport-requested-v18.x label Jul 5, 2023
@danielleadams

danielleadams commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

This broke the test suite in v18.x-staging - I think it's dependent on another commit that was removed, so it will need to be backported.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. webcrypto Issues and PRs related to the Web Crypto API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@MrJithil @nodejs-github-bot @danielleadams @panva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.