GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — v20.2.0 release proposal by targos · Pull Request #48020 · nodejs/node

Conversation

@targos

@targos targos commented May 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

2023-05-16, Version 20.2.0 (Current), @targos

Notable Changes

  • [c092df9094] - doc: add ovflowd to collaborators (Claudio Wunder) #47844
  • [4197a9a5a0] - (SEMVER-MINOR) http: prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) #47732
  • [c4596b9ce7] - (SEMVER-MINOR) sea: add option to disable the experimental SEA warning (Darshan Sen) #47588
  • [17befe008c] - (SEMVER-MINOR) test_runner: add skip, todo, and only shorthands to test (Chemi Atlow) #47909
  • [a0634d7f89] - (SEMVER-MINOR) url: add value argument to URLSearchParams has and delete methods (Sankalp Shubham) #47885

Commits

  • [456fca0d9c] - bootstrap: initialize per-isolate properties of bindings separately (Joyee Cheung) #47768
  • [d6d12bf978] - bootstrap: log isolate data info in mksnapshot debug logs (Joyee Cheung) #47768
  • [e457d89a1b] - buffer: combine checking range of sourceStart in buf.copy (Deokjin Kim) #47758
  • [00668fcfb4] - child_process: use signal.reason in child process abort (Debadree Chatterjee) #47817
  • [d7993474ea] - crypto: remove default encoding from scrypt (Tobias Nießen) #47943
  • [09fb74a7cc] - crypto: fix webcrypto private/secret import with empty usages (Filip Skokan) #47877
  • [e9c6ee74f3] - crypto: remove default encoding from pbkdf2 (Tobias Nießen) #47869
  • [b7f13a8679] - deps: update simdutf to 3.2.9 (Node.js GitHub Bot) #47983
  • [b16f6da153] - deps: V8: cherry-pick 5f025d1ca2ca (Michaël Zasso) #47610
  • [99f8fcab45] - deps: V8: cherry-pick a8a11a87cb72 (Michaël Zasso) #47610
  • [c2b14b4c78] - deps: update ada to 2.4.0 (Node.js GitHub Bot) #47922
  • [cad42e7a56] - deps: V8: cherry-pick 1b471b796022 (Lu Yahan) #47399
  • [7b2f17ca59] - deps: upgrade npm to 9.6.6 (npm team) #47862
  • [d23b1af562] - deps: update ada to 2.3.1 (Node.js GitHub Bot) #47893
  • [72340c98fb] - dgram: convert macro to template (Tobias Nießen) #47891
  • [9be922892f] - dns: call ada::idna::to_ascii directly from c++ (Yagiz Nizipli) #47920
  • [4a1e97156a] - doc: add missing deprecated blocks to cluster (Tobias Nießen) #47981
  • [13118a19ee] - doc: update description of global (Tobias Nießen) #47969
  • [372796440b] - doc: update measure memory rejection information (Yash Ladha) #41639
  • [7ecc6740e4] - doc: fix broken link to TC39 import attributes proposal (Rich Trott) #47954
  • [b9771c95c7] - doc: fix broken link (Rich Trott) #47953
  • [6f5ba92e61] - doc: remove broken link (Rich Trott) #47942
  • [c9ffc555f1] - doc: document make lint-md-clean (Matteo Collina) #47926
  • [7ed99e8ba5] - doc: mark global object as legacy (Mert Can Altın) #47819
  • [bf39f2d252] - doc: ntfs junction points must link to directories (Ben Noordhuis) #47907
  • [4dfc3890d8] - doc: improve permission.has description (Daeyeon Jeong) #47875
  • [93f1aa2856] - doc: fix params names (Dmitry Semigradsky) #47853
  • [9a362aa2fb] - doc: update supported version of FreeBSD to 12.4 (Michaël Zasso) #47838
  • [89c70dc6e6] - doc: add stability experimental to pm (Rafael Gonzaga) #47890
  • [f96fb2eee7] - doc: swap Matteo with Rafael in the stewards (Rafael Gonzaga) #47841
  • [1666a146e3] - doc: add valgrind suppression details (Kevin Eady) #47760
  • [e53e8231ff] - doc: replace EOL versions in README (Tobias Nießen) #47833
  • [c092df9094] - doc: add ovflowd to collaborators (Claudio Wunder) #47844
  • [f7106765b3] - doc: update BUILDING.md previous versions links (Tobias Nießen) #47835
  • [811b43c215] - doc,test: update the v8.startupSnapshot doc and test the example (Joyee Cheung) #47468
  • [1ec640ac70] - esm: do not use 'beforeExit' on the main thread (Antoine du Hamel) #47964
  • [106dc612d6] - fs: make readdir recursive algorithm iterative (Ethan Arrowood) #47650
  • [a0da2348a8] - fs: move fs_use_promises_symbol to per-isolate symbols (Joyee Cheung) #47768
  • [4197a9a5a0] - (SEMVER-MINOR) http: prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) #47732
  • [a4d6543598] - http2: improve nghttp2 error callback (Tobias Nießen) #47840
  • [a4fed6c580] - lib: update comment (sinkhaha) #47884
  • [fd8bec7b2b] - meta: bump step-security/harden-runner from 2.3.1 to 2.4.0 (Rich Trott) #47980
  • [f5b4b6d5dc] - meta: bump github/codeql-action from 2.3.2 to 2.3.3 (Rich Trott) #47979
  • [c05c0a2359] - meta: bump actions/setup-python from 4.5.0 to 4.6.0 (Rich Trott) #47968
  • [2a3d6d97cb] - meta: add security-wg ping to permission.js (Rafael Gonzaga) #47941
  • [6c158e8dd1] - meta: bump step-security/harden-runner from 2.2.1 to 2.3.1 (dependabot[bot]) #47808
  • [f7a8094d37] - meta: bump actions/setup-python from 4.5.0 to 4.6.0 (dependabot[bot]) #47806
  • [0f58e48792] - meta: bump actions/checkout from 3.3.0 to 3.5.2 (dependabot[bot]) #47805
  • [652b06dd82] - meta: remove extra space in scorecard workflow (Mestery) #47805
  • [9f06eaccaf] - meta: bump github/codeql-action from 2.2.9 to 2.3.2 (dependabot[bot]) #47809
  • [977fd7cf35] - meta: bump codecov/codecov-action from 3.1.1 to 3.1.3 (dependabot[bot]) #47807
  • [c19385c154] - module: refactor to use normalizeRequirableId in the CJS module loader (Darshan Sen) #47896
  • [739113f2fc] - module: block requiring test/reporters without scheme (Moshe Atlow) #47831
  • [f489c6710c] - (NODE-API-SEMVER-MAJOR) node-api: get Node API version used by addon (Vladimir Morozov) #45715
  • [7222f9d74b] - path: indicate index of wrong resolve() parameter (sosoba) #47660
  • [7dd32f1536] - permission: remove unused function declaration (Deokjin Kim) #47957
  • [af86625a05] - permission: resolve reference to absolute path only for fs permission (Daeyeon Jeong) #47930
  • [1625ae11fe] - quic: address recent coverity warning (Michael Dawson) #47753
  • [c4596b9ce7] - (SEMVER-MINOR) sea: add option to disable the experimental SEA warning (Darshan Sen) #47588
  • [1a7fc186bc] - sea: allow requiring core modules with the "node:" prefix (Darshan Sen) #47779
  • [786a1c5398] - src: deduplicate X509Certificate::Fingerprint* (Tobias Nießen) #47978
  • [060c1d502b] - src: stop copying code cache, part 2 (Keyhan Vakil) #47958
  • [1aec718619] - (SEMVER-MINOR) src: add cjs_module_lexer_version base64_version (Jithil P Ponnan) #45629
  • [0c06bfd8dc] - src: move BlobSerializerDeserializer to a separate header file (Darshan Sen) #47933
  • [bd553e7521] - src: rename SKIP_CHECK_SIZE to SKIP_CHECK_STRLEN (Tobias Nießen) #47845
  • [190596c189] - src: register external references for source code (Keyhan Vakil) #47055
  • [4293cc47f4] - src: support V8 experimental shared values in messaging (Shu-yu Guo) #47706
  • [9bc5d78f0c] - src: register ext reference for Fingerprint512 (Tobias Nießen) #47892
  • [a11507e23b] - src: stop copying code cache (Keyhan Vakil) #47144
  • [515c9b8de6] - src: clarify the parameter name in Permission::Apply (Daeyeon Jeong) #47874
  • [c4217613f5] - src: fix creating an ArrayBuffer from a Blob created with openAsBlob (Daeyeon Jeong) #47691
  • [4bc17fd67b] - src: avoid strcmp() with Utf8Value (Tobias Nießen) #47827
  • [d358317f70] - src: get binding data store directly from the realm (Joyee Cheung) #47437
  • [b04d51a0b5] - src: prefer data accessor of string and vector (Mohammed Keyvanzadeh) #47750
  • [2952cc576c] - src: add per-isolate SetFastMethod and Set[Fast]MethodNoSideEffect (Joyee Cheung) #47768
  • [010d2ecf94] - test: mark test-esm-loader-http-imports as flaky (Tobias Nießen) #47987
  • [bb33c74c07] - test: add getRandomValues return length (Jithil P Ponnan) #46357
  • [6e019586f7] - test: unskip negative-settimeout.any.js WPT (Filip Skokan) #47946
  • [8f547afe5f] - test: use appropriate usages for a negative import test (Filip Skokan) #47878
  • [7e34f77518] - test: fix webcrypto wrap unwrap tests (Filip Skokan) #47876
  • [30f4f35244] - test: fix output tests when path includes node version (Moshe Atlow) #47843
  • [54607bfd68] - test: reduce WPT concurrency (Filip Skokan) #47834
  • [17945a2495] - test: migrate a pseudo_tty test to use assertSnapshot (Moshe Atlow) #47803
  • [c9233679e8] - test: fix WPT state when process exits but workers are still running (Filip Skokan) #47826
  • [34bfb69b5b] - test: migrate message tests to use assertSnapshot (Moshe Atlow) #47498
  • [d25c785c2a] - test: allow SIGBUS in signal-handler abort test (Michaël Zasso) #47851
  • [aa2c7e00d7] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #47921
  • [da27542058] - test_runner: use v8.serialize instead of TAP (Moshe Atlow) #47867
  • [17befe008c] - (SEMVER-MINOR) test_runner: add shorthands to test (Chemi Atlow) #47909
  • [42db1d50a0] - test_runner: fix ordering of test hooks (Phil Nash) #47931
  • [d81c54e3a8] - test_runner: omit inaccessible files from coverage (Colin Ihrig) #47850
  • [a4e261e910] - tools: debug log for nghttp3 (Marco Ippolito) #47992
  • [f6ff318d4c] - tools: automate icu-small update (Marco Ippolito) #47727
  • [706c305381] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #47903
  • [e22c686ca9] - tools: update eslint to 8.40.0 (Node.js GitHub Bot) #47906
  • [36f7cfac93] - tools: update eslint to 8.39.0 (Node.js GitHub Bot) #47789
  • [7323902a40] - tools: fix jsdoc lint (Moshe Atlow) #47789
  • [a0634d7f89] - (SEMVER-MINOR) url: add value argument to has and delete methods (Sankalp Shubham) #47885
  • [1b06c1e003] - url: improve isURL detection (Yagiz Nizipli) #47886
  • [2bd869d20c] - vm: fix crash when setting __proto__ on context's globalThis (Feng Yu) #47939
  • [e6685f9e82] - vm,lib: refactor microtaskQueue assignment logic (Khaidi Chu) #47765
  • [47fea13dac] - worker: support more cases when (de)serializing errors (Moshe Atlow) #47925
  • [6f3876c035] - worker: use snapshot in workers spawned by workers (Joyee Cheung) #47731

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss, debadree25, sankalp1999, and tonivj5 reacted with thumbs up emoji egoroof, bricss, tonivj5, and atlowChemi reacted with hooray emoji bricss, debadree25, and tonivj5 reacted with heart emoji bricss, TomasHubelbauer, tonivj5, jaydenseric, and atlowChemi reacted with rocket emoji
All reactions
  • 👍 4 reactions
  • 🎉 4 reactions
  • ❤️ 3 reactions
  • 🚀 5 reactions
targos and others added 30 commits May 5, 2023 13:05
@targos
test: allow SIGBUS in signal-handler abort test
d25c785
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: #47851
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@MoLow @targos
test: migrate message tests to use assertSnapshot
34bfb69
PR-URL: #47498
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow @targos
tools: fix jsdoc lint
7323902
PR-URL: #47789
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mestery <[email protected]>
@nodejs-github-bot @targos
tools: update eslint to 8.39.0
36f7cfa
PR-URL: #47789
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mestery <[email protected]>
@panva @targos
test: fix WPT state when process exits but workers are still running
c923367
PR-URL: #47826
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@tniessen @targos
doc: update BUILDING.md previous versions links
f710676
Remove EOL release lines and add missing supported release
lines.

PR-URL: #47835
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
@joyeecheung @targos
doc,test: update the v8.startupSnapshot doc and test the example
811b43c
The API is now available to user-land run-time snapshots. So update
the example. This also makes the intention of the examples a bit
clearer and test it in our test suite.

PR-URL: #47468
Reviewed-By: Chengzhong Wu <[email protected]>
@joyeecheung @targos
src: add per-isolate SetFastMethod and Set[Fast]MethodNoSideEffect
2952cc5
PR-URL: #47768
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@joyeecheung @targos
bootstrap: log isolate data info in mksnapshot debug logs
d6d12bf
PR-URL: #47768
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@joyeecheung @targos
fs: move fs_use_promises_symbol to per-isolate symbols
a0da234
PR-URL: #47768
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@joyeecheung @targos
bootstrap: initialize per-isolate properties of bindings separately
456fca0
This patch moves the initialization of per-isolate properties of
the bindings that are in the embedded snapshot separate from the
initialization of their per-context properties. This is necessary
for workers to share the isolate snapshot with the main thread
and deserialize these properties instead of creating them from
scratch.

PR-URL: #47768
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@VoltrexKeyva @targos
src: prefer data accessor of string and vector
b04d51a
The pattern of getting the address of the element at index 0 of a
container is generally used to materialize a pointer to the backing
data of a container, however `std::string` and `std::vector`
provide a `data()` accessor to retrieve the data pointer which
should be preferred.

This also ensures that in the case that the container is empty, the
data pointer access does not perform an errant memory access.

PR-URL: #47750
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@ovflowd @targos
doc: add ovflowd to collaborators
c092df9
PR-URL: #47844
Fixes: #47672
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@dependabot @targos
meta: bump codecov/codecov-action from 3.1.1 to 3.1.3
977fd7c
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.1 to 3.1.3.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@d9f34f8...894ff02)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #47807
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@dependabot @targos
meta: bump github/codeql-action from 2.2.9 to 2.3.2
9f06eac
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.9 to 2.3.2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@04df126...f3feb00)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #47809
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@tniessen @targos
doc: replace EOL versions in README
e53e823
PR-URL: #47833
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MoLow @targos
test: migrate a pseudo_tty test to use assertSnapshot
17945a2
PR-URL: #47803
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@KevinEady @targos
doc: add valgrind suppression details
1666a14
PR-URL: #47760
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@joyeecheung @targos
worker: use snapshot in workers spawned by workers
6f3876c
Previously we didn't pass the snapshot data down to the isolate
data of workers so workers spawned by workers won't use the
snapshot. Fixes it by passing the snapshot data down.

PR-URL: #47731
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@sosoba @targos
path: indicate index of wrong resolve() parameter
7222f9d
PR-URL: #47660
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
@RaisinTen @targos
sea: allow requiring core modules with the "node:" prefix
1a7fc18
Previously, the `require()` function exposed to the embedded SEA code
was calling the internal `require()` function if the module name
belonged to the list of public core modules but the internal `require()`
function does not support loading modules with the "node:" prefix, so
this change forwards the calls to another `require()` function that
supports this.

Fixes: nodejs/single-executable#69
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #47779
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@RaisinTen @targos
sea: add option to disable the experimental SEA warning
c4596b9
Refs: nodejs/single-executable#60
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #47588
Fixes: #47741
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@joyeecheung @targos
src: get binding data store directly from the realm
d358317
We now store the binding data store in the realm and invoke
`Realm::AddBindingData` to add the binding data, so there is no
need to get a reference to the binding data store from the context
now, we can just get the reference from the realm.

PR-URL: #47437
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mhdawson @targos
quic: address recent coverity warning
1625ae1
Address coverity warning about uninitialized value

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #47753
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@tniessen @targos
src: avoid strcmp() with Utf8Value
4bc17fd
Having Utf8Value::operator==() without operator!=() is awkward in C++17,
so add the negated equality operator. Then, use either instead of
strcmp() where appropriate.

PR-URL: #47827
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
@daeyeon @targos
src: fix creating an ArrayBuffer from a Blob created with openAsBlob
c421761
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #47691
Fixes: #47683
Reviewed-By: James M Snell <[email protected]>
@MoLow @targos
module: block requiring test/reporters without scheme
739113f
PR-URL: #47831
Fixes: #47828
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
@panva @targos
test: reduce WPT concurrency
54607bf
PR-URL: #47834
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@tniessen @targos
http2: improve nghttp2 error callback
a4d6543
The http2 implementation uses the deprecated function
nghttp2_session_callbacks_set_error_callback, which does not supply an
error code but only an error message. This so far forced node's error
callback to rely on the error message in order to distinguish between
different errors, which is fragile and inefficient.

Use the newer nghttp2_session_callbacks_set_error_callback2 function
instead, which is not deprecated and which provides the exact error code
to node's error callback.

PR-URL: #47840
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@vmoroz @targos
node-api: get Node API version used by addon
f489c67
PR-URL: #45715
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. v20.x labels May 15, 2023
@nodejs-github-bot

nodejs-github-bot commented May 15, 2023 •
edited by targos
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51818/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5364/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3163/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos targos added release Issues and PRs related to Node.js releases. and removed doc Issues and PRs related to Node.js documentation. build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. labels May 15, 2023
RafaelGSS
RafaelGSS approved these changes May 15, 2023
View reviewed changes
tniessen
tniessen approved these changes May 15, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request May 16, 2023
CI Reliability 2023-05-16 nodejs/reliability#567
Open
19 tasks
@nodejs-github-bot

nodejs-github-bot commented May 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51825/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented May 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51826/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95
aduh95 approved these changes May 16, 2023
View reviewed changes
@targos

targos commented May 16, 2023

Copy link
Copy Markdown
Member Author

Release build is done. I'll promote in a few hours.

tniessen, debadree25, TomasHubelbauer, and bricss reacted with heart emoji MoLow, debadree25, TomasHubelbauer, and bricss reacted with rocket emoji
All reactions
  • ❤️ 4 reactions
  • 🚀 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos
targos merged commit 258e9e7 into v20.x May 16, 2023
targos added a commit that referenced this pull request May 16, 2023
@targos
Working on v20.2.1
ad2c05b
PR-URL: #48020
@targos
targos deleted the v20.2.0-proposal branch May 16, 2023 12:39
targos added a commit that referenced this pull request May 16, 2023
@targos
2023-05-16, Version 20.2.0 (Current)
c2ca429
Notable changes:

doc:
  * add ovflowd to collaborators (Claudio Wunder) #47844
http:
  * (SEMVER-MINOR) prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) #47732
sea:
  * (SEMVER-MINOR) add option to disable the experimental SEA warning (Darshan Sen) #47588
test_runner:
  * (SEMVER-MINOR) add `skip`, `todo`, and `only` shorthands to `test` (Chemi Atlow) #47909
url:
  * (SEMVER-MINOR) add value argument to `URLSearchParams` `has` and `delete` methods (Sankalp Shubham) #47885

PR-URL: #48020
@targos targos mentioned this pull request May 16, 2023
Blog: v20.2.0 release post nodejs/nodejs.org#5379
Merged
targos added a commit to targos/nodejs.org that referenced this pull request May 16, 2023
@targos
Blog: v20.2.0 release post
c1e9b78
Refs: nodejs/node#48020
targos added a commit to nodejs/nodejs.org that referenced this pull request May 16, 2023
@targos
Blog: v20.2.0 release post (#5379)
b83f428
Refs: nodejs/node#48020
This was referenced May 17, 2023
CI Reliability 2023-05-17 nodejs/reliability#568
Open
CI Reliability 2023-05-18 nodejs/reliability#569
Open
CI Reliability 2023-05-19 nodejs/reliability#570
Open
CI Reliability 2023-05-20 nodejs/reliability#571
Open
kxxt added a commit to kxxt/archriscv-packages that referenced this pull request May 20, 2023
@kxxt
upgpatch: nodejs
79fee03
Upstream landed the V8 jit fix in v20.2.0

See also:

- nodejs/node#47399
- nodejs/node#48020
@kxxt kxxt mentioned this pull request May 20, 2023
upgpatch: nodejs felixonmars/archriscv-packages#2651
Merged
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request May 20, 2023
@kxxt @felixonmars
upgpatch: nodejs
58d45bf
Upstream landed the V8 jit fix in v20.2.0

See also:

- nodejs/node#47399
- nodejs/node#48020
This was referenced May 21, 2023
CI Reliability 2023-05-21 nodejs/reliability#572
Open
CI Reliability 2023-05-22 nodejs/reliability#573
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

release Issues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@targos @nodejs-github-bot @Trott @tniessen @aduh95 @RafaelGSS @prok-collab @MoLow @panva @joyeecheung @VoltrexKeyva @ovflowd @KevinEady @sosoba @RaisinTen @mhdawson @daeyeon @vmoroz @Semigradsky @npm-cli-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.