GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64 by shipujin · Pull Request #46401 · nodejs/node

Conversation

@shipujin

@shipujin shipujin commented Jan 29, 2023

Copy link
Copy Markdown
Member

Add linux64-loongarch64 into Makefile
And run make

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hankinsea and shipujin reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels Jan 29, 2023
@shipujin

shipujin commented Jan 29, 2023

Copy link
Copy Markdown
Member Author

Hello, I add LoongArch target to openssl/openssl [3.0]:openssl/openssl#18807
Add loongarch64 target: quictls/openssl: quictls/openssl@c09ce49

nodejs/deps/openssl: https://github.com/nodejs/node/blob/main/deps/openssl/openssl/Configurations/10-main.conf#L821
thanks~
hankinsea reacted with thumbs up emoji shipujin reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnoordhuis
bnoordhuis approved these changes Jan 29, 2023
View reviewed changes

@bnoordhuis bnoordhuis left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Not a blocker for this PR but I notice files in e.g. deps/openssl/config/archs/*/no-asm/providers are all exactly the same.

We should try to deduplicate those because they add up to substantial source code bloat, roughly 1.9 MB * number of targets. It's 38 MB now and this PR brings it to 40 MB.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 29, 2023
jasnell
jasnell approved these changes Jan 29, 2023
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49230/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis bnoordhuis mentioned this pull request Feb 1, 2023
include/node/openssl/archs/ has ~50MB of (I hope?) unused headers #46451
Closed
@shipujin
shipujin force-pushed the main branch from 7598eb7 to a58545a Compare February 6, 2023 06:38
@shipujin Shi Pujin
deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64
17a12ef
@shipujin
shipujin force-pushed the main branch from a58545a to 17a12ef Compare May 4, 2023 04:32
@shipujin

shipujin commented May 4, 2023

Copy link
Copy Markdown
Member Author

Update
shipujin reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson
mhdawson approved these changes May 4, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shipujin reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 4, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 4, 2023
@nodejs-github-bot

nodejs-github-bot commented May 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51635/
shipujin reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced May 5, 2023
CI Reliability 2023-05-05 nodejs/reliability#556
Open
CI Reliability 2023-05-06 nodejs/reliability#557
Open
@nodejs-github-bot

nodejs-github-bot commented May 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51686/
shipujin reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced May 7, 2023
CI Reliability 2023-05-07 nodejs/reliability#558
Open
CI Reliability 2023-05-08 nodejs/reliability#559
Open
CI Reliability 2023-05-09 nodejs/reliability#560
Open
CI Reliability 2023-05-10 nodejs/reliability#561
Open
mhdawson pushed a commit that referenced this pull request May 16, 2023
@shipujin @mhdawson
deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64
a51491a 
PR-URL: #46401
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@mhdawson

mhdawson commented May 16, 2023

Copy link
Copy Markdown
Member

Landed in a51491a
shipujin reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this May 16, 2023
@shipujin shipujin mentioned this pull request May 23, 2023
[v18.x backport] deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64 #48135
Closed
targos pushed a commit that referenced this pull request May 30, 2023
@shipujin @targos
deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64
c6a7525 
PR-URL: #46401
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
@danielleadams danielleadams added the backport-requested-v18.x label Jun 29, 2023
@shipujin

shipujin commented Jul 14, 2023

Copy link
Copy Markdown
Member Author

[v18.x backport] deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64 #48135
shipujin reacted with laugh emoji shipujin reacted with hooray emoji
All reactions
  • 😄 1 reaction
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno ruyadorno added backport-open-v18.x and removed backport-requested-v18.x labels Aug 15, 2023
ruyadorno pushed a commit that referenced this pull request Aug 16, 2023
Shi Pujin @ruyadorno
deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64
f4617a4 
Add linux64-loongarch64 into Makefile
And run make

PR-URL: #46401
Backport-PR-URL: #48135
Reviewed-By: Ben Noordhuis [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Michael Dawson [email protected]
@ruyadorno ruyadorno added backported-to-v18.x and removed backport-open-v18.x labels Aug 16, 2023
@ruyadorno ruyadorno mentioned this pull request Aug 17, 2023
v18.18.0 proposal #49220
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@jasnell jasnell jasnell approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@shipujin @nodejs-github-bot @mhdawson @bnoordhuis @jasnell @ruyadorno @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.