GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — v20.3.0 release proposal by targos · Pull Request #48332 · nodejs/node

Conversation

@targos

@targos targos commented Jun 4, 2023 •
edited by RafaelGSS
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

2023-06-08, Version 20.3.0 (Current), @targos

Notable Changes

  • [bfcb3d1d9a] - deps: upgrade to libuv 1.45.0, including significant performance improvements to file system operations on Linux (Santiago Gimeno) #48078
  • [5094d1b292] - doc: add Ruy Adorno to list of TSC members (Michael Dawson) #48172
  • [2f5dbca690] - doc: mark Node.js 14 as End-of-Life (Richard Lau) #48023
  • [b1828b325e] - (SEMVER-MINOR) lib: implement AbortSignal.any() (Chemi Atlow) #47821
  • [f380953103] - module: change default resolver to not throw on unknown scheme (Gil Tayar) #47824
  • [a94f87ed99] - (SEMVER-MINOR) node-api: define version 9 (Chengzhong Wu) #48151
  • [9e2b13dfa7] - stream: deprecate asIndexedPairs (Chemi Atlow) #48102

Commits

  • [35c96156d1] - benchmark: use cluster.isPrimary instead of cluster.isMaster (Deokjin Kim) #48002
  • [3e6e3abf32] - bootstrap: throw ERR_NOT_SUPPORTED_IN_SNAPSHOT in unsupported operation (Joyee Cheung) #47887
  • [c480559347] - bootstrap: put is_building_snapshot state in IsolateData (Joyee Cheung) #47887
  • [50c0a15535] - build: set v8_enable_webassembly=false when lite mode is enabled (Cheng Shao) #48248
  • [4562805cf6] - build: speed up compilation of mksnapshot output (Keyhan Vakil) #48162
  • [8b89f13933] - build: add action to close stale PRs (Michael Dawson) #48051
  • [5d92202220] - build: replace js2c.py with js2c.cc (Joyee Cheung) #46997
  • [6cf2adc36e] - cluster: use ObjectPrototypeHasOwnProperty (Daeyeon Jeong) #48141
  • [f564b03c38] - crypto: use openssl's own memory BIOs in crypto_context.cc (GauriSpears) #47160
  • [ac8dd61fc3] - crypto: remove default encoding from cipher (Tobias Nießen) #47998
  • [15c2de4407] - crypto: fix setEngine() when OPENSSL_NO_ENGINE set (Tobias Nießen) #47977
  • [9e2dd5b5e2] - deps: update zlib to 337322d (Node.js GitHub Bot) #48218
  • [bfcb3d1d9a] - deps: upgrade to libuv 1.45.0 (Santiago Gimeno) #48078
  • [13930f092f] - deps: update ada to 2.5.0 (Node.js GitHub Bot) #48223
  • [3047caebec] - deps: set CARES_RANDOM_FILE for c-ares (Richard Lau) #48156
  • [0db79a0872] - deps: update histogram 0.11.8 (Marco Ippolito) #47742
  • [99af6716f5] - deps: update histogram to 0.11.7 (Marco Ippolito) #47742
  • [d4922bc985] - deps: update c-ares to 1.19.1 (Node.js GitHub Bot) #48115
  • [f6ccdb289f] - deps: update simdutf to 3.2.12 (Node.js GitHub Bot) #48118
  • [3ed0afc778] - deps: update minimatch to 9.0.1 (Node.js GitHub Bot) #48094
  • [df7540fb73] - deps: update ada to 2.4.2 (Node.js GitHub Bot) #48092
  • [07df5c48e8] - deps: update corepack to 0.18.0 (Node.js GitHub Bot) #48091
  • [d95a5bb559] - deps: update uvwasi to 0.0.18 (Node.js GitHub Bot) #47866
  • [443477e041] - deps: update uvwasi to 0.0.17 (Node.js GitHub Bot) #47866
  • [03f67d6d6d] - deps: upgrade npm to 9.6.7 (npm team) #48062
  • [d3e3a911fd] - deps: update nghttp2 to 1.53.0 (Node.js GitHub Bot) #47997
  • [f7c4daaf67] - deps: update ada to 2.4.1 (Node.js GitHub Bot) #48036
  • [c6a752560d] - deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64 (Shi Pujin) #46401
  • [d194241716] - deps: update undici to 5.22.1 (Node.js GitHub Bot) #47994
  • [02e919f4a2] - deps,test: update postject to 1.0.0-alpha.6 (Node.js GitHub Bot) #48072
  • [2c19f596ad] - doc: clarify array args to Buffer.from() (Bryan English) #48274
  • [d681e5f456] - doc: document watch option for node:test run() (Moshe Atlow) #48256
  • [96e54ddbca] - doc: reserve 117 for Electron 26 (Calvin) #48245
  • [9aff8c7818] - doc: update documentation for FIPS support (Richard Lau) #48194
  • [8c5338648f] - doc: improve the documentation of the stdio option (Kumar Arnav) #48110
  • [11918d705f] - doc: update Buffer.allocUnsafe description (sinkhaha) #48183
  • [2b51ee5e22] - doc: update codeowners with website team (Claudio Wunder) #48197
  • [360df25d04] - doc: fix broken link to new folder doc/contributing/maintaining (Andrea Fassina) #48205
  • [13e95e21a4] - doc: add atlowChemi to triagers (Chemi Atlow) #48104
  • [5f83ce530f] - doc: fix typo in readline completer function section (Vadym) #48188
  • [3c82165d27] - doc: remove broken link for keygen (Rich Trott) #48176
  • [0ca90a1e6d] - doc: add auto intrinsic height to prevent jitter/flicker (Daniel Holbert) #48195
  • [f117855092] - doc: add version info on the SEA docs (Antoine du Hamel) #48173
  • [5094d1b292] - doc: add Ruy to list of TSC members (Michael Dawson) #48172
  • [39d8140227] - doc: update socket.remote* properties documentation (Saba Kharanauli) #48139
  • [5497c13efe] - doc: update outdated section on TLSv1.3-PSK (Tobias Nießen) #48123
  • [281dfaf727] - doc: improve HMAC key recommendations (Tobias Nießen) #48121
  • [bd311b6c70] - doc: clarify mkdir() recursive behavior (Stephen Odogwu) #48109
  • [5b061c8922] - doc: fix typo in crypto legacy streams API section (Tobias Nießen) #48122
  • [10ccb2bd81] - doc: update SEA source link (Rich Trott) #48080
  • [415bf7f532] - doc: clarify tty.isRaw (Roberto Vidal) #48055
  • [0ac4b33c76] - doc: correct line break for Windows terminals (Alex Schwartz) #48083
  • [f30ba5c320] - doc: fix Windows code snippet tags (Antoine du Hamel) #48100
  • [12fef9b68c] - doc: harmonize fenced code snippet flags (Antoine du Hamel) #48082
  • [13f163eace] - doc: use secure key length for HMAC generateKey (Tobias Nießen) #48052
  • [1e3e7c9f33] - doc: update broken EVP_BytesToKey link (Rich Trott) #48064
  • [5917ba1838] - doc: update broken spkac link (Rich Trott) #48063
  • [0e4a3b7db1] - doc: document node-api version process (Chengzhong Wu) #47972
  • [85bbaa94ea] - doc: update process.versions properties (Saba Kharanauli) #48019
  • [7660eb591a] - doc: fix typo in binding functions (Deokjin Kim) #48003
  • [2f5dbca690] - doc: mark Node.js 14 as End-of-Life (Richard Lau) #48023
  • [3b94a739f2] - doc: clarify CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED (Tobias Nießen) #47976
  • [9e381cfa89] - doc: add heading for permission model limitations (Tobias Nießen) #47989
  • [802db923e0] - doc,vm: clarify usage of cachedData in vm.compileFunction() (Darshan Sen) #48193
  • [11a3434810] - esm: remove support for arrays in import internal method (Antoine du Hamel) #48296
  • [3b00f3afef] - esm: handle globalPreload hook returning a nullish value (Antoine du Hamel) #48249
  • [3c7846d7e1] - esm: handle more error types thrown from the loader thread (Antoine du Hamel) #48247
  • [60ce2bcabc] - http: send implicit headers on HEAD with no body (Matteo Collina) #48108
  • [72de4e7170] - lib: do not disable linter for entire files (Antoine du Hamel) #48299
  • [10cc60fc91] - lib: use existing isWindows variable (sinkhaha) #48134
  • [a90010aae9] - lib: support FORCE_COLOR for non TTY streams (Moshe Atlow) #48034
  • [b1828b325e] - (SEMVER-MINOR) lib: implement AbortSignal.any() (Chemi Atlow) #47821
  • [8f1b86961f] - meta: bump github/codeql-action from 2.3.3 to 2.3.6 (dependabot[bot]) #48287
  • [1b87ccdf70] - meta: bump actions/setup-python from 4.6.0 to 4.6.1 (dependabot[bot]) #48286
  • [10715aea26] - meta: bump codecov/codecov-action from 3.1.3 to 3.1.4 (dependabot[bot]) #48285
  • [79f73778ab] - meta: remove dont-land-on-v14 auto labeling (Shrujal Shah) #48031
  • [9c5711f3ea] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #48010
  • [6d6bf3ee52] - module: reduce the number of URL initializations (Yagiz Nizipli) #48272
  • [f380953103] - module: change default resolver to not throw on unknown scheme (Gil Tayar) #47824
  • [950185b0c0] - net: fix address iteration with autoSelectFamily (Fedor Indutny) #48258
  • [5ddca72e62] - net: fix family autoselection SSL connection handling (Paolo Insogna) #48189
  • [750e53ca3c] - net: fix family autoselection timeout handling (Paolo Insogna) #47860
  • [a94f87ed99] - (SEMVER-MINOR) node-api: define version 9 (Chengzhong Wu) #48151
  • [e834979818] - node-api: add status napi_cannot_run_js (Gabriel Schulhof) #47986
  • [eafe0c3ec6] - node-api: napi_ref on all types is experimental (Vladimir Morozov) #47975
  • [9a034746f5] - src: add Realm document in the src README.md (Chengzhong Wu) #47932
  • [b8f4070f71] - src: check node_extra_ca_certs after openssl cfg (Raghu Saxena) #48159
  • [0347a18056] - src: include missing header in node_sea.h (Joyee Cheung) #48152
  • [45c3782c20] - src: remove INT_MAX asserts in SecretKeyGenTraits (Tobias Nießen) #48053
  • [b25e7045ad] - src: avoid prototype access in binding templates (Joyee Cheung) #47913
  • [33aa373eec] - src: use Blob{Des|S}erializer for SEA blobs (Joyee Cheung) #47962
  • [9e2b13dfa7] - stream: deprecate asIndexedPairs (Chemi Atlow) #48102
  • [96c323dee2] - test: mark test-child-process-pipe-dataflow as flaky (Moshe Atlow) #48334
  • [9875885357] - test: adapt tests for OpenSSL 3.1 (OttoHollmann) #47859
  • [3440d7c6bf] - test: unflake test-vm-timeout-escape-nexttick (Santiago Gimeno) #48078
  • [215b2bc72c] - test: fix zlib version regex (Luigi Pinca) #48227
  • [e12ee59d26] - test: use lower security level in s_client (Luigi Pinca) #48192
  • [1dabc7390c] - Revert "test: unskip negative-settimeout.any.js WPT" (Filip Skokan) #48182
  • [c1c4796a86] - test: mark test_cannot_run_js as flaky (Keyhan Vakil) #48181
  • [8c49d74002] - test: fix flaky test-runner-watch-mode (Moshe Atlow) #48144
  • [6388766862] - test: skip test-http-pipeline-flood on IBM i (Abdirahim Musse) #48048
  • [8d2a3b1952] - test: ignore helper files in WPTs (Filip Skokan) #48079
  • [7a96d825fd] - test: move test-cluster-primary-error flaky test (Yagiz Nizipli) #48039
  • [a80dd3a8b3] - test: fix suite signal (Benjamin Gruenbaum) #47800
  • [a41cfd183f] - test: fix parsing test flags (Daeyeon Jeong) #48012
  • [4d4e506f2b] - test,doc,sea: run SEA tests on ppc64 (Darshan Sen) #48111
  • [44411fc40c] - test_runner: apply runOnly on suites (Moshe Atlow) #48279
  • [3f259b7a30] - test_runner: emit test:watch:drained event (Moshe Atlow) #48259
  • [c9f8e8c562] - test_runner: stop watch mode when abortSignal aborted (Moshe Atlow) #48259
  • [f3268d64cb] - test_runner: fix global after hook (Moshe Atlow) #48231
  • [15336c3139] - test_runner: remove redundant check from coverage (Colin Ihrig) #48070
  • [750d3e8606] - test_runner: pass FORCE_COLOR to child process (Moshe Atlow) #48057
  • [3278542243] - test_runner: dont split lines on test:stdout (Moshe Atlow) #48057
  • [027c531766] - test_runner: fix test deserialize edge cases (Moshe Atlow) #48106
  • [2b797a6d39] - test_runner: delegate stderr and stdout formatting to reporter (Shiba) #48045
  • [23d310bee8] - test_runner: display dot report as wide as the terminal width (Raz Luvaton) #48038
  • [fd2620dcf1] - tls: reapply servername on happy eyeballs connect (Fedor Indutny) #48255
  • [62f847d0b3] - tools: update rollup lint-md-dependencies (Node.js GitHub Bot) #48329
  • [3e97826a66] - Revert "tools: open issue when update workflow fails" (Marco Ippolito) #48312
  • [5f08bfe35f] - tools: don't gitignore base64 config.h (Ben Noordhuis) #48174
  • [ded0e2d755] - tools: update LICENSE and license-builder.sh (Santiago Gimeno) #48078
  • [07aa264366] - tools: automate histogram update (Marco Ippolito) #48171
  • [1416b75eaa] - tools: use shasum instead of sha256sum (Luigi Pinca) #48229
  • [b81e9d9b7b] - tools: harmonize dep_updaters scripts (Antoine du Hamel) #48201
  • [a60bc41e53] - tools: deps update authenticate github api request (Andrea Fassina) #48200
  • [7478ed014e] - tools: order dependency jobs alphabetically (Luca) #48184
  • [568a705799] - tools: refactor v8_pch config (Michaël Zasso) #47364
  • [801573ba46] - tools: log and verify sha256sum (Andrea Fassina) #48088
  • [db62325e18] - tools: open issue when update workflow fails (Marco Ippolito) #48018
  • [ad8a68856d] - tools: alphabetize CODEOWNERS (Rich Trott) #48124
  • [4cf5a9edaf] - tools: use latest upstream commit for zlib updates (Andrea Fassina) #48054
  • [8d93af381b] - tools: add security-wg as dep updaters owner (Marco Ippolito) #48113
  • [5325be1d99] - tools: port js2c.py to C++ (Joyee Cheung) #46997
  • [6c60d90277] - tools: fix race condition when npm installing (Tobias Nießen) #48101
  • [0ab840a58f] - tools: refloat 7 Node.js patches to cpplint.py (Rich Trott) #48098
  • [a298193378] - tools: update cpplint to 1.6.1 (Yagiz Nizipli) #48098
  • [f6725751b7] - tools: update eslint to 8.41.0 (Node.js GitHub Bot) #48097
  • [6539361f4e] - tools: update lint-md-dependencies (Node.js GitHub Bot) #48096
  • [5d94dbb951] - tools: update doc to [email protected] (Node.js GitHub Bot) #48095
  • [2226088048] - tools: add debug logs (Marco Ippolito) #48060
  • [0c8c383583] - tools: fix zconf.h path (Luigi Pinca) #48089
  • [6adaf4c648] - tools: update remark-preset-lint-node to 4.0.0 (Node.js GitHub Bot) #47995
  • [92b3334231] - url: clean vertical alignment of docs (Robin Ury) #48037
  • [ebb6536775] - url: call ada::can_parse directly (Yagiz Nizipli) #47919
  • [ed4514294a] - vm: properly handle defining symbol props (Nicolas DUBIEN) #47572

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss, debadree25, theoludwig, lin72h, and marco-ippolito reacted with thumbs up emoji bricss, atlowChemi, and marco-ippolito reacted with hooray emoji bricss, ruyadorno, ckcr4lyf, and marco-ippolito reacted with heart emoji bricss, lin72h, and marco-ippolito reacted with rocket emoji
All reactions
  • 👍 5 reactions
  • 🎉 3 reactions
  • ❤️ 4 reactions
  • 🚀 3 reactions
tniessen and others added 30 commits May 30, 2023 11:36
@tniessen @targos
crypto: fix setEngine() when OPENSSL_NO_ENGINE set
15c2de4
When OpenSSL is configured with OPENSSL_NO_ENGINE, setEngine() currently
throws an internal error because the C++ binding does not export the
relevant function, which causes _setEngine() to be undefined within JS.

Instead, match the behavior of tls/secure-context.js and throw the
existing error code ERR_CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED when OpenSSL
has been configured with OPENSSL_NO_ENGINE.

PR-URL: #47977
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@tniessen @targos
doc: add heading for permission model limitations
9e381cf
These limitations are not specific to the file system, so they should
not be listed in the "File System Permissions" section.

PR-URL: #47989
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@tniessen @targos
crypto: remove default encoding from cipher
ac8dd61
Refs: #47182
PR-URL: #47998
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@tniessen @targos
doc: clarify CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED
3b94a73
The error is not necessarily due to a client certificate engine. For
example, the `privateKeyEngine` option might just as well cause this
error and is independent of the client certificate.

Also mention that this is likely due to a compile-time option of OpenSSL
itself and not due to any particular engine.

PR-URL: #47976
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@richardlau @targos
doc: mark Node.js 14 as End-of-Life
2f5dbca
PR-URL: #48023
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@deokjinkim @targos
doc: fix typo in binding functions
7660eb5
According to usage(node::util::RegisterExternalReferences) of
below line, namespace has to be `util`(not `utils`).

PR-URL: #48003
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@nodejs-github-bot @targos
deps: update undici to 5.22.1
d194241
PR-URL: #47994
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
@shipujin @targos
deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64
c6a7525
PR-URL: #46401
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@nodejs-github-bot @targos
deps: update ada to 2.4.1
f7c4daa
PR-URL: #48036
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@nodejs-github-bot @targos
meta: move one or more collaborators to emeritus
9c5711f
PR-URL: #48010
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@nodejs-github-bot @targos
tools: update remark-preset-lint-node to 4.0.0
6adaf4c
PR-URL: #47995
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@deokjinkim @targos
benchmark: use cluster.isPrimary instead of cluster.isMaster
35c9615
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary`
for benchmark.

Refs: #47981
PR-URL: #48002
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@daeyeon @targos
test: fix parsing test flags
a41cfd1
This removes replacing `_` with `-` in the flags defined.

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #48012
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@benjamingr @targos
test: fix suite signal
a80dd3a
PR-URL: #47800
Fixes: #47882
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@Basa198 @targos
doc: update process.versions properties
85bbaa9
Fixes: #48016
PR-URL: #48019
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@anonrig @targos
test: move test-cluster-primary-error flaky test
7a96d82
PR-URL: #48039
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
@atlowChemi @targos
lib: implement AbortSignal.any()
b1828b3
PR-URL: #47821
Fixes: #47811
Refs: whatwg/dom#1152
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@shrujalshah28 @targos
meta: remove dont-land-on-v14 auto labeling
79f7377
PR-URL: #48031
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MoLow @targos
lib: support FORCE_COLOR for non TTY streams
a90010a
PR-URL: #48034
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@nodejs-github-bot @targos
deps: update nghttp2 to 1.53.0
d3e3a91
PR-URL: #47997
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@GauriSpears @targos
crypto: use openssl's own memory BIOs in crypto_context.cc
f564b03
NodeBIO's memory buffer structure does not support BIO_C_FILE_SEEK and B
IO_C_FILE_TELL. This prevents OpenSSL PEM_read_bio_PrivateKey from readi
ng some private keys. So I switched to OpenSSL'w own protected memory bu
ffers.

Fixes: #47008
PR-URL: #47160
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@anonrig @targos
url: call ada::can_parse directly
ebb6536
PR-URL: #47919
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@vmoroz @targos
node-api: napi_ref on all types is experimental
eafe0c3
PR-URL: #47975
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@binury @targos
url: clean vertical alignment of docs
92b3334
PR-URL: #48037
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@legendecas @targos
doc: document node-api version process
0e4a3b7
PR-URL: #47972
Fixes: #47664
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
@npm-cli-bot @targos
deps: upgrade npm to 9.6.7
03f67d6
PR-URL: #48062
Reviewed-By: Luke Karrys <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@giltayar @targos
module: change default resolver to not throw on unknown scheme
f380953
Fixes nodejs/loaders#138

PR-URL: #47824
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@Trott @targos
doc: update broken spkac link
5917ba1
PR-URL: #48063
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@Trott @targos
doc: update broken EVP_BytesToKey link
1e3e7c9
PR-URL: #48064
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@nodejs-github-bot @targos
deps: update uvwasi to 0.0.17
443477e
PR-URL: #47866
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@RafaelGSS RafaelGSS removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 7, 2023
@targos @RafaelGSS
2023-06-08, Version 20.3.0 (Current)
57679e1
Notable changes:

deps:
  * upgrade to libuv 1.45.0, including significant performance
    improvements to file system operations on Linux (Santiago Gimeno) #48078
doc:
  * add Ruy Adorno to list of TSC members (Michael Dawson) #48172
  * mark Node.js 14 as End-of-Life (Richard Lau) #48023
lib:
  * (SEMVER-MINOR) implement AbortSignal.any() (Chemi Atlow) #47821
module:
  * change default resolver to not throw on unknown scheme (Gil Tayar) #47824
node-api:
  * (SEMVER-MINOR) define version 9 (Chengzhong Wu) #48151
stream:
  * deprecate asIndexedPairs (Chemi Atlow) #48102

PR-URL: #48332
@RafaelGSS
RafaelGSS force-pushed the v20.3.0-proposal branch from 6d770b5 to 57679e1 Compare June 7, 2023 15:04
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 7, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 7, 2023 •
edited by RafaelGSS
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52145/ ✔️
CITGM: https://ci.nodejs.org/job/citgm-smoker/3165/ ✔️
CITGM(v20.x): https://ci.nodejs.org/job/citgm-smoker/3166/ ✔️

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bricss

bricss commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

Would be great to pull in latest perks 👾 from main before release 😀

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ruyadorno
ruyadorno reviewed Jun 7, 2023
View reviewed changes
Comment thread doc/changelogs/CHANGELOG_V20.md
@@ -37,6 +38,168 @@
* [io.js](CHANGELOG_IOJS.md)
* [Archive](CHANGELOG_ARCHIVE.md)

<a id="20.3.0"></a>

## 2023-06-08, Version 20.3.0 (Current), @targos

@ruyadorno ruyadorno Jun 7, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would have been nice to add your name here @RafaelGSS since you're going to be promoting the release 😊 not a blocker though

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@RafaelGSS RafaelGSS Jun 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. I don't want to spin up all the CI again 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow, marco-ippolito, and ruyadorno reacted with thumbs up emoji MoLow, ruyadorno, and lin72h reacted with heart emoji
All reactions
  • 👍 3 reactions
  • ❤️ 3 reactions

@shrujalshah28 shrujalshah28 Jun 8, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nodejs/node/blob/main/doc/contributing/releases.md?plain=1#L577-L580

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ruyadorno
ruyadorno approved these changes Jun 7, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jun 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52146/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jun 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52148/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@LiviaMedeiros

LiviaMedeiros commented Jun 7, 2023

Copy link
Copy Markdown
Member

Any chance to include #48344? It would fix compilation error for some CPUs.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS

RafaelGSS commented Jun 7, 2023

Copy link
Copy Markdown
Member

Any chance to include #48344? It would fix compilation error for some CPUs.

I don't think so. I currently have a limited time to rebuild the proposal on top of the main again. This should be included in Node.js v20.4.0.

LiviaMedeiros and bricss reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS

RafaelGSS commented Jun 8, 2023

Copy link
Copy Markdown
Member

📦 https://ci-release.nodejs.org/job/iojs+release/9408/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau
richardlau approved these changes Jun 8, 2023
View reviewed changes
@RafaelGSS
RafaelGSS merged commit 57679e1 into v20.x Jun 8, 2023
@RafaelGSS
RafaelGSS deleted the v20.3.0-proposal branch June 8, 2023 15:59
RafaelGSS added a commit that referenced this pull request Jun 8, 2023
@RafaelGSS
Working on v20.3.1
4ba246b
PR-URL: #48332
RafaelGSS pushed a commit that referenced this pull request Jun 8, 2023
@targos @RafaelGSS
2023-06-08, Version 20.3.0 (Current)
5a58972
Notable changes:

deps:
  * upgrade to libuv 1.45.0, including significant performance
    improvements to file system operations on Linux (Santiago Gimeno) #48078
doc:
  * add Ruy Adorno to list of TSC members (Michael Dawson) #48172
  * mark Node.js 14 as End-of-Life (Richard Lau) #48023
lib:
  * (SEMVER-MINOR) implement AbortSignal.any() (Chemi Atlow) #47821
module:
  * change default resolver to not throw on unknown scheme (Gil Tayar) #47824
node-api:
  * (SEMVER-MINOR) define version 9 (Chengzhong Wu) #48151
stream:
  * deprecate asIndexedPairs (Chemi Atlow) #48102

PR-URL: #48332
RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request Jun 8, 2023
@RafaelGSS
Blog: v20.3.0 release post
1c6c3c7
Refs: nodejs/node#48332
@RafaelGSS RafaelGSS mentioned this pull request Jun 8, 2023
Blog: v20.3.0 release post nodejs/nodejs.org#5422
Merged
RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Jun 8, 2023
@RafaelGSS
Blog: v20.3.0 release post (#5422)
35b8194
Refs: nodejs/node#48332
This was referenced Jun 9, 2023
CI Reliability 2023-06-09 nodejs/reliability#588
Open
CI Reliability 2023-06-10 nodejs/reliability#589
Open
CI Reliability 2023-06-11 nodejs/reliability#590
Open
CI Reliability 2023-06-12 nodejs/reliability#591
Open
CI Reliability 2023-06-13 nodejs/reliability#592
Open
@cristianArdila-h

cristianArdila-h commented Jul 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Hello, I try to generate a coverage report in a test suite, but when I include a test that simulates an api consumption with fetch, the report is not generated.

comand: node --experimental-test-coverage --test-reporter=tap --test-reporter-destination=file.txt --test --loader ts-node/esm test/**/*.test.ts

I generate the api mock in this way:

image

image

I have tried several options without successful results, I don't know if it is a reported bug or the problem is in my project.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@targos @Ceres6
2023-06-08, Version 20.3.0 (Current)
ad26015
Notable changes:

deps:
  * upgrade to libuv 1.45.0, including significant performance
    improvements to file system operations on Linux (Santiago Gimeno) nodejs#48078
doc:
  * add Ruy Adorno to list of TSC members (Michael Dawson) nodejs#48172
  * mark Node.js 14 as End-of-Life (Richard Lau) nodejs#48023
lib:
  * (SEMVER-MINOR) implement AbortSignal.any() (Chemi Atlow) nodejs#47821
module:
  * change default resolver to not throw on unknown scheme (Gil Tayar) nodejs#47824
node-api:
  * (SEMVER-MINOR) define version 9 (Chengzhong Wu) nodejs#48151
stream:
  * deprecate asIndexedPairs (Chemi Atlow) nodejs#48102

PR-URL: nodejs#48332
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@targos @Ceres6
2023-06-08, Version 20.3.0 (Current)
902f572
Notable changes:

deps:
  * upgrade to libuv 1.45.0, including significant performance
    improvements to file system operations on Linux (Santiago Gimeno) nodejs#48078
doc:
  * add Ruy Adorno to list of TSC members (Michael Dawson) nodejs#48172
  * mark Node.js 14 as End-of-Life (Richard Lau) nodejs#48023
lib:
  * (SEMVER-MINOR) implement AbortSignal.any() (Chemi Atlow) nodejs#47821
module:
  * change default resolver to not throw on unknown scheme (Gil Tayar) nodejs#47824
node-api:
  * (SEMVER-MINOR) define version 9 (Chengzhong Wu) nodejs#48151
stream:
  * deprecate asIndexedPairs (Chemi Atlow) nodejs#48102

PR-URL: nodejs#48332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes
@richardlau richardlau richardlau approved these changes
@RafaelGSS RafaelGSS Awaiting requested review from RafaelGSS
+1 more reviewer
@shrujalshah28 shrujalshah28 shrujalshah28 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

release Issues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@targos @nodejs-github-bot @RafaelGSS @ronag @MoLow @anonrig @santigimeno @tniessen @ShogunPanda @bricss @LiviaMedeiros @cristianArdila-h @ruyadorno @richardlau @shrujalshah28 @deokjinkim @shipujin @daeyeon @benjamingr @Basa198
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.