GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test,crypto: update WebCryptoAPI WPT by panva · Pull Request #47131 · nodejs/node

Conversation

@panva

@panva panva commented Mar 17, 2023

Copy link
Copy Markdown
Member

Just git node wpt WebCryptoAPI

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ganeshkbhat reacted with eyes emoji
All reactions
  • 👀 1 reaction
@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to Node.js core tests and test infrastructure. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. webcrypto Issues and PRs related to the Web Crypto API. labels Mar 17, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 17, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 17, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@tniessen

tniessen commented Mar 17, 2023

Copy link
Copy Markdown
Member

@panva looks like all CI failures are due to #47116, which should not be as much of an issue now that #47134 was merged. I'm not sure if resuming CI actually rebases on top of main every time -- so feel free to either resume or start a new CI :)
panva reacted with heart emoji ganeshkbhat reacted with eyes emoji
All reactions
  • ❤️ 1 reaction
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva
test,crypto: update WebCryptoAPI WPT
d64df82
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 17, 2023
@panva
panva force-pushed the wpt-update-crypto branch from 4d3cf0b to d64df82 Compare March 17, 2023 16:47
tniessen
tniessen approved these changes Mar 17, 2023
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI passes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 17, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50422/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Mar 17, 2023
View reviewed changes
@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 17, 2023
This was referenced Mar 18, 2023
CI Reliability 2023-03-18 nodejs/reliability#527
Open
CI Reliability 2023-03-19 nodejs/reliability#528
Open
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 19, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 142d6af into nodejs:main Mar 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 19, 2023

Copy link
Copy Markdown
Collaborator

Landed in 142d6af
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Mar 20, 2023
CI Reliability 2023-03-20 nodejs/reliability#530
Open
17 tasks
@panva
panva deleted the wpt-update-crypto branch March 20, 2023 10:53
@github-actions github-actions Bot mentioned this pull request Mar 21, 2023
CI Reliability 2023-03-21 nodejs/reliability#531
Open
19 tasks
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@panva @RafaelGSS
test,crypto: update WebCryptoAPI WPT
445e942 
PR-URL: #47131
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@panva @RafaelGSS
test,crypto: update WebCryptoAPI WPT
65955f1 
PR-URL: #47131
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@panva @danielleadams
test,crypto: update WebCryptoAPI WPT
873606b 
PR-URL: #47131
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. webcrypto Issues and PRs related to the Web Crypto API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@panva @nodejs-github-bot @tniessen @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.