GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: mark test-http-max-sockets as flaky on win32 by tniessen · Pull Request #47134 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Mar 17, 2023

Copy link
Copy Markdown
Member

Current Windows CI build trend:

build trend of node-test-binary-windows-js-suites showing almost only failures recently

I am not sure if marking it as flaky is going to be enough. Maybe we have to skip it entirely, but that's something that we should try to avoid.

Refs: #47116

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tniessen
test: mark test-http-max-sockets as flaky on win32
7253d4a 
Refs: nodejs#47116
@tniessen tniessen added windows Issues and PRs related to the Windows platform. test Issues and PRs related to Node.js core tests and test infrastructure. flaky-test Issues and PRs involving tests that fail intermittently in CI. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Mar 17, 2023
@github-actions

github-actions Bot commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.
anonrig and BethGriggs reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 17, 2023
@tniessen tniessen mentioned this pull request Mar 17, 2023
test-http-max-sockets fails in node-test-binary-windows-js-suites #47116
Closed
anonrig
anonrig approved these changes Mar 17, 2023
View reviewed changes
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Mar 17, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 17, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Mar 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50420/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen

tniessen commented Mar 17, 2023

Copy link
Copy Markdown
Member Author

Test was correctly detected as being flaky in the previous Jenkins run, but some other tests on other platforms flaked, too...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BethGriggs
BethGriggs approved these changes Mar 17, 2023
View reviewed changes
@tniessen tniessen added the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 17, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 9e9f68a into nodejs:main Mar 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 17, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9e9f68a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen mentioned this pull request Mar 17, 2023
test,crypto: update WebCryptoAPI WPT #47131
Merged
@github-actions github-actions Bot mentioned this pull request Mar 18, 2023
CI Reliability 2023-03-18 nodejs/reliability#527
Open
23 tasks
targos pushed a commit that referenced this pull request Mar 18, 2023
@tniessen @targos
test: mark test-http-max-sockets as flaky on win32
7bcfd18 
Refs: #47116
PR-URL: #47134
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
This was referenced Mar 19, 2023
CI Reliability 2023-03-19 nodejs/reliability#528
Open
CI Reliability 2023-03-20 nodejs/reliability#530
Open
CI Reliability 2023-03-21 nodejs/reliability#531
Open
@debadree25 debadree25 mentioned this pull request Mar 21, 2023
Flaky Test parallel/test-http-remove-connection-header-persists-connection #47200
Closed
This was referenced Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
v19.9.0 proposal #47441
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@tniessen @danielleadams
test: mark test-http-max-sockets as flaky on win32
713b412 
Refs: #47116
PR-URL: #47134
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tniessen @nodejs-github-bot @anonrig @BethGriggs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.