GeezerVison

test: run doctool tests in parallel #47273

Closed

nodejs-github-bot added needs-ci

PRs that need a full CI run.

test Issues and PRs related to Node.js core tests and test infrastructure. labels

This comment was marked as outdated.

panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

targos reviewed

View reviewed changes

Comment thread

test/common/wpt.js Outdated

Comment on lines 418 to 413

targos Mar 28, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not returned or awaited. Is there a risk of unhandled rejection?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

panva Mar 28, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It behaves as expected even with the WPT suite updated (like the daily WPT job does).

This is the await in the queue.

await events.once(worker, 'exit').catch(() => {});

That being said, I am aware it's just a basic concurrency limit function implementation...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

This comment was marked as outdated.

This comment was marked as resolved.

github-actions Bot mentioned this pull request

CI Reliability 2023-03-30 nodejs/reliability#534

Open

18 tasks

panva added the blocked PRs that are blocked by other issues or PRs. label

This comment was marked as resolved.


          test: run WPT files in parallel again

313c51e

panva force-pushed the try-wpt-files-parallel branch from 77fed52 to 313c51e Compare

March 30, 2023 15:37

panva added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed blocked PRs that are blocked by other issues or PRs. labels

https://ci.nodejs.org/job/node-stress-single-test/391/console

panva commented Mar 30, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

Before:

make test-wpt  74.66s user 2.29s system 88% cpu 1:27.07 total

After:

make test-wpt  75.50s user 3.28s system 428% cpu 18.368 total

Ran on an M1 Macbook Pro

> os.availableParallelism()
10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

CI: https://ci.nodejs.org/job/node-test-pull-request/50721/

This comment was marked as outdated.

nodejs-github-bot commented Mar 30, 2023

Copy link

Copy Markdown

Collaborator

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

CI Reliability 2023-03-31 nodejs/reliability#535

Open

34 tasks

targos approved these changes

View reviewed changes

panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

anonrig approved these changes

View reviewed changes

anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

nodejs-github-bot merged commit c05689e into nodejs:main