GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: ensure failed daily wpt run still generates a report by panva · Pull Request #47376 · nodejs/node

Conversation

@panva

@panva panva commented Apr 2, 2023

Copy link
Copy Markdown
Member

This fixes a regression to the daily wpt run (only nightly runs at the moment) introduced in #47283.

When this lands the dont-land-* labels on #47283 may be removed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@panva
tools: ensure failed daily wpt run still generates a report
f7e1e44
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Apr 2, 2023
@panva panva added tools Issues and PRs related to the tools directory. and removed build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Apr 2, 2023
targos
targos approved these changes Apr 3, 2023
View reviewed changes
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Apr 3, 2023
@github-actions

github-actions Bot commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.
targos and anonrig reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Apr 3, 2023
View reviewed changes
@panva

panva commented Apr 3, 2023

Copy link
Copy Markdown
Member Author

Landed in b17227b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
panva added a commit that referenced this pull request Apr 3, 2023
@panva
tools: ensure failed daily wpt run still generates a report
b17227b 
PR-URL: #47376
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@panva panva closed this Apr 3, 2023
@panva
panva deleted the fix-nightly-wpt-report branch April 3, 2023 11:06
@panva panva mentioned this pull request Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@panva @RafaelGSS
tools: ensure failed daily wpt run still generates a report
66b9e39 
PR-URL: #47376
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
v19.9.0 proposal #47441
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@panva @RafaelGSS
tools: ensure failed daily wpt run still generates a report
7bd0129 
PR-URL: #47376
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@panva @RafaelGSS
tools: ensure failed daily wpt run still generates a report
00aacc4 
PR-URL: #47376
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@panva @RafaelGSS
tools: ensure failed daily wpt run still generates a report
760e13c 
PR-URL: #47376
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@panva panva mentioned this pull request Apr 19, 2023
test: fix WPT runner cutting off inprogress workers #47626
Closed
@panva panva added dont-land-on-v14.x labels Apr 19, 2023
@panva panva mentioned this pull request Apr 19, 2023
test: revert parallel wpt commits #47627
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@panva @anonrig @targos @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.