GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test: skip test-wasm-web-api on ARM by targos · Pull Request #47299 · nodejs/node

Conversation

targos commented Mar 29, 2023

Copy link

Copy Markdown

Member

This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

Refs: #47251

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction


          test: skip test-wasm-web-api on ARM

This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

This was referenced Mar 29, 2023

Problems with "wasm-webapi" tests and V8 >= 11.2 #47297

Closed

deps: update V8 to 11.3 #47251

Closed

targos added v8 engine

Issues and PRs related to the V8 dependency.

test

Issues and PRs related to Node.js core tests and test infrastructure.

arm

Issues and PRs related to the ARM architecture.

wasm

Issues and PRs related to WebAssembly.

fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels

Mar 29, 2023

panva approved these changes

Mar 29, 2023

View reviewed changes

panva commented Mar 29, 2023

Copy link

Copy Markdown

Member

Fast-track has been requested by @targos. Please 👍 to approve.

panva, gengjiawen, richardlau, debadree25, anonrig, and bricss reacted with thumbs up emoji

All reactions

👍 6 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

panva commented Mar 29, 2023

Copy link

Copy Markdown

Member

(actions has degraded performance at this time so might take a while for the bot comment to appear, when it does, remove it as CQ looks at the last matching comment in the PR)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gengjiawen approved these changes

Mar 29, 2023

View reviewed changes

tniessen approved these changes

Mar 29, 2023

View reviewed changes

richardlau approved these changes

Mar 29, 2023

View reviewed changes

cjihrig approved these changes

Mar 29, 2023

View reviewed changes

lpinca approved these changes

Mar 29, 2023

View reviewed changes

anonrig approved these changes

Mar 29, 2023

View reviewed changes

targos added the commit-queue PRs queued for automated landing through the Commit Queue. label

Mar 30, 2023

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Mar 30, 2023

nodejs-github-bot commented Mar 30, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/47299
✔  Done loading data for nodejs/node/pull/47299
----------------------------------- PR info ------------------------------------
Title      test: skip test-wasm-web-api on ARM (#47299)
Author     Michaël Zasso  (@targos)
Branch     targos:wasm-web-api -> nodejs:main
Labels     v8 engine, test, arm, fast-track, wasm
Commits    1
 - test: skip test-wasm-web-api on ARM
Committers 1
 - Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/47299
Refs: https://github.com/nodejs/node/pull/47251
Reviewed-By: Filip Skokan 
Reviewed-By: Jiawen Geng 
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47299
Refs: https://github.com/nodejs/node/pull/47251
Reviewed-By: Filip Skokan 
Reviewed-By: Jiawen Geng 
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 29 Mar 2023 15:30:45 GMT
   ✔  Approvals: 7
   ✔  - Filip Skokan (@panva): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363426574
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363467577
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363470733
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363548198
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363551730
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363700293
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363880905
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4561323427

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Mar 30, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Mar 30, 2023

nodejs-github-bot commented Mar 30, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50687/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Mar 30, 2023

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5257/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Mar 30, 2023

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5257/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos added the commit-queue PRs queued for automated landing through the Commit Queue. label

Mar 30, 2023

nodejs-github-bot commented Mar 30, 2023

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5259/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Mar 30, 2023

nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label

Mar 30, 2023

nodejs-github-bot commented Mar 30, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/47299
✔  Done loading data for nodejs/node/pull/47299
----------------------------------- PR info ------------------------------------
Title      test: skip test-wasm-web-api on ARM (#47299)
Author     Michaël Zasso  (@targos)
Branch     targos:wasm-web-api -> nodejs:main
Labels     v8 engine, test, arm, fast-track, wasm
Commits    1
 - test: skip test-wasm-web-api on ARM
Committers 1
 - Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/47299
Refs: https://github.com/nodejs/node/pull/47251
Reviewed-By: Filip Skokan 
Reviewed-By: Jiawen Geng 
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47299
Refs: https://github.com/nodejs/node/pull/47251
Reviewed-By: Filip Skokan 
Reviewed-By: Jiawen Geng 
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 29 Mar 2023 15:30:45 GMT
   ✔  Approvals: 7
   ✔  - Filip Skokan (@panva): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363426574
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363467577
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363470733
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363548198
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363551730
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363700293
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47299#pullrequestreview-1363880905
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-03-30T06:50:07Z: https://ci.nodejs.org/job/node-test-pull-request/50687/
- Querying data for job/node-test-pull-request/50687/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4563127960

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos commented Mar 30, 2023

Copy link

Copy Markdown

Member Author

Landed in 65b79ab

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos closed this

Mar 30, 2023

targos added a commit that referenced this pull request

Mar 30, 2023


          test: skip test-wasm-web-api on ARM

65b79ab

This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: #47299
Refs: #47251
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

targos deleted the wasm-web-api branch

March 30, 2023 10:10

RafaelGSS mentioned this pull request

Apr 3, 2023

2023-04-18, Version 20.0.0 (Current) #47381

Merged

RafaelGSS pushed a commit that referenced this pull request

Apr 5, 2023


          test: skip test-wasm-web-api on ARM

ab1eb52

This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: #47299
Refs: #47251
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

RafaelGSS mentioned this pull request

Apr 6, 2023

v19.9.0 proposal #47441

Merged

RafaelGSS pushed a commit that referenced this pull request

Apr 6, 2023


          test: skip test-wasm-web-api on ARM

81ec3f3

This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: #47299
Refs: #47251
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

RafaelGSS pushed a commit that referenced this pull request

Apr 7, 2023


          test: skip test-wasm-web-api on ARM

d341d03

This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: #47299
Refs: #47251
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

danielleadams pushed a commit that referenced this pull request

Jul 6, 2023


          test: skip test-wasm-web-api on ARM

53d9eb5

This test is flaky on ARM with V8 >= 11.2.
Skip it so we can update V8 before the release of Nodejs 20.0.0.

PR-URL: #47299
Refs: #47251
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

danielleadams mentioned this pull request

Jul 10, 2023

v18.17.0 release proposal #48694

Merged

richardlau added a commit to richardlau/node-1 that referenced this pull request

Sep 29, 2023


          test: update skip for moved test-wasm-web-api

e00fd22

`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: nodejs#49869
Refs: nodejs#47299
Refs: nodejs#47297

richardlau mentioned this pull request

Sep 29, 2023

test: update skip for moved test-wasm-web-api #49958

Merged

nodejs-github-bot pushed a commit that referenced this pull request

Sep 30, 2023


          test: update skip for moved test-wasm-web-api

6c9625d

`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: #49869
Refs: #47299
Refs: #47297
PR-URL: #49958
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>

targos pushed a commit that referenced this pull request

Nov 11, 2023


          test: update skip for moved test-wasm-web-api

01b0152

`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: #49869
Refs: #47299
Refs: #47297
PR-URL: #49958
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>

debadree25 pushed a commit to debadree25/node that referenced this pull request

Apr 15, 2024


          test: update skip for moved test-wasm-web-api

ba272e1

`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: nodejs#49869
Refs: nodejs#47299
Refs: nodejs#47297
PR-URL: nodejs#49958
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>

Reviewers

panva

panva approved these changes

lpinca

lpinca approved these changes

anonrig

anonrig approved these changes

cjihrig

cjihrig approved these changes

tniessen

tniessen approved these changes

gengjiawen

gengjiawen approved these changes

richardlau

richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

arm

Issues and PRs related to the ARM architecture.

commit-queue-failed

PRs whose Commit Queue landing failed and need manual intervention before retrying.

fast-track

PRs proposed for a shorter-than-standard waiting period before landing.

test

Issues and PRs related to Node.js core tests and test infrastructure.

v8 engine

Issues and PRs related to the V8 dependency.

wasm

Issues and PRs related to WebAssembly.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.