GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: update skip for moved `test-wasm-web-api` by richardlau · Pull Request #49958 · nodejs/node

Conversation

@richardlau

@richardlau richardlau commented Sep 29, 2023

Copy link
Copy Markdown
Member

test-wasm-web-api was moved from test/parallel to test/es-modules. Update the status files for parallel and es-modules accordingly.

Refs: #49869
Refs: #47299
Refs: #47297

Started seeing test-wasm-web-api failing for arm64 debug builds again today.
e.g. https://ci.nodejs.org/job/node-test-commit-arm-debug/nodes=ubuntu2004_debug-arm64/9557/ seems to be the earliest build that it happened in.

According to the reliability repo, we saw this test flaking at the beginning of the year. We started skipping it on arm in #47299. #49869 moved the test from test/parallel to test/es-modules but didn't move the corresponding entry in test/parallel/parallel.status.

cc @nodejs/loaders

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@richardlau
test: update skip for moved test-wasm-web-api
e00fd22 
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: nodejs#49869
Refs: nodejs#47299
Refs: nodejs#47297
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 29, 2023
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54379/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joyeecheung
joyeecheung approved these changes Sep 29, 2023
View reviewed changes
@richardlau richardlau added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54383/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Sep 29, 2023
View reviewed changes
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 29, 2023
GeoffreyBooth
GeoffreyBooth approved these changes Sep 29, 2023
View reviewed changes
@GeoffreyBooth GeoffreyBooth added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Sep 29, 2023
@github-actions

github-actions Bot commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.
MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49958
✔  Done loading data for nodejs/node/pull/49958
----------------------------------- PR info ------------------------------------
Title      test: update skip for moved `test-wasm-web-api` (#49958)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     richardlau:fixskip -> nodejs:main
Labels     test, esm, fast-track, author ready, needs-ci
Commits    1
 - test: update skip for moved `test-wasm-web-api`
Committers 1
 - Richard Lau 
PR-URL: https://github.com/nodejs/node/pull/49958
Refs: https://github.com/nodejs/node/pull/49869
Refs: https://github.com/nodejs/node/pull/47299
Refs: https://github.com/nodejs/node/issues/47297
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Geoffrey Booth 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49958
Refs: https://github.com/nodejs/node/pull/49869
Refs: https://github.com/nodejs/node/pull/47299
Refs: https://github.com/nodejs/node/issues/47297
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Geoffrey Booth 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 29 Sep 2023 15:56:37 GMT
   ✔  Approvals: 3
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/49958#pullrequestreview-1651113176
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49958#pullrequestreview-1651340315
   ✔  - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49958#pullrequestreview-1651415560
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 43 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-09-29T17:32:55Z: https://ci.nodejs.org/job/node-test-pull-request/54383/
- Querying data for job/node-test-pull-request/54383/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6356595801
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Sep 29, 2023
@github-actions github-actions Bot mentioned this pull request Sep 30, 2023
CI Reliability 2023-09-30 nodejs/reliability#679
Open
31 tasks
@richardlau richardlau added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label Sep 30, 2023
MoLow
MoLow approved these changes Sep 30, 2023
View reviewed changes
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 30, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 6c9625d into nodejs:main Sep 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2023

Copy link
Copy Markdown
Collaborator

Landed in 6c9625d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau
richardlau deleted the fixskip branch September 30, 2023 23:30
@github-actions github-actions Bot mentioned this pull request Oct 1, 2023
CI Reliability 2023-10-01 nodejs/reliability#680
Open
16 tasks
@github-actions github-actions Bot mentioned this pull request Oct 2, 2023
CI Reliability 2023-10-02 nodejs/reliability#681
Open
12 tasks
@github-actions github-actions Bot mentioned this pull request Oct 3, 2023
CI Reliability 2023-10-03 nodejs/reliability#682
Open
18 tasks
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@richardlau @targos
test: update skip for moved test-wasm-web-api
01b0152 
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: #49869
Refs: #47299
Refs: #47297
PR-URL: #49958
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@richardlau @debadree25
test: update skip for moved test-wasm-web-api
ba272e1 
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: nodejs#49869
Refs: nodejs#47299
Refs: nodejs#47297
PR-URL: nodejs#49958
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@lpinca lpinca lpinca approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@richardlau @nodejs-github-bot @GeoffreyBooth @lpinca @joyeecheung @MoLow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.