GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: refactor v8_pch config by targos · Pull Request #47364 · nodejs/node

Conversation

@targos

@targos targos commented Apr 1, 2023

Copy link
Copy Markdown
Member

Avoid repetition by defining a new GYP target.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@targos targos added windows Issues and PRs related to the Windows platform. build Issues and PRs related to Node.js builds or CI infrastructure. dont-land-on-v14.x labels Apr 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Apr 1, 2023
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 1, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50790/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5265/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5265/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5265/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Apr 2, 2023
CI Reliability 2023-04-02 nodejs/reliability#537
Open
CI Reliability 2023-04-03 nodejs/reliability#538
Open
CI Reliability 2023-04-04 nodejs/reliability#539
Open
@targos

targos commented Apr 5, 2023

Copy link
Copy Markdown
Member Author

@gengjiawen ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StefanStojanovic
StefanStojanovic approved these changes Apr 5, 2023
View reviewed changes

@StefanStojanovic StefanStojanovic left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@targos
targos force-pushed the refactor-pch branch from 4cd73cf to 05e5f0d Compare April 5, 2023 09:24
@targos targos added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed v8 engine Issues and PRs related to the V8 dependency. labels Apr 5, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50958/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50967/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Apr 5, 2023
View reviewed changes
gengjiawen
gengjiawen approved these changes Apr 7, 2023
View reviewed changes
@targos
targos force-pushed the refactor-pch branch from 05e5f0d to fdf0d84 Compare April 8, 2023 08:17
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51065/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos mentioned this pull request Apr 8, 2023
src: disable concurrent sparkplug compilation #47450
Closed
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51084/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Apr 12, 2023
CI Reliability 2023-04-12 nodejs/reliability#541
Open
31 tasks
@nodejs-github-bot

nodejs-github-bot commented Apr 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51427/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos removed the dont-land-on-v14.x label May 3, 2023
@targos
tools: refactor v8_pch config
8dc0ba6 
Avoid repetition by defining a new GYP target.
@targos
targos force-pushed the refactor-pch branch from fdf0d84 to 8dc0ba6 Compare May 10, 2023 12:38
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 10, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 10, 2023
@nodejs-github-bot

nodejs-github-bot commented May 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51746/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51749/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tniessen
tniessen approved these changes May 10, 2023
View reviewed changes
This was referenced May 11, 2023
CI Reliability 2023-05-11 nodejs/reliability#562
Open
CI Reliability 2023-05-12 nodejs/reliability#563
Open
CI Reliability 2023-05-13 nodejs/reliability#564
Open
CI Reliability 2023-05-14 nodejs/reliability#565
Open
CI Reliability 2023-05-15 nodejs/reliability#566
Open
CI Reliability 2023-05-16 nodejs/reliability#567
Open
CI Reliability 2023-05-17 nodejs/reliability#568
Open
@targos targos added the commit-queue PRs queued for automated landing through the Commit Queue. label May 28, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 28, 2023
@nodejs-github-bot
nodejs-github-bot merged commit d81151e into nodejs:main May 28, 2023
@nodejs-github-bot

nodejs-github-bot commented May 28, 2023

Copy link
Copy Markdown
Collaborator

Landed in d81151e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos
targos deleted the refactor-pch branch May 28, 2023 12:05
targos added a commit that referenced this pull request May 30, 2023
@targos
tools: refactor v8_pch config
568a705 
Avoid repetition by defining a new GYP target.

PR-URL: #47364
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@targos @Ceres6
tools: refactor v8_pch config
85b5693 
Avoid repetition by defining a new GYP target.

PR-URL: nodejs#47364
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@targos @Ceres6
tools: refactor v8_pch config
5c6bf8c 
Avoid repetition by defining a new GYP target.

PR-URL: nodejs#47364
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@targos @nodejs-github-bot @tniessen @gengjiawen @richardlau @StefanStojanovic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.