GeezerVison

- Loading data for nodejs/node/pull/47572
✔  Done loading data for nodejs/node/pull/47572
----------------------------------- PR info ------------------------------------
Title      vm: properly handle defining symbol props (#47572)
Author     Nicolas DUBIEN  (@dubzzz)
Branch     dubzzz:fix-symbol-vm-node-master -> nodejs:main
Labels     c++, vm, needs-ci, dont-land-on-v20.x
Commits    4
 - vm: properly handle defining symbol props
 - share more across variants of the test
 - run assertions from the sandbox too
 - run even more assertions against sandbox
Committers 1
 - Nicolas DUBIEN 
PR-URL: https://github.com/nodejs/node/pull/47572
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47572
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 15 Apr 2023 16:12:17 GMT
   ✔  Approvals: 1
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/47572#pullrequestreview-1414068765
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-05-10T03:56:15Z: https://ci.nodejs.org/job/node-test-pull-request/51725/
- Querying data for job/node-test-pull-request/51725/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 47572
From https://github.com/nodejs/node
 * branch                  refs/pull/47572/merge -> FETCH_HEAD
✔  Fetched commits as 70da07595447..d108a9c6b972
--------------------------------------------------------------------------------
Auto-merging src/node_contextify.cc
[main feeadaf4a8] vm: properly handle defining symbol props
 Author: Nicolas DUBIEN 
 Date: Sat Apr 15 14:33:13 2023 +0000
 3 files changed, 81 insertions(+), 26 deletions(-)
 create mode 100644 test/parallel/test-vm-global-get-own.js
 delete mode 100644 test/parallel/test-vm-global-symbol.js
[main 56049eb66f] share more across variants of the test
 Author: Nicolas DUBIEN 
 Date: Wed Apr 19 11:27:08 2023 +0000
 1 file changed, 60 insertions(+), 63 deletions(-)
[main 195e77b537] run assertions from the sandbox too
 Author: Nicolas DUBIEN 
 Date: Wed Apr 19 11:42:21 2023 +0000
 1 file changed, 85 insertions(+), 33 deletions(-)
[main 71cd77fd40] run even more assertions against sandbox
 Author: Nicolas DUBIEN 
 Date: Wed Apr 19 18:35:07 2023 +0000
 1 file changed, 24 insertions(+), 48 deletions(-)
   ✔  Patches applied
There are 4 commits in the PR. Attempting autorebase.
Rebasing (2/8)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

vm: properly handle defining symbol props
This PR is a follow-up of #46615.
When bumping V8 for node 18, various bugs appeared around vm.

Some have been fixed along the flow, but there is at least one

remaining and described at:

jestjs/jest#13338.
The current fix does nothing on node 20: the new bump of v8 done for

node 20 seems to fix it. But it would fix the problem in both node 18

and node 19. I confirmed it would fix node 19 by cherry-picking the

commit on v19.x-staging and launching make -j4 jstest on it.
PR-URL: #47572

Reviewed-By: James M Snell [email protected]
[detached HEAD e3989a52b7] vm: properly handle defining symbol props

Author: Nicolas DUBIEN [email protected]

Date: Sat Apr 15 14:33:13 2023 +0000

3 files changed, 81 insertions(+), 26 deletions(-)

create mode 100644 test/parallel/test-vm-global-get-own.js

delete mode 100644 test/parallel/test-vm-global-symbol.js

Rebasing (3/8)

Rebasing (4/8)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

share more across variants of the test
PR-URL: #47572

Reviewed-By: James M Snell [email protected]
[detached HEAD 9d3829086b] share more across variants of the test

Author: Nicolas DUBIEN [email protected]

Date: Wed Apr 19 11:27:08 2023 +0000

1 file changed, 60 insertions(+), 63 deletions(-)

Rebasing (5/8)

Rebasing (6/8)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

run assertions from the sandbox too
PR-URL: #47572

Reviewed-By: James M Snell [email protected]
[detached HEAD 0194c7f82d] run assertions from the sandbox too

Author: Nicolas DUBIEN [email protected]

Date: Wed Apr 19 11:42:21 2023 +0000

1 file changed, 85 insertions(+), 33 deletions(-)

Rebasing (7/8)

Rebasing (8/8)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

run even more assertions against sandbox
PR-URL: #47572

Reviewed-By: James M Snell [email protected]
[detached HEAD 7229614bab] run even more assertions against sandbox

Author: Nicolas DUBIEN [email protected]

Date: Wed Apr 19 18:35:07 2023 +0000

1 file changed, 24 insertions(+), 48 deletions(-)
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.