GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: migrate a pseudo_tty test to use assertSnapshot by MoLow · Pull Request #47803 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented May 1, 2023

Copy link
Copy Markdown
Member

this is another followup for #47498 enabling running pseudo-tty snapshot tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented May 1, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow marked this pull request as draft May 1, 2023 18:01
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels May 1, 2023
@MoLow MoLow mentioned this pull request May 1, 2023
tools: add node-pty as a dependency #47793
Closed
@MoLow
MoLow force-pushed the migrate-psuedo-tty branch from 5580260 to d086cf1 Compare May 1, 2023 20:05
@MoLow
MoLow marked this pull request as ready for review May 1, 2023 20:06
ljharb
ljharb reviewed May 1, 2023
View reviewed changes
Comment thread test/common/assertSnapshot.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow force-pushed the migrate-psuedo-tty branch from d086cf1 to e64ee0e Compare May 1, 2023 20:30
@MoLow
MoLow requested review from GeoffreyBooth and benjamingr May 1, 2023 20:31
GeoffreyBooth
GeoffreyBooth approved these changes May 1, 2023
View reviewed changes
Comment thread test/common/assertSnapshot.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/fixtures/test-runner/output/default_output.snapshot Outdated

@GeoffreyBooth GeoffreyBooth May 1, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we run these with ANSI colors support disabled to make easier-to-read snapshots?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@MoLow MoLow May 2, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the entire purpose of this test is to test the colors and the reporter

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/parallel/test-runner-output.mjs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow force-pushed the migrate-psuedo-tty branch 2 times, most recently from b6f9dfd to 12913f5 Compare May 2, 2023 05:21
@MoLow MoLow changed the title test: migrate pseudo_tty tests to use assertSnapshot test: migrate a pseudo_tty test to use assertSnapshot May 2, 2023
@MoLow
test: migrate a pseudo_tty test to use assertSnapshot
db53913
@MoLow
MoLow force-pushed the migrate-psuedo-tty branch from 12913f5 to db53913 Compare May 2, 2023 05:36
@MoLow MoLow added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels May 2, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 2, 2023
@nodejs-github-bot

nodejs-github-bot commented May 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51569/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes May 2, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request May 3, 2023
CI Reliability 2023-05-03 nodejs/reliability#554
Open
33 tasks
@MoLow
fixup! test: migrate a pseudo_tty test to use assertSnapshot
79dbafa
@MoLow

MoLow commented May 3, 2023

Copy link
Copy Markdown
Member Author

I spend hours to get a working Windows environment to figure out why tests were failing when it turns out this is the original behavior 😂 :

node/test/pseudo-tty/testcfg.py

Lines 143 to 145 in 76ae7be

if utils.IsWindows():
print ("Skipping pseudo-tty tests, as pseudo terminals are not available"
" on Windows.")

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 3, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 3, 2023
@nodejs-github-bot

nodejs-github-bot commented May 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51616/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request May 4, 2023
CI Reliability 2023-05-04 nodejs/reliability#555
Open
28 tasks
benjamingr
benjamingr approved these changes May 4, 2023
View reviewed changes
@benjamingr benjamingr added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels May 4, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 4, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 9e5e2f1 into nodejs:main May 4, 2023
@nodejs-github-bot

nodejs-github-bot commented May 4, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9e5e2f1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow deleted the migrate-psuedo-tty branch May 4, 2023 08:57
@github-actions github-actions Bot mentioned this pull request May 5, 2023
CI Reliability 2023-05-05 nodejs/reliability#556
Open
22 tasks
targos pushed a commit that referenced this pull request May 12, 2023
@MoLow @targos
test: migrate a pseudo_tty test to use assertSnapshot
17945a2 
PR-URL: #47803
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos targos mentioned this pull request May 15, 2023
v20.2.0 release proposal #48020
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow @danielleadams
test: migrate a pseudo_tty test to use assertSnapshot
afb85df 
PR-URL: #47803
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
@MoLow
test: migrate a pseudo_tty test to use assertSnapshot
95972aa 
PR-URL: nodejs#47803
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb left review comments
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@benjamingr benjamingr benjamingr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@MoLow @nodejs-github-bot @ljharb @GeoffreyBooth @benjamingr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.