GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: allow SIGBUS in signal-handler abort test by targos · Pull Request #47851 · nodejs/node

Conversation

@targos

@targos targos commented May 4, 2023

Copy link
Copy Markdown
Member

FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@targos
test: allow SIGBUS in signal-handler abort test
eb4bd35 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels May 4, 2023
@targos targos mentioned this pull request May 4, 2023
Update FreeBSD hosts to 12.4 or 13.x nodejs/build#3134
Closed
@targos
fixup
bdcc605
@nodejs-github-bot

nodejs-github-bot commented May 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51619/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented May 4, 2023

Copy link
Copy Markdown
Member Author

I forced the above CI run to be executed on https://ci.nodejs.org/manage/computer/test-digitalocean-freebsd12-x64-1/ (FreeBSD 12.4)
MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
santigimeno
santigimeno approved these changes May 4, 2023
View reviewed changes
Comment thread test/abort/test-signal-handler.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@targos @santigimeno
Update test/abort/test-signal-handler.js
9955918 
Co-authored-by: Santiago Gimeno <[email protected]>
@targos targos added the freebsd Issues and PRs related to the FreeBSD platform. label May 4, 2023
benjamingr
benjamingr approved these changes May 4, 2023
View reviewed changes
@targos targos added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels May 4, 2023
@github-actions

github-actions Bot commented May 4, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.
legendecas, mhdawson, and santigimeno reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 4, 2023
@nodejs-github-bot

nodejs-github-bot commented May 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51621/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson
mhdawson approved these changes May 4, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lpinca
lpinca approved these changes May 4, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request May 5, 2023
CI Reliability 2023-05-05 nodejs/reliability#556
Open
22 tasks
@nodejs-github-bot

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51646/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label May 5, 2023
bnoordhuis
bnoordhuis approved these changes May 5, 2023
View reviewed changes

@bnoordhuis bnoordhuis left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM, no complaints, but I suggest replacing causeSegfault() with abort() because the former contains UB (literal nullptr dereference - compilers are allowed to optimize that away, volatile or not.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51651/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the commit-queue PRs queued for automated landing through the Commit Queue. label May 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 5, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3c82d48 into nodejs:main May 5, 2023
@nodejs-github-bot

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3c82d48
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos
targos deleted the test-freebsd-12.4 branch May 5, 2023 11:04
targos added a commit that referenced this pull request May 5, 2023
@targos
test: allow SIGBUS in signal-handler abort test
d25c785 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: #47851
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
targos added a commit that referenced this pull request May 5, 2023
@targos
test: allow SIGBUS in signal-handler abort test
02fa528 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: #47851
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
targos added a commit that referenced this pull request May 5, 2023
@targos
test: allow SIGBUS in signal-handler abort test
5dc0fee 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: #47851
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
targos added a commit that referenced this pull request May 5, 2023
@targos
test: allow SIGBUS in signal-handler abort test
9bbd991 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: #47851
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@targos

targos commented May 5, 2023

Copy link
Copy Markdown
Member Author

@nodejs/collaborators if this test fails in your CI runs, you'll have to make sure they include this commit (either by rebasing or starting a fresh node-test-pull-request (don't "resume build"))
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added lts-watch-v16.x and removed lts-watch-v18.x labels May 5, 2023
@debadree25 debadree25 mentioned this pull request May 5, 2023
test: improve internal/worker/io.js coverage #42387
Merged
This was referenced May 6, 2023
CI Reliability 2023-05-06 nodejs/reliability#557
Open
CI Reliability 2023-05-07 nodejs/reliability#558
Open
CI Reliability 2023-05-08 nodejs/reliability#559
Open
CI Reliability 2023-05-09 nodejs/reliability#560
Open
@targos targos mentioned this pull request May 15, 2023
v20.2.0 release proposal #48020
Merged
denihs pushed a commit to meteor/node-v14-esm that referenced this pull request Jun 22, 2023
@targos @denihs
test: allow SIGBUS in signal-handler abort test
c33c6c6 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: nodejs#47851
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
denihs pushed a commit to meteor/node-v14-esm that referenced this pull request Jun 22, 2023
@targos @denihs
test: allow SIGBUS in signal-handler abort test
d3b857f 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: nodejs#47851
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
denihs pushed a commit to meteor/node-v14-esm that referenced this pull request Jun 22, 2023
@targos @denihs
test: allow SIGBUS in signal-handler abort test
5b88d74 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: nodejs#47851
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@mxdvl mxdvl mentioned this pull request Jun 23, 2023
Updated Node To v18.16.1 guardian/dotcom-rendering#8032
Merged
erikolofsson pushed a commit to Malterlib/node that referenced this pull request Jun 26, 2023
@targos @erikolofsson
test: allow SIGBUS in signal-handler abort test
b7a9cf2 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: nodejs#47851
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
denihs pushed a commit to meteor/node-v14-esm that referenced this pull request Jun 26, 2023
@targos @denihs
test: allow SIGBUS in signal-handler abort test
6db6599 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: nodejs#47851
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Feb 18, 2025
@targos @RafaelGSS
test: allow SIGBUS in signal-handler abort test
d6fae8e 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: nodejs#47851
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
m0th3rch1p pushed a commit to m0th3rch1p/node that referenced this pull request Jul 20, 2025
@targos @RafaelGSS
test: allow SIGBUS in signal-handler abort test
b77000f 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: nodejs#47851
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@santigimeno santigimeno santigimeno approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. fast-track PRs proposed for a shorter-than-standard waiting period before landing. freebsd Issues and PRs related to the FreeBSD platform. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@targos @nodejs-github-bot @bnoordhuis @santigimeno @benjamingr @lpinca @mhdawson @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.