GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: Fix params names by Semigradsky · Pull Request #47853 · nodejs/node

Conversation

@Semigradsky

@Semigradsky Semigradsky commented May 4, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. stream Issues and PRs related to Node.js streams. labels May 4, 2023
@Semigradsky Semigradsky changed the title Fix params names doc: Fix params names May 4, 2023
Semigradsky added 2 commits May 4, 2023 18:10
@Semigradsky
doc: fix params names
ed8ca8d
@Semigradsky
doc: capitalize the first characters
c98a66a
@Semigradsky
Semigradsky force-pushed the patch-2 branch from 1073e18 to c98a66a Compare May 4, 2023 15:12
lpinca
lpinca approved these changes May 4, 2023
View reviewed changes
HarshithaKP
HarshithaKP approved these changes May 5, 2023
View reviewed changes
@debadree25 debadree25 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels May 6, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels May 6, 2023
@nodejs-github-bot

nodejs-github-bot commented May 6, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/47853
✔  Done loading data for nodejs/node/pull/47853
----------------------------------- PR info ------------------------------------
Title      doc: Fix params names (#47853)
Author     Dmitry Semigradsky  (@Semigradsky)
Branch     Semigradsky:patch-2 -> nodejs:main
Labels     doc, stream, author ready
Commits    2
 - doc: fix params names
 - doc: capitalize the first characters
Committers 1
 - Dmitry Semigradsky 
PR-URL: https://github.com/nodejs/node/pull/47853
Reviewed-By: Luigi Pinca 
Reviewed-By: Harshitha K P 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47853
Reviewed-By: Luigi Pinca 
Reviewed-By: Harshitha K P 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 04 May 2023 09:20:04 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47853#pullrequestreview-1413833963
   ✔  - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/47853#pullrequestreview-1414637380
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 47853
From https://github.com/nodejs/node
 * branch                  refs/pull/47853/merge -> FETCH_HEAD
✔  Fetched commits as 351bf775e169..c98a66aec052
--------------------------------------------------------------------------------
[main dbf132fa20] doc: fix params names
 Author: Dmitry Semigradsky 
 Date: Thu May 4 18:10:33 2023 +0300
 1 file changed, 3 insertions(+), 3 deletions(-)
[main a8abd4e801] doc: capitalize the first characters
 Author: Dmitry Semigradsky 
 Date: Thu May 4 18:12:05 2023 +0300
 1 file changed, 3 insertions(+), 3 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: fix params names

PR-URL: #47853
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Harshitha K P [email protected]

[detached HEAD e179c7d87f] doc: fix params names
Author: Dmitry Semigradsky [email protected]
Date: Thu May 4 18:10:33 2023 +0300
1 file changed, 3 insertions(+), 3 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: capitalize the first characters

PR-URL: #47853
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Harshitha K P [email protected]

[detached HEAD bbe9a52c77] doc: capitalize the first characters
Author: Dmitry Semigradsky [email protected]
Date: Thu May 4 18:12:05 2023 +0300
1 file changed, 3 insertions(+), 3 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/4903281450

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@debadree25 debadree25 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels May 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 6, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 281ef80 into nodejs:main May 6, 2023
@nodejs-github-bot

nodejs-github-bot commented May 6, 2023

Copy link
Copy Markdown
Collaborator

Landed in 281ef80

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request May 12, 2023
@Semigradsky @targos
doc: fix params names
93f1aa2
PR-URL: #47853
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
@targos targos mentioned this pull request May 15, 2023
v20.2.0 release proposal #48020
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@Semigradsky @danielleadams
doc: fix params names
5c25789
PR-URL: #47853
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@Semigradsky @MoLow
doc: fix params names
49875f0
PR-URL: nodejs#47853
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@HarshithaKP HarshithaKP HarshithaKP approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. stream Issues and PRs related to Node.js streams.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Semigradsky @nodejs-github-bot @lpinca @HarshithaKP @debadree25
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.