GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — url: call `ada::can_parse` directly by anonrig · Pull Request #47919 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented May 8, 2023

Copy link
Copy Markdown
Member

We're planning on improving the performance of ada::can_parse and added this function in 2.3.1 release. This would make things a lot easier and more readable for Node.js.

cc @KhafraDev @nodejs/url

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented May 8, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels May 8, 2023
@anonrig
anonrig requested review from KhafraDev and TimothyGu May 8, 2023 15:44
lemire
lemire approved these changes May 8, 2023
View reviewed changes

@lemire lemire left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This opens up future optimization opportunities.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 8, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 8, 2023
@nodejs-github-bot

nodejs-github-bot commented May 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51701/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request May 9, 2023
CI Reliability 2023-05-09 nodejs/reliability#560
Open
29 tasks
KhafraDev
KhafraDev approved these changes May 9, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51713/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
anonrig force-pushed the ada-can-parse branch from 2076449 to bbd7705 Compare May 9, 2023 19:31
@anonrig

anonrig commented May 9, 2023

Copy link
Copy Markdown
Member Author

@nodejs/build I couldn't understand the root cause of the error in Test ASan build. Any ideas?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request May 10, 2023
CI Reliability 2023-05-10 nodejs/reliability#561
Open
25 tasks
jasnell
jasnell approved these changes May 10, 2023
View reviewed changes

@jasnell jasnell left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but looks like there's an asan issue in ada::url that needs looking at.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott

Trott commented May 10, 2023

Copy link
Copy Markdown
Member

LGTM but looks like there's an asan issue in ada::url that needs looking at.

Because the ASan output is massive and the relevant part can be hard to find, here's a link to the relevant part: https://github.com/nodejs/node/actions/runs/4929741771/jobs/8809762438?pr=47919#step:6:5394

Be patient while it loads. The relevant line starts with ==168106==ERROR:.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented May 10, 2023

Copy link
Copy Markdown
Member

LGTM but looks like there's an asan issue in ada::url that needs looking at.

Because the ASan output is massive and the relevant part can be hard to find, here's a link to the relevant part: https://github.com/nodejs/node/actions/runs/4929741771/jobs/8809762438?pr=47919#step:6:5394

Be patient while it loads. The relevant line starts with ==168106==ERROR:.

Ugh, that link didn't work. You need to scroll back up to line 5393.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig

anonrig commented May 10, 2023

Copy link
Copy Markdown
Member Author

Because the ASan output is massive and the relevant part can be hard to find, here's a link to the relevant part: https://github.com/nodejs/node/actions/runs/4929741771/jobs/8809762438?pr=47919#step:6:5394

Be patient while it loads. The relevant line starts with ==168106==ERROR:.

@lemire do you have any idea about the root cause of this error?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lemire
lemire reviewed May 10, 2023
View reviewed changes
Comment thread src/node_url.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
lemire
lemire reviewed May 10, 2023
View reviewed changes
Comment thread src/node_url.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@lemire

lemire commented May 10, 2023

Copy link
Copy Markdown
Member

@Trott I suspect it is not in ada that we have a memory error. See my comment above.
Trott reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced May 11, 2023
CI Reliability 2023-05-11 nodejs/reliability#562
Open
CI Reliability 2023-05-12 nodejs/reliability#563
Open
CI Reliability 2023-05-13 nodejs/reliability#564
Open
CI Reliability 2023-05-14 nodejs/reliability#565
Open
CI Reliability 2023-05-15 nodejs/reliability#566
Open
@anonrig
anonrig force-pushed the ada-can-parse branch from bbd7705 to 63fde1a Compare May 17, 2023 00:29
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 17, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 17, 2023
@nodejs-github-bot

nodejs-github-bot commented May 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51837/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request May 18, 2023
CI Reliability 2023-05-18 nodejs/reliability#569
Open
20 tasks
RaisinTen
RaisinTen reviewed May 18, 2023
View reviewed changes
Comment thread src/node_url.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
url: call ada::can_parse directly
f74541f
@anonrig
anonrig force-pushed the ada-can-parse branch from 63fde1a to f74541f Compare May 18, 2023 14:06
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 18, 2023
RaisinTen
RaisinTen approved these changes May 18, 2023
View reviewed changes

@RaisinTen RaisinTen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 18, 2023
@nodejs-github-bot

nodejs-github-bot commented May 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51865/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label May 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 18, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 8b6947f into main May 18, 2023
@nodejs-github-bot
nodejs-github-bot deleted the ada-can-parse branch May 18, 2023 17:49
@nodejs-github-bot

nodejs-github-bot commented May 18, 2023

Copy link
Copy Markdown
Collaborator

Landed in 8b6947f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced May 19, 2023
CI Reliability 2023-05-19 nodejs/reliability#570
Open
CI Reliability 2023-05-20 nodejs/reliability#571
Open
CI Reliability 2023-05-21 nodejs/reliability#572
Open
CI Reliability 2023-05-22 nodejs/reliability#573
Open
@github-actions github-actions Bot mentioned this pull request May 23, 2023
CI Reliability 2023-05-23 nodejs/reliability#574
Open
22 tasks
targos pushed a commit that referenced this pull request May 30, 2023
@anonrig @targos
url: call ada::can_parse directly
ebb6536 
PR-URL: #47919
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
@danielleadams danielleadams added the backport-requested-v18.x label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lemire lemire lemire approved these changes
@jasnell jasnell jasnell approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
@KhafraDev KhafraDev KhafraDev approved these changes
@TimothyGu TimothyGu Awaiting requested review from TimothyGu

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@anonrig @nodejs-github-bot @Trott @lemire @jasnell @RaisinTen @KhafraDev @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.