GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — permission: resolve reference to an absolute path only for fs permission by daeyeon · Pull Request #47930 · nodejs/node Conversation
|
|
/cc @nodejs/security-wg |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
For other candidate permissions, such as "net" or "env", this patch will pass the reference without resolving it to an absolute path. Signed-off-by: Daeyeon Jeong <[email protected]>
cbfbe91 to
74bc8eb
Compare
|
What other, non-path references are planned? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
AFAIK, it hasn't been discussed yet. I assume that, in the case of "env" permission, environment variable names would be used like: Although it isn't entirely clear, the conversion to an absolute path seems to be applied to the "fs" permission only, and there seems to be a plan to move it to the C++ side in the future. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
I'm currently working on moving the resolve path to c++ side, so this check will be handled there @RafaelGSS |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for confirming. It would be ideal to perform only type validation for the reference in JS side and let each permission C++ implementation handle parsing separately. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
That's correct. Eventually, we'll have
Correct, this is how it will work. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Landed in 4eec362 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
For other candidate permissions, such as "net" or "env", this patch will pass the reference without resolving it to an absolute path. Signed-off-by: Daeyeon Jeong <[email protected]> PR-URL: #47930 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.