GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — esm: do not use `'beforeExit'` on the main thread by aduh95 · Pull Request #47964 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented May 11, 2023

Copy link
Copy Markdown
Contributor

Fixes: #47929

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and iambumblehead reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@aduh95
esm: do not use 'beforeExit' on the main thread
498cbb8
@nodejs-github-bot

nodejs-github-bot commented May 11, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels May 11, 2023
GeoffreyBooth
GeoffreyBooth approved these changes May 11, 2023
View reviewed changes
Comment thread lib/internal/modules/esm/hooks.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes May 11, 2023
View reviewed changes
MoLow
MoLow approved these changes May 11, 2023
View reviewed changes
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 13, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 13, 2023
@nodejs-github-bot

nodejs-github-bot commented May 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51773/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label May 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 14, 2023
@nodejs-github-bot
nodejs-github-bot merged commit cdd20cf into nodejs:main May 14, 2023
@nodejs-github-bot

nodejs-github-bot commented May 14, 2023

Copy link
Copy Markdown
Collaborator

Landed in cdd20cf
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the beforeExit-main-thread branch May 14, 2023 06:21
@MoLow MoLow mentioned this pull request May 14, 2023
Error when: node v20, --test --loader, await import #47614
Closed
targos pushed a commit that referenced this pull request May 14, 2023
@aduh95 @targos
esm: do not use 'beforeExit' on the main thread
a7a7eab 
PR-URL: #47964
Fixes: #47929
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
targos pushed a commit that referenced this pull request May 15, 2023
@aduh95 @targos
esm: do not use 'beforeExit' on the main thread
1ec640a 
PR-URL: #47964
Fixes: #47929
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos mentioned this pull request May 15, 2023
v20.2.0 release proposal #48020
Merged
@danielleadams danielleadams added the backport-requested-v18.x label Jul 5, 2023
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95 @targos
esm: do not use 'beforeExit' on the main thread
a31ca4e 
PR-URL: nodejs#47964
Fixes: nodejs#47929
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos mentioned this pull request Nov 11, 2023
[v18.x] Backport most ESM and customization hook changes #50669
Closed
@targos targos added backported-to-v18.x and removed backport-requested-v18.x labels Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95 @targos
esm: do not use 'beforeExit' on the main thread
8cab32a 
PR-URL: #47964
Backport-PR-URL: #50669
Fixes: #47929
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: do not use 'beforeExit' on the main thread
85678ab 
PR-URL: nodejs/node#47964
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#47929
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: do not use 'beforeExit' on the main thread
721b5d9 
PR-URL: nodejs/node#47964
Backport-PR-URL: nodejs/node#50669
Fixes: nodejs/node#47929
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@anonrig anonrig anonrig approved these changes
@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node 20.1.0 --loader seems trigger beforeExit when use await import

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@aduh95 @nodejs-github-bot @GeoffreyBooth @anonrig @MoLow @targos @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.