GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: document node-api version process by legendecas · Pull Request #47972 · nodejs/node

Conversation

@legendecas

@legendecas legendecas commented May 12, 2023

Copy link
Copy Markdown
Member

With the change in #45715 landed, there are several code sites that need to be updated with the release Node-API version when a new Node-API version is being released.

This PR adds a document to the guides of a checklist necessary for creating a Node-API release PR.

Fixes: #47664

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@legendecas legendecas added the node-api Issues and PRs related to Node-API. label May 12, 2023
@nodejs-github-bot

nodejs-github-bot commented May 12, 2023 •
edited by legendecas
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
  • @nodejs/node-api
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label May 12, 2023
@legendecas
doc: document node-api version process
329d62d
@legendecas
legendecas force-pushed the node-api/release branch from ab68a3d to 329d62d Compare May 12, 2023 09:43
RafaelGSS
RafaelGSS approved these changes May 12, 2023
View reviewed changes
@gabrielschulhof

gabrielschulhof commented May 12, 2023

Copy link
Copy Markdown
Contributor

Please also document the process mentioned in #47975 (comment)!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva reviewed May 12, 2023
View reviewed changes
Comment thread doc/contributing/releases-node-api.md Outdated

and substitute this guard version with the release version `x`.

#### Step 4. Update test version guards

@VoltrexKeyva VoltrexKeyva May 12, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Step 4. Update test version guards
#### Step 3. Update test version guards

The next step is step 4.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@legendecas legendecas May 17, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread doc/contributing/releases-node-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/contributing/releases-node-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
gabrielschulhof
gabrielschulhof reviewed May 13, 2023
View reviewed changes

@gabrielschulhof gabrielschulhof left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc looks great! Just a few comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread doc/contributing/releases-node-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/contributing/releases-node-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/contributing/releases-node-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/contributing/releases-node-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/contributing/releases-node-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/contributing/releases-node-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/contributing/releases-node-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/contributing/releases-node-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
gabrielschulhof
gabrielschulhof reviewed May 13, 2023
View reviewed changes
Comment thread doc/contributing/releases-node-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@legendecas
fixup! doc: document node-api version process
375b836
@legendecas

legendecas commented May 17, 2023

Copy link
Copy Markdown
Member Author

@gabrielschulhof thanks for the suggestions! I've added a section to update the change history and backport the release to LTS lines. Please take a look again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aymen94
aymen94 approved these changes May 17, 2023
View reviewed changes
mhdawson
mhdawson approved these changes May 18, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gabrielschulhof
gabrielschulhof approved these changes May 19, 2023
View reviewed changes
@legendecas legendecas added the commit-queue PRs queued for automated landing through the Commit Queue. label May 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 19, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 1918241 into nodejs:main May 19, 2023
@nodejs-github-bot

nodejs-github-bot commented May 19, 2023

Copy link
Copy Markdown
Collaborator

Landed in 1918241
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas
legendecas deleted the node-api/release branch May 19, 2023 02:50
targos pushed a commit that referenced this pull request May 30, 2023
@legendecas @targos
doc: document node-api version process
0e4a3b7 
PR-URL: #47972
Fixes: #47664
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@legendecas @danielleadams
doc: document node-api version process
d60c99a 
PR-URL: #47972
Fixes: #47664
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@legendecas @MoLow
doc: document node-api version process
c22f739 
PR-URL: nodejs#47972
Fixes: nodejs#47664
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
+3 more reviewers
@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments
@mhdawson mhdawson mhdawson approved these changes
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. node-api Issues and PRs related to Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a Node-API release checklist

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@legendecas @nodejs-github-bot @gabrielschulhof @mhdawson @aymen94 @RafaelGSS @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.