GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update lint-md-dependencies to @rollup/[email protected] [email protected] by nodejs-github-bot · Pull Request #47995 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented May 14, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of lint-md-dependencies to @rollup/[email protected] [email protected].

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 14, 2023
@Trott

Trott commented May 14, 2023

Copy link
Copy Markdown
Member

The lint errors being reported by this change are incorrect AFAICT and seem to be fixed by undoing the update of micromark-extension-gfm-table from 1.0.5 to 1.0.6.

$ node tools/lint-md/lint-md.mjs doc/README.md
doc/README.md
  57:21  warning  Cell should be padded with 1 space, not 2  table-cell-padding  remark-lint
  59:20  warning  Cell should be padded                      table-cell-padding  remark-lint

⚠ 2 warnings
$ (cd tools/lint-md/ && npm install [email protected]) && make lint-md-rollup 
changed 1 package, and audited 193 packages in 506ms

129 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
rm -f tools/.*mdlintstamp
cd tools/lint-md && npm ci && npm run build

added 192 packages, and audited 193 packages in 531ms

129 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

> [email protected] build
> rollup -f es -p '@rollup/plugin-node-resolve={exportConditions: ["node"]}'  -p @rollup/plugin-commonjs -p rollup-plugin-cleanup lint-md.src.mjs --file lint-md.mjs


lint-md.src.mjs → lint-md.mjs...
created lint-md.mjs in 859ms
$ node tools/lint-md/lint-md.mjs doc/README.md
$
MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented May 14, 2023

Copy link
Copy Markdown
Member

https://github.com/orgs/micromark/discussions/146
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented May 16, 2023

Copy link
Copy Markdown
Member

A new version of remark-lint-table-cell-padding was published three hours ago to fix the issue here. I'll update this branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
tools: update remark-preset-lint-node to 4.0.0
134969b
@Trott
Trott force-pushed the actions/tools-update-lint-md-dependencies branch from eb6e725 to 134969b Compare May 16, 2023 17:15
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 16, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 16, 2023
@nodejs-github-bot

nodejs-github-bot commented May 16, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51829/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes May 16, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels May 16, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels May 16, 2023
@nodejs-github-bot

nodejs-github-bot commented May 16, 2023

Copy link
Copy Markdown
Collaborator Author
Commit Queue failed
- Loading data for nodejs/node/pull/47995
✔  Done loading data for nodejs/node/pull/47995
----------------------------------- PR info ------------------------------------
Title      tools: update lint-md-dependencies to @rollup/[email protected] [email protected] (#47995)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-lint-md-dependencies -> nodejs:main
Labels     tools, author ready
Commits    1
 - tools: update remark-preset-lint-node to 4.0.0
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/47995
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47995
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 14 May 2023 00:25:59 GMT
   ✔  Approvals: 1
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/47995#pullrequestreview-1429568755
   ✘  This PR needs to wait 96 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4997612820
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen approved these changes May 17, 2023
View reviewed changes
@RaisinTen RaisinTen added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels May 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 17, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 6774144 into main May 17, 2023
@nodejs-github-bot

nodejs-github-bot commented May 17, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in 6774144
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-lint-md-dependencies branch May 17, 2023 05:05
targos pushed a commit that referenced this pull request May 30, 2023
@nodejs-github-bot @targos
tools: update remark-preset-lint-node to 4.0.0
6adaf4c 
PR-URL: #47995
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@nodejs-github-bot @danielleadams
tools: update remark-preset-lint-node to 4.0.0
924bda2 
PR-URL: #47995
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@nodejs-github-bot @MoLow
tools: update remark-preset-lint-node to 4.0.0
ccd2795 
PR-URL: nodejs#47995
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@nodejs-github-bot @Trott @aduh95 @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.