GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — deps: update nghttp2 to 1.53.0 by nodejs-github-bot · Pull Request #47997 · nodejs/node

Conversation

nodejs-github-bot commented May 14, 2023

Copy link

Copy Markdown

Collaborator

This is an automated update of nghttp2 to 1.53.0.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot added the dependencies PRs that add, update, or configure Node.js dependencies. label

May 14, 2023

nodejs-github-bot commented May 14, 2023

Copy link

Copy Markdown

Collaborator Author

Review requested:

@nodejs/http2
@nodejs/net

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added http2

Issues and PRs related to the http2 subsystem.

needs-ci PRs that need a full CI run. labels

May 14, 2023

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

May 14, 2023

RafaelGSS approved these changes

May 14, 2023

View reviewed changes

RafaelGSS commented May 14, 2023

Copy link

Copy Markdown

Member

why is it conflicting? @marco-ippolito

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

May 14, 2023

marco-ippolito commented May 14, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

why is it conflicting? @marco-ippolito

because of this #46636 which changed #define NGHTTP2_VERSION_NUM 0x013400 , anyways it does not build

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented May 14, 2023

Copy link

Copy Markdown

Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51797/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          deps: update nghttp2 to 1.53.0

2be2202

marco-ippolito force-pushed the actions/tools-update-nghttp2 branch from a146d6f to 2be2202 Compare

May 14, 2023 18:09

github-actions Bot mentioned this pull request

May 15, 2023

CI Reliability 2023-05-15 nodejs/reliability#566

Open

17 tasks


          fix: missing file in nghttp2.gyp

a417d96

nodejs-github-bot commented May 15, 2023

Copy link

Copy Markdown

Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51814/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed needs-ci PRs that need a full CI run. labels

May 15, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

May 15, 2023

nodejs-github-bot commented May 15, 2023

Copy link

Copy Markdown

Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51815/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca approved these changes

May 15, 2023

View reviewed changes

github-actions Bot mentioned this pull request

May 16, 2023

CI Reliability 2023-05-16 nodejs/reliability#567

Open

19 tasks

nodejs-github-bot commented May 16, 2023

Copy link

Copy Markdown

Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51827/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced May 17, 2023

CI Reliability 2023-05-17 nodejs/reliability#568

Open

CI Reliability 2023-05-18 nodejs/reliability#569

Open

nodejs-github-bot commented May 18, 2023

Copy link

Copy Markdown

Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51863/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented May 18, 2023

Copy link

Copy Markdown

Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51864/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito approved these changes

May 18, 2023

View reviewed changes

marco-ippolito added commit-queue

PRs queued for automated landing through the Commit Queue.

commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels

May 18, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

May 18, 2023

nodejs-github-bot merged commit 3538e1b into main

May 18, 2023

nodejs-github-bot deleted the actions/tools-update-nghttp2 branch

May 18, 2023 13:59

nodejs-github-bot commented May 18, 2023

Copy link

Copy Markdown

Collaborator Author

Landed in 3538e1b

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced May 19, 2023

CI Reliability 2023-05-19 nodejs/reliability#570

Open

CI Reliability 2023-05-20 nodejs/reliability#571

Open

CI Reliability 2023-05-21 nodejs/reliability#572

Open

CI Reliability 2023-05-22 nodejs/reliability#573

Open

This was referenced May 23, 2023

CI Reliability 2023-05-23 nodejs/reliability#574

Open

CI Reliability 2023-05-24 nodejs/reliability#575

Open

CI Reliability 2023-05-25 nodejs/reliability#576

Open

targos pushed a commit that referenced this pull request

May 30, 2023


          deps: update nghttp2 to 1.53.0

d3e3a91

PR-URL: #47997
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>

targos mentioned this pull request

Jun 4, 2023

v20.3.0 release proposal #48332

Merged

danielleadams commented Jul 5, 2023

Copy link

Copy Markdown

Contributor

This should be backported to v18.x - it breaks the build on the staging branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danielleadams added the backport-requested-v18.x label

Jul 5, 2023

richardlau pushed a commit to richardlau/node-1 that referenced this pull request

Oct 11, 2023


          deps: update nghttp2 to 1.53.0

985a204

PR-URL: nodejs#47997
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>

richardlau mentioned this pull request

Oct 11, 2023

[v18.x] deps: update nghttp2 to 1.57.0 #50151

Closed

richardlau added backport-open-v18.x and removed backport-requested-v18.x labels

Oct 11, 2023

richardlau commented Oct 11, 2023

Copy link

Copy Markdown

Member

Opened a backport PR for this and other nghttp2 versions to Node.js 18: #50151

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau pushed a commit that referenced this pull request

Oct 12, 2023


          deps: update nghttp2 to 1.53.0

300a902

PR-URL: #47997
Backport-PR-URL: #50151
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>

richardlau added backported-to-v18.x and removed backport-open-v18.x labels

Oct 12, 2023

hermanbanken mentioned this pull request

Mar 27, 2024

Error: read ECONNRESET for Nodejs 20.3.0 (Never successful from this version) nodejs/help#4181

Closed

Reviewers

lpinca

lpinca approved these changes

RafaelGSS

RafaelGSS approved these changes

marco-ippolito

marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

dependencies

PRs that add, update, or configure Node.js dependencies.

http2

Issues and PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

nodejs-github-bot commented May 14, 2023

Uh oh!

nodejs-github-bot commented May 14, 2023

Uh oh!

RafaelGSS commented May 14, 2023

Uh oh!

marco-ippolito commented May 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented May 14, 2023

Uh oh!

nodejs-github-bot commented May 15, 2023

Uh oh!

nodejs-github-bot commented May 15, 2023

Uh oh!

nodejs-github-bot commented May 16, 2023

Uh oh!

nodejs-github-bot commented May 18, 2023

Uh oh!

nodejs-github-bot commented May 18, 2023

Uh oh!

nodejs-github-bot commented May 18, 2023

Uh oh!

danielleadams commented Jul 5, 2023

Uh oh!

richardlau commented Oct 11, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

marco-ippolito commented May 14, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.